Bug 151378 - [PATCH] fix pkg-cofig file created by www/kompozer and other build issues
Summary: [PATCH] fix pkg-cofig file created by www/kompozer and other build issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beat Gaetzi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-11 03:20 UTC by Steve Wills
Modified: 2011-03-01 15:14 UTC (History)
0 users

See Also:


Attachments
file.diff (1.82 KB, patch)
2010-10-11 03:20 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills 2010-10-11 03:20:00 UTC
installing www/kompozer creates a pkg-config file which is invalid and can cause problems when installing other ports.

Fix: see attached patch

Patch attached with submission follows:
How-To-Repeat: Install www/kompozer, run pkg-config. You'll see this error message:

Cflags field occurs twice in '/usr/local/libdata/pkgconfig/kompozer-xpcom.pc' 

and pkg-config will exit with error before processing all pkg-config files.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-10-11 03:20:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gecko

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Beat Gaetzi freebsd_committer freebsd_triage 2010-10-11 08:19:14 UTC
Responsible Changed
From-To: gecko->beat

I'll take it.
Comment 3 Beat Gaetzi freebsd_committer freebsd_triage 2010-12-01 11:04:28 UTC
Hi,

Sorry that this pr is open for such a long time but I've done a lot of
testing with kompozer during the last weeks and I'm not able to
reproduce the pkg-config error nor the build issues on my workstation
and on my tinderbox.

Could you please provide some additional information how to trigger both
issues?

Thanks,
Beat
Comment 4 Steve Wills 2010-12-02 03:16:39 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/01/10 06:04, Beat Gaetzi wrote:
> Hi,
> 
> Sorry that this pr is open for such a long time but I've done a lot of
> testing with kompozer during the last weeks and I'm not able to
> reproduce the pkg-config error nor the build issues on my workstation
> and on my tinderbox.
> 
> Could you please provide some additional information how to trigger both
> issues?

Sure. For the pkg-config error, install kompozer, then run:

pkg-config --list-all

When I do this, I get an error like this:

Cflags field occurs twice in
'/usr/local/libdata/pkgconfig/kompozer-xpcom.pc'

Just now when trying to reproduce it, I had to deinstall then reinstall
kompozer for it to happen.

As far as the build error, I'm unable to recall the exact error, but I
did try to build it in my tinderbox and got this:


checking that static assertion macros used in autoconf tests work...
checking that static assertion macros used in autoconf tests work...
cat: conftest.c: No such file or directory
no
configure: error: Compiler cannot compile macros used in autoconf tests.
*** Fix above errors and then restart with               "gmake -f
client.mk build"
gmake[1]: *** [configure] Error 1

See:

http://meatwad.mouf.net/tb/errors/8-STABLE-amd64-FreeBSD/kompozer-0.8.b3_1.log

for more detail.

The patch may or may not fix that error.

Steve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJM9w+XAAoJEPXPYrMgexuhIYoIAKZzhir0XG95nXgfAnpbPyef
kdsoHr2XHu75nh+vf20m8V5k/r0lggFnsy64DRdsAiOxAxUJOdD96J+YXfbVHFde
tT9ac5R7F2pYeI40ZE/aZ1fKnyoNShOcZ/d9xcJI5NDj2GwWwW/eTtUBSG8oRyrz
d0qhF3AsYn4faiV/gC557QgmdLYEYdAdiIAFpmqSTHhNUgO4OKDXBY+H9cwF5yz2
Odcm8lhKYInbjxT0IiuE5/AmlNhS2WdA+f2c+ySMvIGf6jjXGTEblDVBytnO9a5K
voMw+tX0qnrKCkzZ6W335mjksc+7RkE4rHsAY9sByrzM39OF48JE+Qq/z4vEYkw=
=ma/M
-----END PGP SIGNATURE-----
Comment 5 Beat Gaetzi freebsd_committer freebsd_triage 2010-12-13 12:10:02 UTC
Hi,

Thanks for the information. I was able to reproduce the pkg-config
problem. It looks like your build problem only occurs with non default
options set. Could you please send me all your changed options and make
variables?

Thanks,
Beat
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-01-25 22:56:08 UTC
beat        2011-01-25 22:56:02 UTC

  FreeBSD ports repository

  Modified files:
    www/kompozer         Makefile 
    www/kompozer/files   patch-build_unix_mozilla-xpcom.pc.in 
  Log:
  - Fix pkg-config file
  - Bump PORTREVISION
  
  PR:             ports/151378
  Submitted by:   swills@
  Feature safe:   yes
  
  Revision  Changes    Path
  1.49      +1 -1      ports/www/kompozer/Makefile
  1.3       +7 -6      ports/www/kompozer/files/patch-build_unix_mozilla-xpcom.pc.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Eitan Adler freebsd_committer freebsd_triage 2011-03-01 15:14:11 UTC
State Changed
From-To: open->closed

committed - thanks!