I updated a box running apache 2.2 with multiple profiles to the 2.2.16_2 version. Controlling the individual profiles suddenly stopped working, and I traced it down to the pidfile being written incorrectly. It was always writing the pid file as /var/run/httpd.pid regardless of the profile I was starting. I looked into the port's change long on freshports and discovered that the patch from 2.2.16_1 to 2.2.16_2 introduced this change. The comment indicates that "With profiles the old defaults remain unchanged" which is incorrect. To achieve this change the following patch is required. This would have been disastrous had this happened on a production server rather than a development server. Fix: This patch restores the original default pid file value for systems with apache and profiles. Without it, each apache instance will overwrite the /var/run/httpd.pid file causing great confusion when you try to stop/restart one of the profiles. You can still override the pid file with the new config settings (which are totally not documented in the apache22 rc.d file, either.) How-To-Repeat: Set up a system running 2.2.16_1 with at least two profiles that write to different PID files. They will be named /var/run/httpd.PROFILENAME.pid Now upgrade to 2.2.16_2 and start the profiles. Now try to stop just one of them. The one started last will be stopped because the pidfile is now called /var/run/httpd.pid for all instances. Note also how it totally overrides the PidFile directive in the httpd.conf for each profile.
pgollucci 2010-10-21 18:00:15 UTC FreeBSD ports repository Modified files: www/apache22 Makefile www/apache22/files apache22.in Log: - The previous update to the rc.d script didn't quite maintain the old behavior correctly. This fixes the pid file name PR: ports/151623 Submitted by: Vivek Khera <vivek@khera.org> With Hat: apache@ Point hat to: myself (pgollucci) Revision Changes Path 1.283 +1 -0 ports/www/apache22/Makefile 1.10 +2 -1 ports/www/apache22/files/apache22.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!