Bug 151819 - [patch] net-p2p/uhub port improvements
Summary: [patch] net-p2p/uhub port improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-29 19:40 UTC by Aragon Gouveia
Modified: 2010-11-11 10:40 UTC (History)
0 users

See Also:


Attachments
file.diff (3.21 KB, patch)
2010-10-29 19:40 UTC, Aragon Gouveia
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aragon Gouveia 2010-10-29 19:40:07 UTC
Attached patch makes some improvements to the net-p2p/uhub port:

* Sets up a uhub UID and GID for the daemon to run as.
* Modifies configuration file permissions to restrict them to root and the above GID.
* Patches uhub source so that PREFIX/etc/uhub/uhub.conf is the compiled in default configuration file.
* rc.d script changes - enable above uid/gid, enable syslog logging, simplify.

I think these changes are an improvement.  Please consider committing them.

Thanks!

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-10-29 19:40:13 UTC
Maintainer of net-p2p/uhub,

Please note that PR ports/151819 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/151819

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-10-29 19:40:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Yashin 2010-10-29 20:42:10 UTC
thx, i agree
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-11-11 10:31:41 UTC
stefan      2010-11-11 10:31:35 UTC

  FreeBSD ports repository

  Modified files:
    .                    UIDs GIDs 
    net-p2p/uhub         Makefile 
    net-p2p/uhub/files   uhub.sh.in 
  Log:
  * Sets up a uhub UID and GID for the daemon to run as.
  * Modifies configuration file permissions to restrict them to root and the above
    GID.
  * Patches uhub source so that PREFIX/etc/uhub/uhub.conf is the compiled in
    default configuration file.
  * rc.d script changes - enable above uid/gid, enable syslog logging, simplify.
  
  PR:             151819
  Submitted by:   Aragon Gouveia <aragon@phat.za.net>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.114     +2 -1      ports/GIDs
  1.127     +2 -1      ports/UIDs
  1.8       +15 -8     ports/net-p2p/uhub/Makefile
  1.3       +5 -7      ports/net-p2p/uhub/files/uhub.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Stefan Walter freebsd_committer freebsd_triage 2010-11-11 10:31:44 UTC
State Changed
From-To: feedback->closed

Committed, thanks!