Bug 152059 - devel/pear/bsd.pear.mk: Fix a plist generation bug when no files are installed into a directory.
Summary: devel/pear/bsd.pear.mk: Fix a plist generation bug when no files are installe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-08 18:40 UTC by Tom Judge
Modified: 2010-12-29 07:10 UTC (History)
1 user (show)

See Also:


Attachments
bsd.pear.mk.dir-fix.txt (680 bytes, text/plain)
2010-11-08 18:40 UTC, Tom Judge
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Judge 2010-11-08 18:40:06 UTC
When using bsd.pear.mk for pear modules it is possible to generate a plist missing some @rmdir statements.

Consider the following:
TESTS=		Latin1Test.php locale/en_GB/LC_MESSAGES/test.mo \
                locale/en_GB/LC_MESSAGES/test.php locale/en_GB/LC_MESSAGES/test.po \
                locale/en_GB/LC_MESSAGES/test2.mo locale/en_GB/LC_MESSAGES/test2.po \
                locale/es_ES/LC_MESSAGES/test.mo locale/es_ES/LC_MESSAGES/test.po \
                locale/fr_FR/LC_MESSAGES/test.mo locale/fr_FR/LC_MESSAGES/test.php \
                locale/fr_FR/LC_MESSAGES/test.po locale/fr_FR/LC_MESSAGES/test2.mo \
                locale/fr_FR/LC_MESSAGES/test2.php locale/fr_FR/LC_MESSAGES/test2.po

The current code will generate @rmdir's for:

locale/en_GB/LC_MESSAGES
locale/es_ES/LC_MESSAGES
locale/fr_FR/LC_MESSAGES

But not for:

locale/en_GB
locale/es_ES
locale/fr_FR
locale

The attached patch fixes the DIRFILTER to generate the missing @rmdir's.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-08 18:40:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-12-29 07:02:54 UTC
miwi        2010-12-29 07:02:48 UTC

  FreeBSD ports repository

  Modified files:
    devel/pear           Makefile bsd.pear.mk 
  Log:
  - Add support for pear modules to have non .tgz extensions.
  - Fix a plist generation bug when no files are installed into a directory.
  
  PR:             152059 152055
  Submitted by:   Tom Judge <tom@tomjudge.com>
  Tested via:     pointyhat
  
  Revision  Changes    Path
  1.35      +1 -0      ports/devel/pear/Makefile
  1.10      +18 -2     ports/devel/pear/bsd.pear.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2010-12-29 07:03:22 UTC
State Changed
From-To: open->closed

Committed. Thanks!