Please upgrade the port reflecting the new software release.
Maintainer of math/polymake, Please note that PR ports/152152 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152152 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On 11/12/2010 09:33 AM, Edwin Groothuis wrote: > Maintainer of math/polymake, > > Please note that PR ports/152152 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152152 > Yes, I agree with the patch, as I've written it myself :-) I wonder if it could be possible to hide the submitter's E-Mail address from the PR page or at least obfuscate it as to make it a little bit harder to harvest by spam senders. I think, putting valid E-Mail addresses on publicly viewable Webpages is no more seasonable. Thank you! -- Ewgenij
Hi Ewgenij, notification of the maintainer is automatic; your PR was sent from a different mail address than is registered in the port (and wasn't tagged as a "maintainer-update"), so the script that checked your PR did not recognize you as the maintainer and sent that notification mail. Could you send a followup with your update to the port in unified diff format (as produced by "diff -urN")? That makes it easier to see what changed than with a shar file, and thus is the preferred way of sending updates to existing ports. Regards, Stefan
> Hi Ewgenij, > > notification of the maintainer is automatic; your PR was sent from a > different mail address than is registered in the port (and wasn't tagged > as a "maintainer-update"), so the script that checked your PR did not > recognize you as the maintainer and sent that notification mail. > It's not a problem to get a notification; what I don't enjoy very much is to see my private E-mail address in pure form on the publicly accessible PR web page. Where have I to place this maintainer-update tag - in the subject? > Could you send a followup with your update to the port in unified diff > format (as produced by "diff -urN")? That makes it easier to see what > changed than with a shar file, and thus is the preferred way of sending > updates to existing ports. Do you want to compare it with the previous submitted version 2.3? It has changed a lot in between; I guess the diff is twice as long as the shar file. Here you are, anyway.
Hi Ewgenij, I built polymake-2.9.9 last night, and it looks like a really nice program. I am a brand new ports committer, and I would like to go ahead and commit your changes. But being brand new, I am required to get approval from mentors before I commit changes. In the meantime, I have some questions about your program. 1. When I first run the program, I get a message "Unquoted string "v" may clash with future reserved word at (eval 583) line 2." This only seems to happen when the program creates .polymake. Maybe this isn't a big deal. 2. When I tried to view an object, the program used "gv" to produce the image. I got the impression from the documentation that the program was meant to use "javaview" and that maybe I could rotate the object from the screen. I am using diablo-jdk16 for java - could this be part of the reason, or is it something else? I must admit that I have only tried the short code segments that appear in your introductionary tutoral. 3. In the port Makefile, you only have one MASTER_SITE. The FreeBSD people prefer at least two. Are there any mirrors of this software? Finally, I see on your web page that there is a version 2.10 that has come out. I look forward to seeing this update submitted soon. (But let me commit version 2.9.9 first.) Stephen
Responsible Changed From-To: freebsd-ports-bugs->stephen I'll take it.
Another question. In your Makefile you have these lines: # until new patches appear # ${RM} -f `find ${WRKSRC} -name '*.orig'` Usually we don't bother remove the *.orig files after applying patches. Is there a specific reason why you would want to remove them in this case? Otherwise we would prefer to simply remove these lines.
State Changed From-To: feedback->closed Committed, with several changes, including a warning that this port build may overwhelm some computers if MAKE_NUMBER_JOBS is set too large.
stephen 2011-06-28 01:41:52 UTC FreeBSD ports repository Modified files: math/polymake Makefile distinfo pkg-descr pkg-plist Removed files: math/polymake/files patch-support_build.make Log: - Update to 2.9.9 - Add warning that make_jobs_safe may overwhelm some computers - Portlint PR: ports/152152 Submitted by: Ewgenij Gawrilow <ewgenij.gawrilow@o2online.de> Approved by: maho (mentor) Revision Changes Path 1.15 +46 -39 ports/math/polymake/Makefile 1.9 +2 -4 ports/math/polymake/distinfo 1.2 +0 -13 ports/math/polymake/files/patch-support_build.make (dead) 1.4 +8 -11 ports/math/polymake/pkg-descr 1.5 +772 -1309 ports/math/polymake/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"