Bug 152213 - [PATCH] print/pdftk: Mark MAKE_JOBS_UNSAFE
Summary: [PATCH] print/pdftk: Mark MAKE_JOBS_UNSAFE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-13 21:30 UTC by Matthias Andree
Modified: 2010-11-18 13:50 UTC (History)
1 user (show)

See Also:

Attachments
pdftk-1.44.patch (459 bytes, patch)
2010-11-13 21:30 UTC, Matthias Andree 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree 2010-11-13 21:30:09 UTC 
Hi Greg,

the port fails to build on a quadcore computer with forced parallel
builds.  Could you check if you can fix that? If not, I propose to mark
MAKE_JOBS_UNSAFE as in the patch below.

Thanks.

Port maintainer (glarkin@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-13 21:30:34 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Greg Larkin freebsd_committer freebsd_triage 2010-11-17 19:39:03 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Matthias,

Can you apply this patch to the pdftk port and try your build again?

http://people.freebsd.org/~glarkin/diffs/print-pdftk-enable-parallel-make.diff

This fixed the build problem for me in my test VM.  I re-ordered some
dependencies in the pdftk Makefile.

Thank you,
Greg
- --
Greg Larkin

http://www.FreeBSD.org/           - The Power To Serve
http://www.sourcehosting.net/     - Ready. Set. Code.
http://twitter.com/sourcehosting/ - Follow me, follow you
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD4DBQFM5C9X0sRouByUApARAtvEAKCWW2FEmnf0HpsIXtLEF7jO202NBwCXcL4/
JfI+itTyPe4n+LVdd0RXmA==
=68rh
-----END PGP SIGNATURE-----
Comment 3 Greg Larkin freebsd_committer freebsd_triage 2010-11-17 19:39:23 UTC 
State Changed
From-To: open->analyzed

Waiting for feedback on new proposed patch to enable parallel make.
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2010-11-18 11:47:46 UTC 
Am 17.11.2010 20:39, schrieb Greg Larkin:
> Can you apply this patch to the pdftk port and try your build again?

Yes.

> http://people.freebsd.org/~glarkin/diffs/print-pdftk-enable-parallel-make.diff
> 
> This fixed the build problem for me in my test VM.  I re-ordered some
> dependencies in the pdftk Makefile.

Works for me, too.  Thanks a bunch!

-- 
Matthias Andree
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-11-18 13:45:26 UTC 
glarkin     2010-11-18 13:45:22 UTC

  FreeBSD ports repository

  Added files:
    print/pdftk/files    patch-pdftk__Makefile.Base 
  Log:
  - Rearranged the dependency order in the upstream Makefile to enable
    building with MAKE_JOBS_SAFE=yes
  
  PR:             ports/152213
  Submitted by:   Matthias Andree <matthias dot andree at gmx dot de>
  
  Revision  Changes    Path
  1.1       +29 -0     ports/print/pdftk/files/patch-pdftk__Makefile.Base (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Greg Larkin freebsd_committer freebsd_triage 2010-11-18 13:45:47 UTC 
State Changed
From-To: analyzed->closed

I committed a patch that rearranges the dependency order in the upstream 
Makefile. pdftk now builds correctly with MAKE_JOBS_SAFE=yes.