Bug 153046 - [PATCH] fix to stop bsd.lua.mk ignoring user supplied WITH_LUA_VER
Summary: [PATCH] fix to stop bsd.lua.mk ignoring user supplied WITH_LUA_VER
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alejandro Pulver
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-12 15:10 UTC by Jase Thew
Modified: 2011-01-06 18:50 UTC (History)
0 users

See Also:


Attachments
file.diff (478 bytes, patch)
2010-12-12 15:10 UTC, Jase Thew
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jase Thew 2010-12-12 15:10:09 UTC
Due to an incorrect list assignment in bsd.lua.mk, ports with no hardcoded lua version requirement will ignore WITH_LUA_VER (which is used to specify which installed version of lua to build a port against) and will instead use the highest version of lua installed.

Fix: Modify Mk/bsd.lua.mk as in the attached patch.


Patch attached with submission follows:
How-To-Repeat: 1. Install both lang/lua50 and lang/lua51 ports
2. Pick a port that will allow building against 5.0 or 5.1 (eg, irc/weechat-devel)
3. 'export WITH_LUA_VER=5.0'
4. 'make configure' the port picked in step #2.
5. notice that the port depends on lua-5.1.x not lua-5.0.x as specified in step #3.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-12 15:10:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

bsd.lua.mk is alepulver territory (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-01-06 18:45:36 UTC
alepulver    2011-01-06 18:45:31 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.lua.mk 
  Log:
  - Respect WITH_LUA_VER.
  
  PR:             153046
  Submitted by:   Jase Thew <freebsd@beardz.net>
  
  Revision  Changes    Path
  1.21      +2 -2      ports/Mk/bsd.lua.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alejandro Pulver freebsd_committer freebsd_triage 2011-01-06 18:46:00 UTC
State Changed
From-To: open->closed

Committed. Thanks!