Bug 153179 - net-mgmt/net-snmp corrected memory stats output patch
Summary: net-mgmt/net-snmp corrected memory stats output patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-15 14:00 UTC by Yevgeniy Averin
Modified: 2011-02-03 19:40 UTC (History)
0 users

See Also:

Attachments
file.diff (3.83 KB, patch)
2010-12-15 14:00 UTC, Yevgeniy Averin 		no flags Details | Diff
patch-memory_freebsd.c.txt (3.82 KB, patch)
2010-12-15 14:45 UTC, Yevgeniy Averin 		no flags Details | Diff
patch-memory_freebsd.c (6.38 KB, text/plain; x-mac-type="0"; x-mac-creator="0")
2010-12-22 21:56 UTC, Charles Owens 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yevgeniy Averin 2010-12-15 14:00:19 UTC 
hi!

I create new version of patch-memory_freebsd.c which give us mostly right memory statistic output for UCD-SNMP-MIB and HOST_RESOURSE-MIB.

Fix: take this patch and replace files/patch-memory_freebsd.c from net-snmp port dir

Patch attached with submission follows:
How-To-Repeat: compare output from snmpwalk memory from host and sysctl vm.stats.vm
Comment 1 Yevgeniy Averin 2010-12-15 14:45:41 UTC 
sorry, here latest version of patch
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2010-12-16 00:21:35 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Fix synopsis and assign.
Comment 3 Charles Owens 2010-12-22 21:56:19 UTC 
I've pretty extensively grokked and tested the Dec 15th patch... and it 
definitely is a big improvement (as far as my understanding of these OS 
stats and the UCD-SNMP MIB definitions goes).  The one problem that I 
found remaining is with reporting of swap size/free.  The reported 
values didn't at all match what's reported by swapinfo (on big-RAM 
systems you get a nice negative number).

As such I'm supplying another patch that adds to the Dec 15th patch 
what's needed.  I've simply borrowed directly from 
/usr/src/usr.sbin/pstat/pstat.c (swapinfo's source)... so the method is 
certainly sound (an hopefully the final result).  In my tests it appears 
to work well.

Hope this helps in getting this issue resolved.


Thanks, Charles

-- 
  Charles Owens
  Great Bay Software, Inc.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-02-03 19:34:46 UTC 
sylvio      2011-02-03 19:34:40 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/net-snmp/files patch-memory_freebsd.c 
  Log:
  - new version of patch-memory_freebsd.c
  - right memory statistic output for UCD-SNMP-MIB and HOST_RESOURSE-MIB.
  
  PR:             ports/153179
  Submitted by:   "Y.A." <nexther0@gmail.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.7       +62 -9     ports/net-mgmt/net-snmp/files/patch-memory_freebsd.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2011-02-03 19:36:56 UTC 
State Changed
From-To: open->closed

Committed. Thanks!