Bug 153350 - mail/assp: fix permissions for periodic script
Summary: mail/assp: fix permissions for periodic script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Olli Hauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 18:30 UTC by rnejdl
Modified: 2011-01-09 19:01 UTC (History)
0 users

See Also:


Attachments
assp.diff (851 bytes, patch)
2010-12-21 18:30 UTC, rnejdl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rnejdl 2010-12-21 18:30:17 UTC
	This patch fixes the permissions of the assp directory after the periodic script runs.  Because the periodic infrastructure can only run as root, the only way to correct the permissions is to chown the files back to assp:assp after each run.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2010-12-21 19:55:04 UTC
Class Changed
From-To: sw-bug->maintainer-update

Fix synopsis and class.
Comment 2 Olli Hauer freebsd_committer freebsd_triage 2011-01-05 08:42:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ohauer

I'll take it.
Comment 3 Olli Hauer freebsd_committer freebsd_triage 2011-01-05 19:36:52 UTC
Hello Rusty,

I recognized the source file for assp is no longer available on SF.net
and there is a new version 1.8.5.0.

Additional there are some other minor issues
 - until now the port used a fix but unregistered UID/GID
   => fixed I have the UID/GID registered in ports/(UID/GID)s
   => use ports framework to create the user (user is not created if installed
from package)

 - softlinks are created only during port install not during package install
   => I will move those commands to a pkg-install script

Can you please test if the new 1.8.5.0 version is production ready?

--
olli
Comment 4 rnejdl 2011-01-05 19:53:07 UTC

On Wed, 05 Jan 2011 20:36:52 +0100, Olli Hauer wrote: 

> Hello
Rusty,
> 
> I recognized the source file for assp is no longer available
on SF.net
> and there is a new version 1.8.5.0.
> 
> Additional there
are some other minor issues
> - until now the port used a fix but
unregistered UID/GID
> => fixed I have the UID/GID registered in
ports/(UID/GID)s
> => use ports framework to create the user (user is
not created if installed
> from package)
> 
> - softlinks are created
only during port install not during package install
> => I will move
those commands to a pkg-install script
> 
> Can you please test if the
new 1.8.5.0 version is production ready?
> 
> --
> olli

Thank you and I
will test that in the next few days and confirm. Fritz releases updates
quite often for assp so it is hard to keep up sometimes. 

Rusty Nejdl
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-01-06 16:26:58 UTC
ohauer      2011-01-06 16:26:53 UTC

  FreeBSD ports repository

  Modified files:
    mail/assp            Makefile pkg-plist 
    mail/assp/files      periodic-assp.in periodic-assp.sh.in 
  Added files:
    mail/assp/files      pkg-install.in 
  Log:
   - fix periodic script(s) [1] [2]
   - use ports framework to create user/group
   - add pkg-install script to create links and directories
     so they are created during package install
   - use COPYTREE_SHARE instead of fix permissions and use INSTALL_DATA
   - fix order of pkg-plist
   - bump PORTREVISION
  
  PR:             [1] ports/152365 [2] ports/153350 (maintainer)
  Submitted by:   [1] Marco Walraven [2] Rusty Nejdl (maintainer)
  
  Revision  Changes    Path
  1.30      +15 -40    ports/mail/assp/Makefile
  1.2       +2 -2      ports/mail/assp/files/periodic-assp.in
  1.6       +2 -1      ports/mail/assp/files/periodic-assp.sh.in
  1.7       +20 -0     ports/mail/assp/files/pkg-install.in (new)
  1.14      +9 -9      ports/mail/assp/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2011-01-06 17:08:29 UTC
Hi Rusty,

what do you think about renaming files/periodic-assp.sh.in to files/510.assp.in?

If you agree I will open a change-request so we get rid of the second
periodic script (duplicate) preserve history and clear confusion about
those two scripts.

--
olli
Comment 7 rnejdl 2011-01-06 17:22:59 UTC
  

On Thu, 06 Jan 2011 18:08:29 +0100, Olli Hauer wrote: 

> Hi
Rusty,
> 
> what do you think about renaming files/periodic-assp.sh.in
to files/510.assp.in?
> 
> If you agree I will open a change-request so
we get rid of the second
> periodic script (duplicate) preserve history
and clear confusion about
> those two scripts.
> 
> --
> olli

Olli,


Go ahead and implement all of the changes you are suggesting. I am
updating my virtualbox freebsd machine now to test ASSP in a sandbox
now. 

Rusty 
Comment 8 Olli Hauer freebsd_committer freebsd_triage 2011-01-09 19:00:31 UTC
State Changed
From-To: open->closed

Committed, 
Thanks!