Bug 153704 - [patch] multimedia/libvdpau: respect STRIP
Summary: [patch] multimedia/libvdpau: respect STRIP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 14:00 UTC by swell.k
Modified: 2011-01-13 10:30 UTC (History)
0 users

See Also:

Attachments
a.diff (974 bytes, patch)
2011-01-05 14:00 UTC, swell.k 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description swell.k 2011-01-05 14:00:18 UTC 
- use install-strip by default
- move license block closer to maintainer section
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-05 14:00:28 UTC 
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-05 14:00:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

pgollucci@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2011-01-12 00:59:41 UTC 
Responsible Changed
From-To: pgollucci->freebsd-ports-bugs

E-NO-TIME right now, back to pool
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2011-01-12 21:33:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 5 swell.k 2011-01-12 21:59:26 UTC 
- forget LICENSE reordering, subject to one's perception
- increase verbosity for WITH_DEBUG build

--- a.diff begins here ---
Index: multimedia/libvdpau/Makefile
===================================================================
RCS file: /a/.cvsup/ports/multimedia/libvdpau/Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 Makefile
--- multimedia/libvdpau/Makefile	24 Sep 2010 19:06:00 -0000	1.1
+++ multimedia/libvdpau/Makefile	12 Jan 2011 21:48:09 -0000
@@ -22,8 +22,18 @@ USE_LDCONFIG=	yes
 LICENSE=	MIT
 LICENSE_FILE=	${WRKSRC}/COPYING
 
+.include <bsd.port.pre.mk>
+
+.if defined(WITH_DEBUG)
+CFLAGS+=	-DDEBUG
+.endif
+
+.if defined(STRIP) && ${STRIP} != ""
+INSTALL_TARGET=	install-strip
+.endif
+
 post-patch:	.SILENT
 	${REINPLACE_CMD} 's|$$(libdir)/\(pkgconfig\)|$$(prefix)/libdata/\1|' \
 		${WRKSRC}/Makefile.in
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- a.diff ends here ---
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-01-13 10:20:56 UTC 
makc        2011-01-13 10:20:52 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/libvdpau  Makefile 
  Log:
  Respect DEBUG/STRIP
  
  PR:             ports/153704
  Submitted by:   swell.k (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.2       +12 -1     ports/multimedia/libvdpau/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2011-01-13 10:21:20 UTC 
State Changed
From-To: open->closed

Committed. Thanks!