Bug 153923 - [PATCH] update www/bigbluebutton
Summary: [PATCH] update www/bigbluebutton
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-12 09:40 UTC by alex.deiter
Modified: 2011-01-15 12:21 UTC (History)
0 users

See Also:


Attachments
file.diff (21.08 KB, patch)
2011-01-12 09:40 UTC, alex.deiter
no flags Details | Diff
bigbluebutton-patch.txt (20.57 KB, text/plain)
2011-01-14 14:21 UTC, alex.deiter
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description alex.deiter 2011-01-12 09:40:07 UTC
1. Update Makefile:
 - clean tabs
 - use different master sites URL for different files
 - remove unused options
 - add freeswitch user option
 - bump portrevision

2. Update bbb-conf script:
 - add freeswitch user
 - check installed packages
 - add start / stop options
 - verify host names with getent

3. Update rc script for openoffice:
 - set and use HOME env

4. Update pkg-message:
 - add note about hostname resolution
 - add start note

5. Clean pkg-plist

Fix: apply patch

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/www
patch -p0 < patch-bigbluebutton.txt
cd bigbluebutton && make install
Comment 1 Wen Heping freebsd_committer freebsd_triage 2011-01-13 00:40:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wen

I'll take it.
Comment 2 wenheping 2011-01-14 06:59:53 UTC
Hi,

   Two problems:

    1 s/JAR/TAR/Makefile ?

    2 why remove "@dirrmtry %%WWWDIR%%" from plist ?
It will result in plist error.



wen
Comment 3 alex.deiter 2011-01-14 07:24:27 UTC
Hi,

1. No:

x4150b# cd /usr/ports/www/bigbluebutton
x4150b# grep -A 1 JAR Makefile
	@cd ${WRKDIR}/bigbluebutton-tomcat && ${JAR} xf \
		${WRKDIR}/bigbluebutton.war

war file - http://en.wikipedia.org/wiki/WAR_%28Sun_file_format%29

WAR file (or Web application ARchive[1]) is a JAR file used to 
distribute a collection of JavaServer Pages, servlets, Java classes, XML 
files, tag libraries and static Web pages (HTML and related files) that 
together constitute a Web application.

2. I'm sorry. "@dirrmtry %%WWWDIR%%" must be in plist.

Thanks a lot!

14.01.2011 09:59, wen heping пиÑеÑ:
> Hi,
>
>     Two problems:
>
>      1 s/JAR/TAR/Makefile ?
>
>      2 why remove "@dirrmtry %%WWWDIR%%" from plist ?
> It will result in plist error.
>
>
>
> wen
Comment 4 wenheping 2011-01-14 09:08:46 UTC
2011/1/14 Alex Deiter <alex.deiter@gmail.com>:
> Hi,
>
> 1. No:
>
> x4150b# cd /usr/ports/www/bigbluebutton
> x4150b# grep -A 1 JAR Makefile
> =C2=A0 =C2=A0 =C2=A0 =C2=A0@cd ${WRKDIR}/bigbluebutton-tomcat && ${JAR} x=
f \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${WRKDIR}/bigblueb=
utton.war

Here is in the "make extract" phase when diablo-java was not added to
the system,
so it will result in build error when build on the tinderbox:
http://wen.freebsd.your.org/tb/errors/7.3-FreeBSD/bigbluebutton-0.71_1.log

Also it could build on my physical box , better we fix it.

Maybe add a EXTRACT_DEPENDS ?


wen



>
> war file - http://en.wikipedia.org/wiki/WAR_%28Sun_file_format%29
>
> WAR file (or Web application ARchive[1]) is a JAR file used to distribute=
 a
> collection of JavaServer Pages, servlets, Java classes, XML files, tag
> libraries and static Web pages (HTML and related files) that together
> constitute a Web application.
>
> 2. I'm sorry. "@dirrmtry %%WWWDIR%%" must be in plist.
>
> Thanks a lot!
>
> 14.01.2011 09:59, wen heping =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>
>> Hi,
>>
>> =C2=A0 =C2=A0Two problems:
>>
>> =C2=A0 =C2=A0 1 s/JAR/TAR/Makefile ?
>>
>> =C2=A0 =C2=A0 2 why remove "@dirrmtry %%WWWDIR%%" from plist ?
>> It will result in plist error.
>>
>>
>>
>> wen
>



--=20
=E7=9C=9F=E7=90=86=E4=BB=8E=E6=9D=A5=E6=B2=A1=E6=9C=89=E6=88=98=E8=83=9C=E8=
=BF=87=E8=B0=AC=E8=AF=AF=EF=BC=8C=E7=9C=9F=E7=90=86=E5=8F=AA=E6=9C=89=E5=9C=
=A8=E5=9D=9A=E6=8C=81=E8=B0=AC=E8=AF=AF=E7=9A=84=E4=BA=BA=E6=AD=BB=E5=8E=BB=
=E5=90=8E=E6=89=8D=E6=88=90=E4=B8=BA=E7=9C=9F=E7=90=86=E3=80=82
Comment 5 alex.deiter 2011-01-14 14:21:31 UTC
Hi,

Thank you for update!
I found solution:

JAVA_EXTRACT=   yes

/usr/ports/Mk/bsd.java.mk:.		if defined(JAVA_EXTRACT)
/usr/ports/Mk/bsd.java.mk-EXTRACT_DEPENDS+=	${DEPEND_JAVA}


New patch attached:

+@dirrmtry %%WWWDIR%%
+JAVA_EXTRACT=   yes

Thanks!

14.01.2011 12:08, wen heping пиÑеÑ:
> 2011/1/14 Alex Deiter<alex.deiter@gmail.com>:
>> Hi,
>>
>> 1. No:
>>
>> x4150b# cd /usr/ports/www/bigbluebutton
>> x4150b# grep -A 1 JAR Makefile
>>         @cd ${WRKDIR}/bigbluebutton-tomcat&&  ${JAR} xf \
>>                 ${WRKDIR}/bigbluebutton.war
>
> Here is in the "make extract" phase when diablo-java was not added to
> the system,
> so it will result in build error when build on the tinderbox:
> http://wen.freebsd.your.org/tb/errors/7.3-FreeBSD/bigbluebutton-0.71_1.log
>
> Also it could build on my physical box , better we fix it.
>
> Maybe add a EXTRACT_DEPENDS ?
>
>
> wen
>
>
>
>>
>> war file - http://en.wikipedia.org/wiki/WAR_%28Sun_file_format%29
>>
>> WAR file (or Web application ARchive[1]) is a JAR file used to distribute a
>> collection of JavaServer Pages, servlets, Java classes, XML files, tag
>> libraries and static Web pages (HTML and related files) that together
>> constitute a Web application.
>>
>> 2. I'm sorry. "@dirrmtry %%WWWDIR%%" must be in plist.
>>
>> Thanks a lot!
>>
>> 14.01.2011 09:59, wen heping пиÑеÑ:
>>>
>>> Hi,
>>>
>>>     Two problems:
>>>
>>>      1 s/JAR/TAR/Makefile ?
>>>
>>>      2 why remove "@dirrmtry %%WWWDIR%%" from plist ?
>>> It will result in plist error.
>>>
>>>
>>>
>>> wen
>>
>
>
>
Comment 6 wenheping 2011-01-14 15:50:51 UTC
2011/1/14 Alex Deiter <alex.deiter@gmail.com>:
> Hi,
>
> Thank you for update!
> I found solution:
>
> JAVA_EXTRACT=3D =C2=A0 yes


Good work, now it build well. I shall commit it next Monday.

wen


>
> /usr/ports/Mk/bsd.java.mk:. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if =
defined(JAVA_EXTRACT)
> /usr/ports/Mk/bsd.java.mk-EXTRACT_DEPENDS+=3D =C2=A0 =C2=A0 ${DEPEND_JAVA=
}
>
>
> New patch attached:
>
> +@dirrmtry %%WWWDIR%%
> +JAVA_EXTRACT=3D =C2=A0 yes
>
> Thanks!
>
> 14.01.2011 12:08, wen heping =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>
>> 2011/1/14 Alex Deiter<alex.deiter@gmail.com>:
>>>
>>> Hi,
>>>
>>> 1. No:
>>>
>>> x4150b# cd /usr/ports/www/bigbluebutton
>>> x4150b# grep -A 1 JAR Makefile
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0@cd ${WRKDIR}/bigbluebutton-tomcat&& =C2=A0$=
{JAR} xf \
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${WRKDIR}/bigblu=
ebutton.war
>>
>> Here is in the "make extract" phase when diablo-java was not added to
>> the system,
>> so it will result in build error when build on the tinderbox:
>> http://wen.freebsd.your.org/tb/errors/7.3-FreeBSD/bigbluebutton-0.71_1.l=
og
>>
>> Also it could build on my physical box , better we fix it.
>>
>> Maybe add a EXTRACT_DEPENDS ?
>>
>>
>> wen
>>
>>
>>
>>>
>>> war file - http://en.wikipedia.org/wiki/WAR_%28Sun_file_format%29
>>>
>>> WAR file (or Web application ARchive[1]) is a JAR file used to distribu=
te
>>> a
>>> collection of JavaServer Pages, servlets, Java classes, XML files, tag
>>> libraries and static Web pages (HTML and related files) that together
>>> constitute a Web application.
>>>
>>> 2. I'm sorry. "@dirrmtry %%WWWDIR%%" must be in plist.
>>>
>>> Thanks a lot!
>>>
>>> 14.01.2011 09:59, wen heping =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>>
>>>> Hi,
>>>>
>>>> =C2=A0 =C2=A0Two problems:
>>>>
>>>> =C2=A0 =C2=A0 1 s/JAR/TAR/Makefile ?
>>>>
>>>> =C2=A0 =C2=A0 2 why remove "@dirrmtry %%WWWDIR%%" from plist ?
>>>> It will result in plist error.
>>>>
>>>>
>>>>
>>>> wen
>>>
>>
>>
>>
>
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-01-15 12:11:08 UTC
wen         2011-01-15 12:10:57 UTC

  FreeBSD ports repository

  Modified files:
    www/bigbluebutton    Makefile distinfo 
    www/bigbluebutton/files bbb-conf.in openoffice.in 
                            pkg-message.in 
  Log:
  1. Update Makefile:
  - clean tabs
  - use different master sites URL for different files
  - remove unused options
  - add freeswitch user option
  - bump portrevision
  
  2. Update bbb-conf script:
  - add freeswitch user
  - check installed packages
  - add start / stop options
  - verify host names with getent
  
  3. Update rc script for openoffice:
  - set and use HOME env
  
  4. Update pkg-message:
  - add note about hostname resolution
  - add start note
  
  5. Clean pkg-plist
  
  PR:             ports/153923
  Submitted by:   Alex Deiter <alex.deiter@gmail.com> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.2       +70 -71    ports/www/bigbluebutton/Makefile
  1.2       +8 -8      ports/www/bigbluebutton/distinfo
  1.2       +140 -72   ports/www/bigbluebutton/files/bbb-conf.in
  1.2       +6 -2      ports/www/bigbluebutton/files/openoffice.in
  1.2       +8 -4      ports/www/bigbluebutton/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Wen Heping freebsd_committer freebsd_triage 2011-01-15 12:21:23 UTC
State Changed
From-To: open->closed

Committed. Thanks!