Bug 153965 - [new port] security/rubygem-bcrypt-ruby : Sophisticated and secure hash algorithm for passwords
Summary: [new port] security/rubygem-bcrypt-ruby : Sophisticated and secure hash algor...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ruby (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 01:10 UTC by Jason Helfman
Modified: 2011-01-30 12:10 UTC (History)
0 users

See Also:


Attachments
file.shar (1.77 KB, text/plain)
2011-01-14 01:10 UTC, Jason Helfman
no flags Details
rubygem-bcrypt.shar.txt (1.67 KB, text/plain; charset=us-ascii)
2011-01-14 05:00 UTC, Jason
no flags Details
rubygem-bcrypt.shar.txt (1.72 KB, text/plain; charset=us-ascii)
2011-01-14 06:36 UTC, Jason
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman 2011-01-14 01:10:05 UTC
New port.
Built clean in Tinderbox.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-14 01:10:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ruby

ruby@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Stanislav Sedov freebsd_committer freebsd_triage 2011-01-14 01:28:34 UTC
Hey!

I'm wondering why did you named it rubygem-bcrypt-ruby and not just
rubygem-bcrypt?  For me the -ruby part looks bogus.

-- 
Stanislav Sedov
ST4096-RIPE

()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments
Comment 3 Jason 2011-01-14 01:29:54 UTC
I was going based off of the name of the gem. It is called bcrypt-ruby.
I am fine with a name change, if the port works.

On Thu, Jan 13, 2011 at 05:28:34PM -0800, Stanislav Sedov thus spake:
>Hey!
>
>I'm wondering why did you named it rubygem-bcrypt-ruby and not just
>rubygem-bcrypt?  For me the -ruby part looks bogus.
>
>-- 
>Stanislav Sedov
>ST4096-RIPE
>
>()  ascii ribbon campaign - against html e-mail
>/\  www.asciiribbon.org   - against proprietary attachments
>

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 4 avl 2011-01-14 03:50:58 UTC
Hi!

>RUN_DEPENDS+=   bcrypt:${PORTSDIR}/security/bcrypt

 Is it really needed?

-- 
Best regards,
Alexander
Comment 5 Jason 2011-01-14 05:00:25 UTC
On Fri, Jan 14, 2011 at 11:50:58AM +0800, Alexander Logvinov thus spake:
>Hi!
>
>>RUN_DEPENDS+=   bcrypt:${PORTSDIR}/security/bcrypt
>
> Is it really needed?
>
>-- 
>Best regards,
>Alexander
>
>

After looking this over again, and the dependencies listed on the rubygem
page for the module, it isn't needed. I'm not certain why I thought it was a
requirement. Thanks for pointing this out.

In addition to this, I changed the name of the port directory, as suggested
earlier.

Both of these changes are in the attached shell archive.

Thanks!
-jgh

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 6 Jason 2011-01-14 05:21:16 UTC
The extra line of:

#RUBY_DOCDIR=

can be removed.

-jgh
Comment 7 Jason 2011-01-14 06:00:57 UTC
On Fri, Jan 14, 2011 at 01:50:13PM +0800, Alexander Logvinov thus spake:
>Hi!
>
>On 14.01.2011 13:00 Jason Helfman wrote:
>> In addition to this, I changed the name of the port directory, as suggested
>> earlier.
> You should change the PORTNAME line too. You can take a look on
>net/rubygem-openid.

Changing PORTNAME will break the port.

-jgh
Comment 8 Jason 2011-01-14 06:36:24 UTC
On Fri, Jan 14, 2011 at 02:35:47PM +0800, Alexander Logvinov thus spake:
>On 14.01.2011 14:00 Jason Helfman wrote:
>>> On 14.01.2011 13:00 Jason Helfman wrote:
>>>> In addition to this, I changed the name of the port directory, as
>>>> suggested
>>>> earlier.
>>> You should change the PORTNAME line too. You can take a look on
>>> net/rubygem-openid.
>> Changing PORTNAME will break the port.
> See DISTNAME and GEM_NAME in the net/rubygem-openid/Makefile file.
>Personally I prefer rubygem-bryct-ruby, but it's stas@ choice. :(

I just figured it out, as you mentioned. I saw it in sqlite3.
At first, I was doing that. I didn't change GEM_NAME, though, and it broke.
I see now how having both of them make it work.
Thanks!

After this are you taking it ;)
-jgh

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2011-01-30 12:07:28 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 10 dfilter service freebsd_committer freebsd_triage 2011-01-30 12:08:28 UTC
miwi        2011-01-30 12:08:25 UTC

  FreeBSD ports repository

  Modified files:
    security             Makefile 
  Added files:
    security/rubygem-bcrypt-ruby Makefile distinfo pkg-descr 
  Log:
  bcrypt() is a sophisticated and secure hash algorithm designed by The OpenBSD
  project for hashing passwords. bcrypt-ruby provides a simple, humane wrapper
  for safely handling passwords.
  
  WWW: http://rubygems.org/gems/bcrypt-ruby
  
  PR:             ports/153965
  Submitted by:   Jason Helfman <jhelfman at experts-exchange.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.1151    +1 -0      ports/security/Makefile
  1.1       +21 -0     ports/security/rubygem-bcrypt-ruby/Makefile (new)
  1.1       +2 -0      ports/security/rubygem-bcrypt-ruby/distinfo (new)
  1.1       +5 -0      ports/security/rubygem-bcrypt-ruby/pkg-descr (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"