Bug 154384 - port math/octave-forge, errors in Makefile
Summary: port math/octave-forge, errors in Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-29 21:40 UTC by Eric Dedrick
Modified: 2011-01-31 21:10 UTC (History)
0 users

See Also:

Attachments
ddd (2.21 KB, text/plain)
2011-01-29 22:00 UTC, Stephen Montgomery-Smith 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Dedrick 2011-01-29 21:40:05 UTC 
In the math/octave-forge/Makefile, environment variable names have hyphens.  Shells don't like this.  

Please remove hyphens from variable names in the makefile.

Fix: 

Removing hyphens from variable names in the makefile fixes the problem.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-29 21:40:11 UTC 
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-29 21:40:13 UTC 
Maintainer of math/octave-forge,

Please note that PR ports/154384 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154384

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-01-29 21:40:15 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Stephen Montgomery-Smith 2011-01-29 22:00:52 UTC 
I approve.

And here is a patch.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2011-01-30 20:40:01 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-01-31 21:05:53 UTC 
makc        2011-01-31 21:05:48 UTC

  FreeBSD ports repository

  Modified files:
    math/octave-forge    Makefile 
  Log:
  Don't use hyphens in option names.
  
  PR:             ports/154384
  Reported by:    Eric Dedrick <dedrick+dated+1296768631.1ed402 at euclid.vbnm.net>
  Patched by:     Stephen Montgomery-Smith (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.38      +7 -7      ports/math/octave-forge/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2011-01-31 21:06:00 UTC 
State Changed
From-To: open->closed

Committed. Thanks!