Bug 154662 - [PATCH] www/speedtest-mini: fix "expired version" error message
Summary: [PATCH] www/speedtest-mini: fix "expired version" error message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 21:40 UTC by Artem Naluzhnyy
Modified: 2011-02-17 02:00 UTC (History)
0 users

See Also:


Attachments
file.diff (209 bytes, patch)
2011-02-10 21:40 UTC, Artem Naluzhnyy
no flags Details | Diff
file.diff (437 bytes, patch)
2011-02-10 21:40 UTC, Artem Naluzhnyy
no flags Details | Diff
cvsdiff,speedtest-mini (5.80 KB, text/plain; charset=utf-8)
2011-02-14 10:01 UTC, Po-Chuan Hsieh
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Artem Naluzhnyy 2011-02-10 21:40:12 UTC
Current version from ports shows "expired version" now. The manufacturer has changed the flash binary recently, however distfile name and flash file version are still the same.

The solution is to upgrade the port jut with a new version of distfile.

Fix: PORTNAME=  speedtest-mini
 PORTVERSION= 2.1.5
+PORTREVISION=  1
 CATEGORIES= www
 MASTER_SITES=  http://files.speedtest.ookla.com/releases/
 DISTFILES= mini${EXTRACT_SUFX}
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-10 21:40:16 UTC
Maintainer of www/speedtest-mini,

Please note that PR ports/154662 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154662

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-10 21:40:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-02-11 02:58:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

I will take it.
Comment 4 Grytsuk Anton 2011-02-14 09:09:04 UTC
 I approve! thanks.

> Maintainer of www/speedtest-mini,
>
> Please note that PR ports/154662 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154662
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-02-14 10:01:19 UTC
On Mon, Feb 14, 2011 at 11:09:04AM +0200, Gritsuk Anton wrote:
> 
> I approve! thanks.
> 

Hi Gritsuk,

  Besides the rerolled source, I found something in the Makefile can be
  improved, I've made a patch including the following changes:
  - Use DISTNAME
  - Use WWWDIR instead of SPEEDTEST
  - Provide correct pkg-message for users of non-default PREFIX or WWWDIR
  - Use WWWDIR in pkg-plist (original pkg-plist is not WWWDIR-safe)
  Would you please review and approve the attached patch?
  Thanks.

Regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
	                     http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Comment 6 Grytsuk Anton 2011-02-14 13:43:03 UTC
 Yes, thanks for your improve in Makefile. I've checked your patch, but 
 I see some problem installing speedtest:

 ** Missing /usr/ports/www/speedtest-mini/files/pkg-message.in for 
 speedtest-mini-2.1.5_1.
 *** Error code 1

 plz, fix this and commit these changes.

>   Besides the rerolled source, I found something in the Makefile can 
> be
>   improved, I've made a patch including the following changes:
>   - Use DISTNAME
>   - Use WWWDIR instead of SPEEDTEST
>   - Provide correct pkg-message for users of non-default PREFIX or 
> WWWDIR
>   - Use WWWDIR in pkg-plist (original pkg-plist is not WWWDIR-safe)
>   Would you please review and approve the attached patch?
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-02-14 17:12:17 UTC
On Mon, Feb 14, 2011 at 03:43:03PM +0200, Gritsuk Anton wrote:
> Yes, thanks for your improve in Makefile. I've checked your patch,
> but I see some problem installing speedtest:
> 
> ** Missing /usr/ports/www/speedtest-mini/files/pkg-message.in for
> speedtest-mini-2.1.5_1.
> *** Error code 1
> 
> plz, fix this and commit these changes.
> 
> >  Besides the rerolled source, I found something in the Makefile
> >can be
> >  improved, I've made a patch including the following changes:
> >  - Use DISTNAME
> >  - Use WWWDIR instead of SPEEDTEST
> >  - Provide correct pkg-message for users of non-default PREFIX or
> >WWWDIR
> >  - Use WWWDIR in pkg-plist (original pkg-plist is not WWWDIR-safe)
> >  Would you please review and approve the attached patch?
> 

Hi,

The files/pkg-message.in is at the end of patch. Due to the absense of
files/ directory before applying patch, it might be created as
pkg-message.in, not files/pkg-message.in. If so, please manually create
files/ directory and move the file. Thanks.

Regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
	                     http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Comment 8 Grytsuk Anton 2011-02-14 17:23:25 UTC
>> Yes, thanks for your improve in Makefile. I've checked your patch,
>> but I see some problem installing speedtest:
>>
>> ** Missing /usr/ports/www/speedtest-mini/files/pkg-message.in for
>> speedtest-mini-2.1.5_1.
>> *** Error code 1
>>
>> plz, fix this and commit these changes.
>>
>> >  Besides the rerolled source, I found something in the Makefile
>> >can be
>> >  improved, I've made a patch including the following changes:
>> >  - Use DISTNAME
>> >  - Use WWWDIR instead of SPEEDTEST
>> >  - Provide correct pkg-message for users of non-default PREFIX or
>> >WWWDIR
>> >  - Use WWWDIR in pkg-plist (original pkg-plist is not WWWDIR-safe)
>> >  Would you please review and approve the attached patch?
>
> The files/pkg-message.in is at the end of patch. Due to the absense 
> of
> files/ directory before applying patch, it might be created as
> pkg-message.in, not files/pkg-message.in. If so, please manually 
> create
> files/ directory and move the file. Thanks.
>
> Regards,

 HI!
 yes, if I do in directory port this instruction:
  # mkdir files && mv pkg-message.in files/

 it's works!
Comment 9 dfilter service freebsd_committer freebsd_triage 2011-02-17 01:59:27 UTC
sunpoet     2011-02-17 01:59:24 UTC

  FreeBSD ports repository

  Modified files:
    www/speedtest-mini   Makefile distinfo pkg-plist 
  Added files:
    www/speedtest-mini/files pkg-message.in 
  Removed files:
    www/speedtest-mini   pkg-message 
  Log:
  - Update distinfo
  - Use DISTNAME
  - Use WWWDIR instead of SPEEDTEST
  - Provide correct pkg-message for users of non-default PREFIX or WWWDIR
  - Use WWWDIR in pkg-plist (original pkg-plist is not WWWDIR-safe)
  
  PR:             ports/154662 [1]
  Submitted by:   Artem Naluzhnyy <Artem.Naluzhnyy@gmail.com> [1]
                  sunpoet (myself)
  Approved by:    Gritsuk Anton <gx@bsdplanet.ru> (maintainer)
  
  Revision  Changes    Path
  1.2       +12 -12    ports/www/speedtest-mini/Makefile
  1.2       +2 -3      ports/www/speedtest-mini/distinfo
  1.1       +21 -0     ports/www/speedtest-mini/files/pkg-message.in (new)
  1.2       +0 -21     ports/www/speedtest-mini/pkg-message (dead)
  1.2       +25 -30    ports/www/speedtest-mini/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-02-17 02:00:20 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!