Bug 154677 - [patch] net/unison: add LICENCE and a desktop entry
Summary: [patch] net/unison: add LICENCE and a desktop entry
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-11 10:40 UTC by Boris Samorodov
Modified: 2011-02-11 15:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2011-02-11 10:40:10 UTC

Fix: . add LICENCE (GPLv3);
	. add a desktop entry;
	. bump PORTREVISION.



-- 
WBR, bsam--0gCr2e52RYe7rg6FdkZze8eu1RZBkkci4rvjMfz7LCqK8M0W
Content-Type: text/plain; name="unison.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="unison.diff"

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/unison/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile	11 Feb 2011 08:52:17 -0000	1.28
+++ Makefile	11 Feb 2011 10:15:08 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	unison
 PORTVERSION=	2.32.52
+PORTREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	http://www.cis.upenn.edu/~bcpierce/unison/download/releases/${DISTNAME}/
 DISTFILES=	${EXTRACT_ONLY} ${EXTRA_DOCS}
@@ -18,11 +19,14 @@
 
 PLIST_SUB=	PORTVERSION=${PORTVERSION}
 USE_GMAKE=	yes
+WANT_GNOME=	yes
 MAKE_ARGS=	CFLAGS=""
 CONFLICTS=	unison-devel-[0-9]* unison-nox11-[0-9]*
 
 MAKE_JOBS_UNSAFE=	yes
 
+LICENCE=	GPLv3
+
 .include <bsd.port.pre.mk>
 
 .if !defined(NOPORTDOCS)
@@ -43,6 +47,8 @@
 RUN_DEPENDS+=	lablgtk2:${PORTSDIR}/x11-toolkits/ocaml-lablgtk2
 PATCH_DEPENDS+=	${BUILD_DEPENDS}
 CONFLICTS+=	ocaml-nox11*
+USE_GNOME=	desktopfileutils
+SUB_FILES+=	${PORTNAME}.desktop
 .else
 MAKE_ARGS+=	UISTYLE=text
 PLIST_SUB+=	TEXT="@comment "
@@ -68,6 +74,8 @@
 .endif
 .if defined(WITH_GTK2)
 	@${INSTALL_PROGRAM} ${WRKSRC}/unison-text ${PREFIX}/bin
+	@${INSTALL_DATA} ${WRKDIR}/${PORTNAME}.desktop ${DESKTOPDIR}
+	@-update-desktop-database > /dev/null
 	@${CAT} ${PKGMESSAGE}
 .else
 	@${CAT} ${PKGMESSAGE}.nox11
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/net/unison/pkg-plist,v
retrieving revision 1.3
diff -u -r1.3 pkg-plist
--- pkg-plist	26 Jan 2005 17:31:57 -0000	1.3
+++ pkg-plist	11 Feb 2011 10:15:08 -0000
@@ -1,4 +1,5 @@
 bin/unison
+%%TEXT%%share/applications/unison.desktop
 %%TEXT%%bin/unison-text
 %%PORTDOCS%%%%DOCSDIR%%/BUGS.txt
 %%PORTDOCS%%%%DOCSDIR%%/NEWS
@@ -7,3 +8,6 @@
 %%PORTDOCS%%%%DOCSDIR%%/unison-%%PORTVERSION%%-manual.pdf
 %%PORTDOCS%%%%DOCSDIR%%/unison-%%PORTVERSION%%-manual.ps
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
+%%TEXT%%@dirrmtry share/applications
+%%TEXT%%@exec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || :
+%%TEXT%%@unexec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || :
Index: files/unison.desktop.in
===================================================================
RCS file: files/unison.desktop.in
diff -N files/unison.desktop.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/unison.desktop.in	11 Feb 2011 10:15:08 -0000
@@ -0,0 +1,11 @@
+[Desktop Entry]
+Encoding=UTF-8
+Name=Unison
+GenericName=File-synchronization tool
+Type=Application
+Terminal=false
+StartupNotify=true
+Categories=GTK;Utility;
+Exec=unison
+Comment=Synchronize files (directories) over different disks (hosts)
+Comment[ru]=СинÑÑонизаÑÐ¸Ñ Ñайлов (каÑалогов) на неÑколÑÐºÐ¸Ñ Ð´Ð¸ÑÐºÐ°Ñ (компÑÑÑеÑаÑ)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 10:40:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bsam

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 10:40:18 UTC
Maintainer of net/unison,

Please note that PR ports/154677 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154677

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-11 10:40:20 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Dan Pelleg 2011-02-11 12:24:33 UTC
Approved.

Also note that I'm transferring maintenance of unison and unison-devel to Guido Falsi
<mad@madpilot.net>.

-- 
  Dan
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-02-11 14:48:49 UTC
bsam        2011-02-11 14:48:44 UTC

  FreeBSD ports repository

  Modified files:
    net/unison           Makefile pkg-plist 
  Added files:
    net/unison/files     unison.desktop.in 
  Log:
  . add LICENCE (GPLv3);  [1]
  . add a desktop entry;  [1]
  . bump PORTREVISION;  [1]
  . transfer mainainership to a new person.
  
  PR:             ports/154677  [1]
  Submitted by:   bsam (me)  [1]
  Approved by:    Dan Pelleg <daniel+unison at pelleg.org> (maintainer)
  
  Revision  Changes    Path
  1.29      +9 -1      ports/net/unison/Makefile
  1.1       +11 -0     ports/net/unison/files/unison.desktop.in (new)
  1.4       +4 -0      ports/net/unison/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-02-11 14:52:45 UTC
bsam        2011-02-11 14:52:40 UTC

  FreeBSD ports repository

  Modified files:
    net/unison-devel     Makefile 
  Log:
  Transfer maintenance to a new person.
  
  PR:             ports/154677
  Submitted by:   bsam (me)
  Approved by:    Dan Pelleg <daniel+unison at pelleg.org> (maintainer)
  
  Revision  Changes    Path
  1.28      +1 -1      ports/net/unison-devel/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Boris Samorodov freebsd_committer freebsd_triage 2011-02-11 14:54:33 UTC
State Changed
From-To: feedback->closed

Committed, thanks! 
And big THANK YOU to Dan for creating and maintaining the port for 
more then 10 years! Thanks, have fun and be happy... ;-)