Bug 154973 - [PATCH] security/ike: fix plist when QTGUI=off, respect PREFIX and LOCALBASE
Summary: [PATCH] security/ike: fix plist when QTGUI=off, respect PREFIX and LOCALBASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-23 15:20 UTC by Yuri Pankov
Modified: 2011-10-16 12:10 UTC (History)
1 user (show)

See Also:

Attachments
ike-2.1.7.patch (3.22 KB, patch)
2011-02-23 15:20 UTC, Yuri Pankov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Pankov 2011-02-23 15:20:11 UTC 
- Fix plist when QTGUI is not selected
- Respect PREFIX and LOCALBASE
- Silence portlint (whitespaces...)
- Remove MD5

Added file(s):
- files/patch-CMakeLists.txt

Port maintainer (mgrooms@shrew.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-23 15:20:21 UTC 
Maintainer of security/ike,

Please note that PR ports/154973 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/154973

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-02-23 15:20:23 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 mgrooms 2011-03-01 23:01:01 UTC 
Thanks for submitting the patch. Comments inline ...

> - Fix plist when QTGUI is not selected

Great. I hadn't thought about the plist issue.

> - Respect PREFIX and LOCALBASE

I'm not sure why this is necessary. If so, can CMAKE_INSTALL_PREFIX = 
PREFIX so CMakeList.txt doesn't require patching?

> - Silence portlint (whitespaces...)
> - Remove MD5
>

The rest looks fine.

-Matthew
Comment 4 Pawel Pekala 2011-10-01 15:12:55 UTC 
>I'm not sure why this is necessary. If so, can CMAKE_INSTALL_PREFIX =3D=20
>PREFIX so CMakeList.txt doesn't require patching?

/usr/ports/Mk/bsd.cmake.mk does this already. IMHO CMakList.txt of this
port is wrong, it first checks for existence of target directories
(NOT EXISTS parts) and then sets prefixes based on that. In
configuration phase those directories may or may not exist, in most
cases they are created at install phase.

In short, I think this patch is good as it is and I want to commit it
if maintainer approves ?

--=20
pozdrawiam / with regards
Pawe=B3 P=EAkala
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2011-10-01 15:13:35 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-10-16 12:07:38 UTC 
pawel       2011-10-16 11:07:29 UTC

  FreeBSD ports repository

  Modified files:
    security/ike         Makefile pkg-plist 
  Added files:
    security/ike/files   patch-CMakeLists.txt 
  Log:
  - Fix plist when WITHOUT_QTGUI=yes
  - Make install PREFIX safe
  
  PR:             ports/154973
  Submitted by:   Yuri Pankov <yuri.pankov@gmail.com>
  Approved by:    maintainer timeout (2 weeks)
  
  Revision  Changes    Path
  1.13      +16 -5     ports/security/ike/Makefile
  1.1       +23 -0     ports/security/ike/files/patch-CMakeLists.txt (new)
  1.7       +2 -2      ports/security/ike/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Pawel Pekala freebsd_committer freebsd_triage 2011-10-16 12:07:48 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!