The FTP site doesn't work, so update to the HTTP site per author's web page. Add the ability to verfiy the PGP signature of the distfile Fix: Apply the following patch: How-To-Repeat: Try to fetch the distfile via FTP
Responsible Changed From-To: freebsd-ports-bugs->dougb Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of games/cowsay, Please note that PR ports/155138 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155138 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
On 2/28/2011 5:50 PM, Edwin Groothuis wrote: > Maintainer of games/cowsay, > > Please note that PR ports/155138 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155138 >
Hello, Looking at this I am not happy with this, I will redo said patch.
On 3/2/2011 9:37 AM, Chris Petrik wrote: > On 3/1/2011 12:59 AM, Chris Petrik wrote: >> On 3/1/2011 12:03 AM, Doug Barton wrote: >>> Sorry, no message came through. Do you approve the updates? :) >>> >>> Doug >>> >>> >>> On 2/28/2011 6:00 PM, Chris Petrik wrote: >>>> The following reply was made to PR ports/155138; it has been noted >>>> by GNATS. >>>> >>>> From: Chris Petrik<chris@cpetservices.com> >>>> To: bug-followup@FreeBSD.org >>>> Cc: >>>> Subject: Re: ports/155138: Update MASTER_SITES for games/cowsay, >>>> add PGP verify >>>> target >>>> Date: Mon, 28 Feb 2011 19:58:32 -0600 >>>> >>>> On 2/28/2011 5:50 PM, Edwin Groothuis wrote: >>>> > Maintainer of games/cowsay, >>>> > >>>> > Please note that PR ports/155138 has just been submitted. >>>> > >>>> > If it contains a patch for an upgrade, an enhancement or a bug fix >>>> > you agree on, reply to this email stating that you approve the >>>> patch >>>> > and a committer will take care of it. >>>> > >>>> > The full text of the PR can be found at: >>>> > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155138 >>>> > >>>> >>>> >>> >>> >>> >>> >> Exactly, i meant yes it fine it's always fine. > Hello, > > Looking at this I am not happy with this, I will redo said patch. The PGP key is invalid gpg: Can't check signature: no public key editing the file in vim just shows random chars ?
new patch.
Doug, I've taken over maintainer for this port since Chris decided to give it up. I took a look at this PR and like the idea (I do the same thing with devel/git), however there are a couple of issues with your approach. Chris' last patch is closer to what I think should be done but it still needs a couple of minor touch-ups. Specifically, the DISTFILES line in the first block is not needed and the FETCH_DEPENDS line is also not needed. I do, however, like the idea of putting the verify target behind a MAINTAINER_MODE check to make it clear that it is to be used by the maintainer. Even if all of those things are cleared up there is still the problem that the signature file is not a valid signature file. I will be committing the MASTER_SITES update soon but want to leave the other parts up to you. If you think it's still a good idea to verify the file we will have to figure out what's up with the signature. -- WXS
wxs 2011-03-03 14:56:12 UTC FreeBSD ports repository Modified files: games/cowsay Makefile Log: Update MASTER_SITES. PR: ports/155138 (partially) Submitted by: dougb@ Revision Changes Path 1.11 +1 -1 ports/games/cowsay/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
wxs 2011-03-04 20:36:32 UTC FreeBSD ports repository Modified files: games/cowsay Makefile distinfo Log: Add a verify target. PR: ports/155138 Submitted by: dougb@ Revision Changes Path 1.12 +9 -0 ports/games/cowsay/Makefile 1.5 +2 -0 ports/games/cowsay/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!