Bug 155324 - [PATCH] audio/mumble: update to 1.2.3
Summary: [PATCH] audio/mumble: update to 1.2.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-06 21:40 UTC by Mark Felder
Modified: 2011-03-13 15:00 UTC (History)
1 user (show)

See Also:


Attachments
mumble-1.2.3.patch (8.41 KB, patch)
2011-03-06 21:40 UTC, Mark Felder
no flags Details | Diff
mumble-1.2.3_r2.patch (8.36 KB, patch)
2011-03-06 21:54 UTC, Mark Felder
no flags Details | Diff
mumble-1.2.3-r3.patch (8.46 KB, patch)
2011-03-09 01:29 UTC, Mark Felder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Felder freebsd_committer freebsd_triage 2011-03-06 21:40:12 UTC
- Update to 1.2.3
Also adds knob that needs to be enabled if you want to build against a system-wide CELT
instead of using the built-in one.

Thanks fwaggle!

Added file(s):
- files/patch-overlay_gl-overlay.c

Removed file(s):
- files/patch-main.pro

Port maintainer (marius@nuenneri.ch) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-06 21:40:25 UTC
Maintainer of audio/mumble,

Please note that PR ports/155324 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155324

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-06 21:40:27 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Mark Felder freebsd_committer freebsd_triage 2011-03-06 21:54:21 UTC
Cleaned up a stale comment and no-overlay was enabled by default from  
previous testing.
Comment 4 marius 2011-03-07 14:14:44 UTC
Hi,

I can't apply the second patch, any hints?

marius@sol:~/mumble% patch < mumble-1.2.3_r2.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff -ruN --exclude=3DCVS /usr/ports/audio/mumble/Makefile
/tmp/audio/mumble/Makefile
|--- /usr/ports/audio/mumble/Makefile	2010-12-02 14:00:37.000000000 -0600
|+++ /tmp/audio/mumble/Makefile	2011-03-06 15:26:35.000000000 -0600
--------------------------
Patching file Makefile using Plan A...
Hunk #1 succeeded at 6.
patch: **** malformed patch at line 26: @@ -31,12 +30,13 @@


On Sun, Mar 6, 2011 at 22:40, Edwin Groothuis <edwin@freebsd.org> wrote:
> Maintainer of audio/mumble,
>
> Please note that PR ports/155324 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> =C2=A0 =C2=A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/155324
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 5 Mark Felder freebsd_committer freebsd_triage 2011-03-09 01:29:21 UTC
Sorry about the delay,

I seemed to have been incorrectly creating patches in the past which I  
discovered during this round's Q&A. I've tested this patch myself on a  
clean pull and see no issues.


Regards,


Mark
Comment 6 Mark Linimon 2011-03-10 22:53:24 UTC
----- Forwarded message from Marius Nünnerich <marius@nuenneri.ch> -----

Date: Thu, 10 Mar 2011 23:25:13 +0100
From: Marius Nünnerich <marius@nuenneri.ch>
To: Mark Felder <feld@feld.me>
Subject: Re: ports/155324: [PATCH] audio/mumble: update to 1.2.3

I approve the third patch. Mark sent it to me via private mail as I
couldn't download it from GNATS webinterface.
_______________________________________________
freebsd-ports-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"


----- End forwarded message -----
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2011-03-10 22:53:34 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 8 Max Brazhnikov freebsd_committer freebsd_triage 2011-03-12 15:29:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 9 dfilter service freebsd_committer freebsd_triage 2011-03-13 14:56:03 UTC
makc        2011-03-13 14:55:51 UTC

  FreeBSD ports repository

  Modified files:
    audio/mumble         Makefile distinfo pkg-plist 
    audio/mumble/files   patch-compiler.pri 
                         patch-src-mumble-Audio.cpp 
                         patch-src-mumble11x-mumble11x.pro 
  Added files:
    audio/mumble/files   patch-overlay_gl-overlay.c 
  Removed files:
    audio/mumble/files   patch-main.pro 
  Log:
  - Update to 1.2.3
  - Add option to build against a system-wide CELT instead of using
    the built-in one.
  
  PR:             ports/155324
  Submitted by:   Mark Felder <feld at feld.me>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.13      +20 -4     ports/audio/mumble/Makefile
  1.4       +2 -3      ports/audio/mumble/distinfo
  1.2       +3 -3      ports/audio/mumble/files/patch-compiler.pri
  1.2       +0 -13     ports/audio/mumble/files/patch-main.pro (dead)
  1.1       +10 -0     ports/audio/mumble/files/patch-overlay_gl-overlay.c (new)
  1.2       +19 -17    ports/audio/mumble/files/patch-src-mumble-Audio.cpp
  1.2       +8 -7      ports/audio/mumble/files/patch-src-mumble11x-mumble11x.pro
  1.5       +2 -0      ports/audio/mumble/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Max Brazhnikov freebsd_committer freebsd_triage 2011-03-13 14:59:20 UTC
State Changed
From-To: open->closed

Committed. Thanks!