Bug 155526 - [PATCH] devel/py-elementtree: ignore if python >= 2.5
Summary: [PATCH] devel/py-elementtree: ignore if python >= 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-python (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-13 13:20 UTC by R.Mahmatkhanov
Modified: 2013-09-23 11:50 UTC (History)
0 users

See Also:


Attachments
file.diff (884 bytes, patch)
2011-03-13 13:20 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-03-13 13:20:11 UTC
- set IGNORE if python version is >= 2.5, because ElementTree is a part of standard library since 2.5:
http://docs.python.org/library/xml.etree.elementtree.html
http://effbot.org/zone/elementtree.html
- remove MD5

Dunno maybe we should delete this port at all, since we dropping support of 24 in the tree.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-13 13:20:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2011-03-13 13:26:29 UTC
State Changed
From-To: open->closed

python24 goes to the end of month, this port is on the todo for removal. 
thx.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2011-06-24 14:32:40 UTC
State Changed
From-To: closed->open

Re-open, python24 failed to disappear
Comment 4 Marcus von Appen freebsd_committer freebsd_triage 2012-06-07 16:39:32 UTC
As long as www/py-Products.TinyMCE depends on it, there is no way to
delete it (without fixing www/py-Products.TinyMCE beforehand for python
>= 2.5).

Also, as it does not do any harm (no package name confusion with
xml.etree.elementTree and _elementtree), it is not really necessary to
force the deletion of it.

Cheers
Marcus
Comment 5 R.Mahmatkhanov 2012-06-07 17:13:42 UTC
Marcus von Appen wrote on 07.06.2012 19:39:
> As long as www/py-Products.TinyMCE depends on it, there is no way to
> delete it (without fixing www/py-Products.TinyMCE beforehand for python
>> = 2.5).
>
> Also, as it does not do any harm (no package name confusion with
> xml.etree.elementTree and _elementtree), it is not really necessary to
> force the deletion of it.
>
> Cheers
> Marcus

Yes, but why do we need to hold the ports, that nobody using and will 
not be anyway? All the ports I saw, that uses elementTree, first 
checking if they can import xml.etree and if they not, then they will 
try to fallback to standalone _elementtree. And since python24/25 will 
be removed soon, there is no sense to hold them.

The only difference between them is HTMLTreeBuilder class that is 
missing in xml.etree (and that py-Products.TinyMCE is using), so 
py-elementtree should stay until Products.TinyMCE will be ported to 
py-lxml, and py-celementtree is safe to remove (because nobody using 
it). This ports/155526 should be closed too, because it's now impossible 
to remove this port.

PS. The same belongs to simplejson/json case. Most ports try to use 
bundled json module first, and try to import simplejson if they fail 
(python<2.6). But there is couple of ports that need exactly simplejson 
implementation.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 6 Marcus von Appen freebsd_committer freebsd_triage 2012-06-07 18:11:50 UTC
On, Thu Jun 07, 2012, Ruslan Mahmatkhanov wrote:

> The following reply was made to PR ports/155526; it has been noted by GNATS.
>
> From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
> To: Marcus von Appen <mva@FreeBSD.org>
> Cc: bug-followup@FreeBSD.org
> Subject: Re: ports/155526: [PATCH] devel/py-elementtree: ignore if python
>  >= 2.5
> Date: Thu, 07 Jun 2012 20:13:42 +0400
>
>  Marcus von Appen wrote on 07.06.2012 19:39:
>  > As long as www/py-Products.TinyMCE depends on it, there is no way to
>  > delete it (without fixing www/py-Products.TinyMCE beforehand for python
>  >> = 2.5).
>  >
>  > Also, as it does not do any harm (no package name confusion with
>  > xml.etree.elementTree and _elementtree), it is not really necessary to
>  > force the deletion of it.
>  >
>  > Cheers
>  > Marcus
>
>  Yes, but why do we need to hold the ports, that nobody using and will
>  not be anyway? All the ports I saw, that uses elementTree, first
>  checking if they can import xml.etree and if they not, then they will
>  try to fallback to standalone _elementtree. And since python24/25 will
>  be removed soon, there is no sense to hold them.

Right, but there is no need to rush things, either, at least not as long
as the port above has a dependency on it.

>  The only difference between them is HTMLTreeBuilder class that is
>  missing in xml.etree (and that py-Products.TinyMCE is using), so
>  py-elementtree should stay until Products.TinyMCE will be ported to
>  py-lxml, and py-celementtree is safe to remove (because nobody using
>  it). This ports/155526 should be closed too, because it's now impossible
>  to remove this port.

I'd rather vote for keeping it open until www/py-Products.TinyMCE has
been updated properly and lang/python24 was removed, so we do not forget
about deprecating and removing devel/py-elementtree later on.

Cheers
Marcus
Comment 7 dfilter service freebsd_committer freebsd_triage 2013-09-23 11:41:09 UTC
Author: rm
Date: Mon Sep 23 10:41:01 2013
New Revision: 327969
URL: http://svnweb.freebsd.org/changeset/ports/327969

Log:
  Remove since ElementTree is a part of standard library since Python 2.5.
  Last consumer of it gone today.
  
  PR:		155526
  Submitted by:	rm (myself)

Deleted:
  head/devel/py-elementtree/
Modified:
  head/MOVED
  head/devel/Makefile

Modified: head/MOVED
==============================================================================
--- head/MOVED	Mon Sep 23 10:23:35 2013	(r327968)
+++ head/MOVED	Mon Sep 23 10:41:01 2013	(r327969)
@@ -4947,3 +4947,4 @@ devel/ptlib26|devel/ptlib|2013-09-20|Rem
 net/opal3|net/opal|2013-09-20|Removed old version, update to new version and moved port
 net/ekiga|net-im/ekiga|2013-09-20|Removed old version, update to new version and moved port
 net/ekiga3|net-im/ekiga|2013-09-20|Removed old version, update to new version and moved port
+devel/py-elementtree||2013-09-23|ElementTree is a part of standard library since Python 2.5

Modified: head/devel/Makefile
==============================================================================
--- head/devel/Makefile	Mon Sep 23 10:23:35 2013	(r327968)
+++ head/devel/Makefile	Mon Sep 23 10:41:01 2013	(r327969)
@@ -3523,7 +3523,6 @@
     SUBDIR += py-durus
     SUBDIR += py-dynrules
     SUBDIR += py-eggtestinfo
-    SUBDIR += py-elementtree
     SUBDIR += py-epsilon
     SUBDIR += py-event
     SUBDIR += py-experimental.cssselect
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 8 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2013-09-23 11:45:13 UTC
State Changed
From-To: open->closed

Port removed.