155788 – ports security/cfsd startup -- multiple problems

no flags

The cfsd port's startup file: /usr/local/etc/rc.d/cfsd has two
problems:

     -- [Serious] The mount command defaults to tcp mounts and tests
        ipv6 even though the cfs daemon only listens on ipv4 and udp.

     -- [Somewhat serious] It's missing the '# KEYWORD: shutdown'
        which causes it to generate a spurious error at startup time.

     -- [Minor] The startup script should allow the user to control
        the location of the cfsd-bootstrap directory.

Fix: The following patch set addresses all three issues.

Diff finished.  Tue Mar 22 12:52:12 2011

Diff finished.  Tue Mar 22 12:41:35 2011--686B9wBpDFG7QOhoHlP1FpegfEceQfgvpIcbRMMb71mtM6l9
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

diff -c /usr/ports/security/cfs/files/cfsd.sh.in.orig /usr/ports/security/cfs/files/cfsd.sh.in
*** /usr/ports/security/cfs/files/cfsd.sh.in.orig	Fri Mar 26 20:14:40 2010
--- /usr/ports/security/cfs/files/cfsd.sh.in	Tue Mar 22 12:47:59 2011
***************
*** 5,10 ****
--- 5,11 ----

  # PROVIDE: cfsd
  # REQUIRE: mountd
+ # KEYWORD: shutdown

  #
  # Add the following line to /etc/rc.conf to enable cfsd:
***************
*** 15,20 ****
--- 16,22 ----
  #
  # cfsd_port="3049"		# the port to listen to
  # cfsd_mountpoint="/crypt"	# the CFS mountpoint
+ # cfsd_bootstrap="%%CFSD_BOOTSTRAP%%"
  #

  . /etc/rc.subr
***************
*** 29,35 ****
  cfsd_poststart()
  {
  	if [ -n "$cfsd_mountpoint" ]; then
! 		mount -o port="$cfsd_port",nfsv2 localhost:%%CFSD_BOOTSTRAP%% "$cfsd_mountpoint"
  	fi
  }

--- 31,37 ----
  cfsd_poststart()
  {
  	if [ -n "$cfsd_mountpoint" ]; then
! 		mount -o port="$cfsd_port",nfsv2,udp "127.0.0.1:$cfsd_bootstrap" "$cfsd_mountpoint"
  	fi
  }

***************
*** 44,51 ****
  : ${cfsd_enable="NO"}
  : ${cfsd_port="3049"}
  : ${cfsd_mountpoint="/crypt"}

  command_args="$cfsd_port >/dev/null 2>&1"
! required_dirs="%%CFSD_BOOTSTRAP%% $cfsd_mountpoint"

  run_rc_command "$1"
--- 46,54 ----
  : ${cfsd_enable="NO"}
  : ${cfsd_port="3049"}
  : ${cfsd_mountpoint="/crypt"}
+ : ${cfsd_bootstrap="%%CFSD_BOOTSTRAP%%"}

  command_args="$cfsd_port >/dev/null 2>&1"
! required_dirs="$cfsd_bootstrap $cfsd_mountpoint"

  run_rc_command "$1"
How-To-Repeat: 
Install the port, follow the "pkg_info -D -x cfsd" instructions and
try to start the daemon.