Bug 156302 - devel/subversion fails to build with KDE_KWALLET and KDE3 installed
Summary: devel/subversion fails to build with KDE_KWALLET and KDE3 installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alberto Villa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-10 03:10 UTC by Axel Gonzalez
Modified: 2011-04-11 01:10 UTC (History)
0 users

See Also:


Attachments
file.diff (638 bytes, patch)
2011-04-10 03:10 UTC, Axel Gonzalez
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Gonzalez 2011-04-10 03:10:09 UTC

===>  Extracting for subversion-1.6.16_1
...
...
checking for kde4-config... yes
checking for KWallet... no
configure: error: cannot find KWallet


The problem is subversion tries to use the kde3 libs.

Fix: This patches change the order of the search for libraries, so it looks first for kde4

The first is a patch to the current patch (patch-configure)
The second is a new patch (patch-Makefile_in)


----------------

diff patch-configure files/patch-configure

31a45,57
> @@ -22490,10 +22490,10 @@
>                    SVN_KWALLET_INCLUDES="$DBUS_CPPFLAGS $qt_include_dirs -I$kde_dir/include"
>                    qt_libs_other_options="`$PKG_CONFIG --libs-only-other QtCore QtDBus QtGui`"
>                    SVN_KWALLET_LIBS="$DBUS_LIBS -lQtCore -lQtDBus -lQtGui -lkdecore -lkdeui $qt_libs_other_options"
> -                  CXXFLAGS="$CXXFLAGS $SVN_KWALLET_INCLUDES"
> +                  CXXFLAGS="$SVN_KWALLET_INCLUDES $CXXFLAGS"
>                    LIBS="$LIBS $SVN_KWALLET_LIBS"
>                    qt_lib_dirs="`$PKG_CONFIG --libs-only-L QtCore QtDBus QtGui`"
> -                  LDFLAGS="$old_LDFLAGS $qt_lib_dirs -L$kde_dir/lib`$kde4_config --libsuffix`"
> +                  LDFLAGS="$qt_lib_dirs -L$kde_dir/lib`$kde4_config --libsuffix` $old_LDFLAGS"
>                    ac_ext=cpp
>  ac_cpp='$CXXCPP $CPPFLAGS'
>  ac_compile='$CXX -c $CXXFLAGS $CPPFLAGS conftest.$ac_ext >&5'



-------------------

# cat files/patch-Makefile_in


How-To-Repeat: Install kde3
Select KDE_KWALLET from subversion
Build
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-10 03:10:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lev

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-04-11 01:04:21 UTC
avilla      2011-04-11 00:04:08 UTC

  FreeBSD ports repository

  Modified files:
    devel/subversion     Makefile.common 
    devel/subversion/files patch-configure 
    devel/subversion-freebsd Makefile 
  Added files:
    devel/subversion/files patch-Makefile.in 
  Log:
  - Add dependency on kdebase4-runtime when KWallet support is built.
  - Fix build with KDE_WALLET when KDE 3 is installed. [1]
  - Bump PORTREVISION.
  
  This completes my previous commit and fixes KDE_WALLET option.
  
  PR:             156302 [1]
  Submitted by:   Axel Gonzalez <loox@e-shell.net> [1]
  Approved by:    lev (maintainer, implicit)
  
  Revision  Changes    Path
  1.142     +1 -1      ports/devel/subversion-freebsd/Makefile
  1.44      +3 -3      ports/devel/subversion/Makefile.common
  1.1       +13 -0     ports/devel/subversion/files/patch-Makefile.in (new)
  1.19      +15 -2     ports/devel/subversion/files/patch-configure
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alberto Villa freebsd_committer freebsd_triage 2011-04-11 01:06:15 UTC
Responsible Changed
From-To: lev->avilla

i'll take it as it refers to the kwallet support i committed recently
Comment 4 Alberto Villa freebsd_committer freebsd_triage 2011-04-11 01:06:37 UTC
State Changed
From-To: open->closed

Committed. Thanks!