Update for math/octave Fix: Notice that several files get removed.
Responsible Changed From-To: freebsd-ports-bugs->maho Over to maintainer (via the GNATS Auto Assign Tool)
Dear Maho, I submitted an update to octave-3.4.0. But there is no hurry. In particular, I found that some old octave-forge packages will no longer build, and I will probably have to mark them BROKEN. I removed a lot of your post-install code. To be honest, I didn't understand most of it. I reverted to the old fashioned pkg-plist format which simply lists all of the files and directories installed. The only part of "post-install" I kept was installation of DOCS. I also removed the "TERMIOS_H" line in the Makefile. There was no reference to this in the source code (although there were many references to "HAVE_TERMIOS_H"). I am guessing you were fixing a problem that is now fixed in the octave build process. I added a DEPENDS to texinfo, because octave needs a more up to date version of makeinfo than FreeBSD-8 currently has. This is both a BUILD_DEPENDS and a RUN_DEPENDS, because the scripts that install the octave-forge ports also need it. (See the post-patch code I added.) I removed patches in "files" that (a) no longer applied and (b) which I didn't understand. I hope this isn't a problem. I also removed "octave.in" because that also no longer seemed necessary. Stephen
I looked over this PR. I realized I made several mistakes. I'll try to work on getting it right. I don't know how long that will take. If you want to close this PR in the meantime, I won't mind. Otherwise I'll send a better diff in a while. Sorry. Stephen
Here is a much better diff file. Please use this instead of the prior diff file. Note that four files are now removed. Only in /usr/ports/math/octave/files: octave.in Only in /usr/ports/math/octave/files: patch-configure.in Only in /usr/ports/math/octave/files: patch-examples+Makefile.in Only in /usr/ports/math/octave/files: patch-mkoctfile.in Next, I have now followed Maho's original code in post-install that automatically creates most of PLIST. I also added some code that creates the appropriate mkdir's for the empty directories, so these are no longer listed explicitly in pkg-plist. I also now understand why you have this in your Makefile: ${INSTALL_DATA} ${WRKSRC}/examples/octave.desktop ${DESKTOPDIR}/www.octave.org-octave.desktop A lot of the other stuff you had in post-install is no longer required, because the makers of octave must have fixed a lot of problems with the install process.
maho 2011-05-10 08:28:35 UTC FreeBSD ports repository Modified files: math/octave Makefile distinfo pkg-plist math/octave/files patch-libcruft+mkf77def.in patch-scripts+pkg+pkg.m Removed files: math/octave/files octave.in patch-configure.in patch-examples+Makefile.in Log: update to 3.4.0 PR: 156603 Submitted by: Stephen Montgomery-Smith <stephen@missouri.edu> Revision Changes Path 1.123 +27 -26 ports/math/octave/Makefile 1.32 +2 -2 ports/math/octave/distinfo 1.4 +0 -8 ports/math/octave/files/octave.in (dead) 1.5 +0 -24 ports/math/octave/files/patch-configure.in (dead) 1.4 +0 -17 ports/math/octave/files/patch-examples+Makefile.in (dead) 1.2 +6 -5 ports/math/octave/files/patch-libcruft+mkf77def.in 1.4 +8 -8 ports/math/octave/files/patch-scripts+pkg+pkg.m 1.52 +2 -25 ports/math/octave/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed committed, thanks!