Bug 156902 - net-mgmt/collectd memory leak
Summary: net-mgmt/collectd memory leak
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 10:00 UTC by Thorkill
Modified: 2011-05-30 21:20 UTC (History)
0 users

See Also:


Attachments
file.diff (266 bytes, patch)
2011-05-09 10:00 UTC, Thorkill
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thorkill 2011-05-09 10:00:19 UTC
meta_data_create() creates a mutex but meta_data_destroy() does not 'destroys' it leave 64 bytes not freed. running collectd over few hours depending on how much hosts report data will allocate much memory.

Fix: patch attached

Patch attached with submission follows:
How-To-Repeat: just run collectd with network plungin as server and let hosts report data to it.
Comment 1 Wesley Shields freebsd_committer freebsd_triage 2011-05-29 23:18:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2011-05-29 23:24:03 UTC
Maintainer of net-mgmt/collectd,

Please note that PR ports/156902 has been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156902

-- WXS
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-05-30 21:18:34 UTC
wxs         2011-05-30 20:18:19 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/collectd    Makefile 
  Added files:
    net-mgmt/collectd/files patch-src__meta_data.c 
  Log:
  - Fix a memory leak.
  
  PR:             ports/156902
  Submitted by:   Thorkill <ml@grid.einherjar.de>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.26      +1 -0      ports/net-mgmt/collectd/Makefile
  1.1       +10 -0     ports/net-mgmt/collectd/files/patch-src__meta_data.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Wesley Shields freebsd_committer freebsd_triage 2011-05-30 21:18:48 UTC
State Changed
From-To: open->closed

Committed. As the maintainer, would you mind pushing this patch upstream 
so that others may benefit from it?