Hi Dirk, note that the current shape of netpbm frequently breaks portmaster upgrades, too, so we should get rid of it as soon as possible. Find below a patch to fix two major issues in graphics/netpbm: 1. the addition to files/patch-Makefile.common fixes the "compile with netpbm version installed" problem. We can remove the pre-configure check. I've tested this with the old 10.28 headers in /usr/local/include (taken from a package), broke before the patch, no ill effects after. Basically we just make sure that -I$(LOCALBASE)/include comes after all the local includes. And certainly we don't want to wedge a PORTREVISION-bumped build... This wasn't too hard, was it? 2. The pre-build line makes it safe to build the whole package in parallel. Consequently mark MAKE_JOBS_SAFE. Tested on a real quad-core computer (AMD Phenom II X4) several times, no build failures. Port maintainer (dinoex@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->dinoex Over to maintainer (via the GNATS Auto Assign Tool)
If this patch gets committed, http://www.freebsd.org/cgi/query-pr.cgi?pr=156577 can be closed, too - it contains the relevant problem description (I hadn't been aware that it was filed as PR, else I could've added the PR when filing the patch. Sorry for that.) -- Matthias Andree
dinoex 2011-05-11 04:19:52 UTC FreeBSD ports repository Modified files: graphics/netpbm Makefile graphics/netpbm/files patch-Makefile.common Added files: graphics/netpbm/files patch-ppmtompeg-Makefile Log: - fix build if old version is installed PR: 156930 Submitted by: Matthias Andree Revision Changes Path 1.198 +1 -3 ports/graphics/netpbm/Makefile 1.4 +12 -3 ports/graphics/netpbm/files/patch-Makefile.common 1.1 +12 -0 ports/graphics/netpbm/files/patch-ppmtompeg-Makefile (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->feedback MAKE_JOBS_SAFE Please test the patch
Dirk, one minor nit from "portlint -C": MAKE_JOBS_SAFE= (in Makefile) wants a tab, not a blank, after the assignment. Other than that, the parallel build works for me. Also, your variant of my proposed patch works well for me and is more efficient. Thanks! Best regards Matthias
State Changed From-To: feedback->open Feedback given.
dinoex 2011-05-11 17:58:09 UTC FreeBSD ports repository Modified files: graphics/netpbm Makefile Log: - use MAKE_JOBS_SAFE PR: 156930 Submitted by: Matthias Andree Revision Changes Path 1.199 +11 -1 ports/graphics/netpbm/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed committed, thanks.