Currently mediaproxy is using an old-style .sh script for start, stop, etc. This patch does the following: 1. Convert to proper rc.d scripts for mediaproxy and proxydispatcher 2. Maintains the mediaproxy script as the "master," so the user experience of 'service mediaproxy <start|stop>' will be the same. 3. Instead of resetting ${WRKSRC}, mv the directory to the more typical name so that we can use mediaproxy.in instead of mediaproxy.sh.in. The one thing I was not sure about was the order of stopping the dispatcher. If it's necessary to stop that before stopping mediaproxy then in mediaproxy.in the stop_postcmd can easily be changed to stop_precmd. Please let me know. Fix: Apply the following patch: How-To-Repeat: DNA
Responsible Changed From-To: freebsd-ports-bugs->dougb Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of net/mediaproxy, Please note that PR ports/157073 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157073 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Had a chance to look at this? -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Sorry for the delay. I believe the patch looks good. I also do not think its encessary to stop dispatcher before relay. I've done it both ways without any noticible issues. On Mon, Aug 08, 2011 at 11:12:32PM -0700, Doug Barton wrote: > Had a chance to look at this? > > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/
State Changed From-To: feedback->closed Committed, thanks!
dougb 2011-08-09 21:31:06 UTC FreeBSD ports repository Modified files: net/mediaproxy Makefile Added files: net/mediaproxy/files mediaproxy.in proxydispatcher.in Removed files: net/mediaproxy/files mediaproxy.sh.in Log: 1. Convert to proper rc.d scripts for mediaproxy and proxydispatcher 2. Maintains the mediaproxy script as the "master," so the user experience of 'service mediaproxy <start|stop>' will be the same. 3. Instead of resetting ${WRKSRC}, mv the directory to the more typical name so that we can use mediaproxy.in instead of mediaproxy.sh.in. PR: ports/157073 Submitted by: me Approved by: maintainer Revision Changes Path 1.11 +7 -4 ports/net/mediaproxy/Makefile 1.1 +35 -0 ports/net/mediaproxy/files/mediaproxy.in (new) 1.4 +0 -88 ports/net/mediaproxy/files/mediaproxy.sh.in (dead) 1.1 +33 -0 ports/net/mediaproxy/files/proxydispatcher.in (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"