0.71 does not compile with 5.14, take maintenership How-To-Repeat: -
Responsible Changed From-To: freebsd-ports-bugs->culot I'll take it.
Hi Kurt, just to be sure: you removed the patch for Makefile.PL in your submission but I don't really see why it should not be used for this version too. Am I missing something or is this patch still relevant (in which case could you please update your submission)? Thanks for your clarification, culot@
State Changed From-To: open->feedback Ask for submitter clarification.
Hi! > just to be sure: you removed the patch for Makefile.PL in your submission > but I don't really see why it should not be used for this version too. The old patch failed in the current version. Attached is the diff which includes a fixed patch as well. > Am I missing something or is this patch still relevant (in which case > could you please update your submission)? I'm not sure whether it's still relevant, but let's assume it is. ---------------- diff -r -u www/p5-FastCGI/Makefile /usr/home/pi/myp/www/p5-FastCGI/Makefile --- www/p5-FastCGI/Makefile 2010-08-23 23:54:07.000000000 +0200 +++ /usr/home/pi/myp/www/p5-FastCGI/Makefile 2011-05-20 14:04:56.000000000 +0200 @@ -6,15 +6,14 @@ # PORTNAME= FastCGI -PORTVERSION= 0.71 -PORTREVISION= 1 +PORTVERSION= 0.72 CATEGORIES= www perl5 MASTER_SITES= CPAN MASTER_SITE_SUBDIR= FCGI PKGNAMEPREFIX= p5- DISTNAME= FCGI-${PORTVERSION} -MAINTAINER= perl@FreeBSD.org +MAINTAINER= fbsd-ports@opsec.eu COMMENT= Modules for perl5, for enabling FastCGI support in CGI scripts # XXX: fcgi.0 is missing FCGX_Detach, see ports/149755 diff -r -u www/p5-FastCGI/distinfo /usr/home/pi/myp/www/p5-FastCGI/distinfo --- www/p5-FastCGI/distinfo 2011-03-19 23:18:38.000000000 +0100 +++ /usr/home/pi/myp/www/p5-FastCGI/distinfo 2011-05-20 14:02:54.000000000 +0200 @@ -1,2 +1,2 @@ -SHA256 (FCGI-0.71.tar.gz) = 9b5b8c1ab62da938c82405cddd0ee4173b257597bf9d567fb81c0dfcc060c64e -SIZE (FCGI-0.71.tar.gz) = 93995 +SHA256 (FCGI-0.72.tar.gz) = fc797abee52755734b298b3fffd494519154f5530dfb83dae19db9a1773a0b58 +SIZE (FCGI-0.72.tar.gz) = 96112 diff -r -u www/p5-FastCGI/files/patch-ab /usr/home/pi/myp/www/p5-FastCGI/files/patch-ab --- www/p5-FastCGI/files/patch-ab 2003-06-16 08:35:12.000000000 +0200 +++ /usr/home/pi/myp/www/p5-FastCGI/files/patch-ab 2011-05-20 19:13:12.000000000 +0200 @@ -1,11 +1,27 @@ ---- Makefile.PL.orig Mon Jun 16 10:31:32 2003 -+++ Makefile.PL Mon Jun 16 10:31:41 2003 -@@ -33,7 +33,7 @@ - $libspec .= "-lfcgi"; - my @l = MM->ext($libspec); - if ($l[0] || $l[1] || $l[2]) { -- $prefix = "$useinstalled/include" if $useinstalled; -+ $prefix = "$useinstalled" if $useinstalled; - $libfound = 1; - push @libs, $libspec; - } +--- Makefile.PL 2011-05-09 16:26:50.000000000 +0200 ++++ /tmp/Makefile.PL 2011-05-20 19:12:30.000000000 +0200 +@@ -29,15 +29,15 @@ + my $devkit = "$cwd/.."; + + if (defined $useinstalled) { +- require ExtUtils::Liblist; +- my $libspec = $useinstalled ? "-L$useinstalled/lib " : ""; +- $libspec .= "-lfcgi"; +- my @l = MM->ext($libspec); +- if ($l[0] || $l[1] || $l[2]) { +- $prefix = "$useinstalled/include" if $useinstalled; +- $libfound = 1; +- push @libs, $libspec; +- } ++ require ExtUtils::Liblist; ++ my $libspec = $useinstalled ? "-L$useinstalled/lib " : ""; ++ $libspec .= "-lfcgi"; ++ my @l = MM->ext($libspec); ++ if ($l[0] || $l[1] || $l[2]) { ++ $prefix = "$useinstalled" if $useinstalled; ++ $libfound = 1; ++ push @libs, $libspec; ++ } + } + if (!$libfound && -d "$devkit/libfcgi" && -d "$devkit/include") { + # devkit ------------------------------- -- pi@opsec.eu +49 171 3101372 9 years to go !
Hi! There's http://www.freebsd.org/cgi/query-pr.cgi?pr=157230 now with a very similar patch. -- pi@opsec.eu +49 171 3101372 9 years to go !
culot 2011-05-22 13:10:15 UTC FreeBSD ports repository Modified files: www/p5-FastCGI Makefile distinfo Removed files: www/p5-FastCGI/files patch-ab Log: - Update to 0.72 Changes: http://search.cpan.org/dist/FCGI/ChangeLog PR: ports/157208 [1], ports/157230 [2] Submitted by: Kurt Jaeger <fbsd-ports@opsec.eu> [1], Alexey Illarionov <littlesavage@rambler.ru> [2] Revision Changes Path 1.22 +1 -3 ports/www/p5-FastCGI/Makefile 1.10 +2 -2 ports/www/p5-FastCGI/distinfo 1.2 +0 -11 ports/www/p5-FastCGI/files/patch-ab (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed (the patch related to Makefile.PL was not needed, sorry for the noise). Thanks!