Bug 157471 - [MAINTAINER] Fix port: mail/sympa unneccessary dependency
Summary: [MAINTAINER] Fix port: mail/sympa unneccessary dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-31 20:00 UTC by Chris Rees
Modified: 2011-06-12 16:10 UTC (History)
0 users

See Also:


Attachments
file.diff (57.65 KB, patch)
2011-05-31 20:00 UTC, Chris Rees
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees 2011-05-31 20:00:23 UTC
There are various problems with the sympa port at present -- they have been fixed and the outline of the fixes is below.

The movement into DATADIR rather that /usr/local/sympa warrants a note in UPDATING, which is at [1].

[1] http://www.bayofrum.net/~crees/patches/sympa-6.1.4_1-UPDATING.patch

Fix: [1] Remove unnecessary dependency on Berkeley DB
[2] Fix RUN_DEPENDS pollution from BUILD_DEPENDS
[2] Use USERS/GROUPS
[2] Use DATADIR rather than ${PREFIX}/sympa
[2] Remove useless post-deinstall target
[2] Stop clobbering config files on deinstall


Submitted by: [1] Igor Zabelin (igorz@yandex.ru), [2] Chris Rees (utisoft@gmail.com) (maintainer)


*** XXX ***
Please bear in mind that pkg-install is now in files/pkg-install.in and I've removed pkg-deinstall.

Patch attached with submission follows:
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2011-06-03 15:01:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Grab
Comment 2 Chris Rees 2011-06-05 19:09:39 UTC
Hi Rene,

Thanks for taking the PR!

I've made another minor change, shown here, new patch is at [1]:

-+.  if ${APACHE_VERSION}>=20
- BUILD_DEPENDS+=
${LOCALBASE}/libexec/apache2/mod_fastcgi.so:${PORTSDIR}/www/mod_fastcgi
+-BUILD_DEPENDS+=
${LOCALBASE}/libexec/apache2/mod_fastcgi.so:${PORTSDIR}/www/mod_fastcgi
 -.     else
-+.  else
- BUILD_DEPENDS+=
${LOCALBASE}/libexec/apache/mod_fastcgi.so:${PORTSDIR}/www/mod_fastcgi
+-BUILD_DEPENDS+=
${LOCALBASE}/libexec/apache/mod_fastcgi.so:${PORTSDIR}/www/mod_fastcgi
 -.     endif
-+.  endif
- BUILD_DEPENDS+=
${SITE_PERL}/${PERL_ARCH}/FCGI.pm:${PORTSDIR}/www/p5-FastCGI
+-BUILD_DEPENDS+=
${SITE_PERL}/${PERL_ARCH}/FCGI.pm:${PORTSDIR}/www/p5-FastCGI
++BUILD_DEPENDS+=
${LOCALBASE}/${APACHEMODDIR}/mod_fastcgi.so:${PORTSDIR}/www/mod_fastcgi
\
++              ${SITE_PERL}/${PERL_ARCH}/FCGI.pm:${PORTSDIR}/www/p5-FastCGI


Suggested commit message:

- Stop guessing APACHEMODDIR


[1] http://www.bayofrum.net/~crees/patches/sympa-depfix_1.patch
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2011-06-06 21:34:24 UTC
State Changed
From-To: open->closed

Committed, thanks
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-06-06 21:34:30 UTC
rene        2011-06-06 20:34:16 UTC

  FreeBSD ports repository

  Modified files:
    mail/sympa           Makefile pkg-plist 
  Added files:
    mail/sympa/files     pkg-install.in 
  Removed files:
    mail/sympa           pkg-deinstall pkg-install 
  Log:
  [1] Remove unnecessary dependency on Berkeley DB
  [2] Fix RUN_DEPENDS pollution from BUILD_DEPENDS
  [2] Use USERS/GROUPS
  [2] Use DATADIR rather than ${PREFIX}/sympa
  [2] Remove useless post-deinstall target
  [2] Stop clobbering config files on deinstall
  
  PR:             ports/157471
  Submitted by:   [1] Igor Zabelin (igorz yandex ru),
                  [2] Chris Rees (utisoft gmail com) (maintainer)
  
  Revision  Changes    Path
  1.25      +43 -33    ports/mail/sympa/Makefile
  1.1       +53 -0     ports/mail/sympa/files/pkg-install.in (new)
  1.4       +0 -20     ports/mail/sympa/pkg-deinstall (dead)
  1.6       +0 -71     ports/mail/sympa/pkg-install (dead)
  1.11      +578 -586  ports/mail/sympa/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-06-12 16:09:57 UTC
crees       2011-06-12 15:09:48 UTC

  FreeBSD ports repository

  Modified files:
    .                    UPDATING 
  Log:
  - Add UPDATING note for mail/sympa 6.1.4_1
  
  PR:             157471
  Submitted by:   Chris Rees (utisoft@gmail.com) (myself)
  Approved by:    rene (mentor)
  
  Revision  Changes    Path
  1.1077    +16 -1     ports/UPDATING
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"