This port uses pkg-install to create new users instead of using USERS= and GROUPS=. Since it's an interactive port, I can't Tinderbox it, and it appears to break compiling on i386. Edward, can you test its compilation and review the attached patch before approving? Fix: - Use USERS and GROUPS Submitted by: Chris Rees (utisoft@gmail.com) This depends on ports/157528; that PR contains the bbs user that this port uses. XXX I've removed the pkg-install script -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.--41AtQYxzqCsKnRmLiWHVW5ygrxK1wY2aPcZqt7LY5R5mWGoe Content-Type: text/plain; name="chinese-firebird.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chinese-firebird.patch" Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/chinese/firebird/Makefile,v retrieving revision 1.11 diff -u -r1.11 Makefile --- Makefile 15 Nov 2006 08:56:28 -0000 1.11 +++ Makefile 2 Jun 2011 11:22:50 -0000 @@ -18,9 +18,10 @@ USE_BZIP2= yes IS_INTERACTIVE= yes NOT_FOR_ARCHS= amd64 +USERS= bbs +GROUPS= ${USERS} pre-install: - ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL ${FIND} ${WRKSRC} -name "*.orig" -delete post-install: Index: pkg-install =================================================================== RCS file: pkg-install diff -N pkg-install --- pkg-install 16 Feb 2001 13:35:31 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,38 +0,0 @@ -#!/bin/sh - -PATH=/bin:/usr/sbin -USER=bbs -GROUP=bbs -UID=9999 -GID=99 - -case $2 in -PRE-INSTALL) - - if pw group show "${GROUP}" 2>/dev/null; then - echo "You already have a group \"${GROUP}\", so I will use it." - else - if pw groupadd ${GROUP} -g ${GID}; then - echo "Added group \"${GROUP}\"." - else - echo "Adding group \"${GROUP}\" failed..." - exit 1 - fi - fi - - if pw user show "${USER}" 2>/dev/null; then - echo "You already have a user \"${USER}\", so I will use it." - else - if pw useradd ${USER} -u ${UID} -g ${GROUP} -h - \ - -d /usr/local/bbs -s /sbin/nologin -c "Firebird BBS" - then - echo "Added user \"${USER}\"." - else - echo "Adding user \"${USER}\" failed..." - exit 1 - fi - fi - - ;; - -esac
Responsible Changed From-To: freebsd-ports-bugs->pgollucci pgollucci@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of chinese/firebird, Please note that PR ports/157537 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157537 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: pgollucci->crees
State Changed From-To: feedback->open Maintainer has timed out.
crees 2011-06-30 17:44:05 UTC FreeBSD ports repository Modified files: chinese/firebird Makefile Removed files: chinese/firebird pkg-install Log: - Use USERS and GROUPS - Mark BROKEN and deprecate -- no commits since 2006 and maintainer timeout PR: ports/157537 Submitted by: Chris Rees <utisoft@gmail.com> Approved by: rene (mentor), maintainer timeout (2 weeks) Revision Changes Path 1.12 +6 -1 ports/chinese/firebird/Makefile 1.2 +0 -38 ports/chinese/firebird/pkg-install (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->patched Deprecated for deletion on 30-08-2011
State Changed From-To: patched->closed Bapt kindly ninja'd the removal of this port.