Bug 157588 - Fix port: irc/ptlink-ircd should use USERS
Summary: Fix port: irc/ptlink-ircd should use USERS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 10:30 UTC by Chris Rees
Modified: 2011-09-03 15:56 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees 2011-06-04 10:30:19 UTC
	

	This port uses pkg-install to create new users instead of using USERS= and GROUPS=

Fix: - Use USERS and GROUPS

	Submitted by: Chris Rees (utisoft@gmail.com)

	Please note that pkg-install has been removed.




-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--hzahHMOSdsd8fydRdM9eY4jQWyAVSEyAU0qWF1mOXVbmZwR7
Content-Type: text/plain; name="irc-ptlink-ircd.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="irc-ptlink-ircd.patch"

Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/irc/ptlink-ircd/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	16 Aug 2009 08:20:29 -0000	1.7
+++ Makefile	2 Jun 2011 19:36:21 -0000
@@ -21,6 +21,9 @@
 USE_RC_SUBR=	ptlink-ircd.sh
 SUB_FILES=	pkg-message
 
+USERS=		${PORTNAME:L}
+GROUPS=		${USERS}
+
 SYSCONFDIR=	${PREFIX}/etc/ptlink-ircd
 
 CONFIGURE_ARGS=	--sysconfdir=${SYSCONFDIR} --localstatedir=/var \
@@ -35,7 +38,6 @@
 .endif
 
 post-install:
-	@${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 	@${CHOWN} -R ircd:ircd ${SYSCONFDIR}
 	@${CAT} ${PKGMESSAGE}
 
Index: pkg-install
===================================================================
RCS file: pkg-install
diff -N pkg-install
--- pkg-install	18 Sep 2005 15:22:04 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,28 +0,0 @@
-#!/bin/sh
-#
-# $FreeBSD: ports/irc/ptlink-ircd/pkg-install,v 1.2 2005/09/18 15:22:04 pav Exp $
-#
-
-case $2 in
-POST-INSTALL)
-	USER=ircd
-	GROUP=ircd
-	UID=72
-	GID=72
-
-	if pw groupshow "${GROUP}" > /dev/null 2>&1; then
-	   echo "===> Using existing group ${GROUP}"
-	else
-	   echo "===> Adding group ${GROUP}"
-	   pw groupadd ${GROUP} -g ${GID} || exit 1
-	fi
-
-	if pw usershow "${USER}" > /dev/null 2>&1; then
-	   echo "===> Using existing user ${USER}"
-	else
-	   echo "===> Adding user ${USER}"
-	   pw adduser ${USER} -u ${UID} -g ${GROUP} -h - -d "/nonexistent" \
-	      -s "/nonexistent" -c "IRC daemon" || exit 1
-	fi
-	;;
-esac
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-04 10:32:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

pgollucci@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-06-22 17:53:11 UTC
Responsible Changed
From-To: pgollucci->crees

Invalid autoassignment
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-06-22 18:01:40 UTC
Responsible Changed
From-To: crees->freebsd-ports-bugs

To pool to correct assign message
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-06-22 18:24:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Invalid autoassignment to pgollucci
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-07-03 14:50:24 UTC
crees       2011-07-03 13:50:11 UTC

  FreeBSD ports repository

  Modified files:
    irc/ptlink-ircd      Makefile 
  Removed files:
    irc/ptlink-ircd      pkg-install 
  Log:
  - Use USERS and GROUPS
  - Deprecate-- no upstream and distfile gone
  
  PR:             ports/157588
  Submitted by:   Chris Rees (utisoft@gmail.com)
  Approved by:    rene (mentor)
  
  Revision  Changes    Path
  1.8       +6 -1      ports/irc/ptlink-ircd/Makefile
  1.3       +0 -28     ports/irc/ptlink-ircd/pkg-install (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Chris Rees freebsd_committer freebsd_triage 2011-07-03 14:50:29 UTC
State Changed
From-To: open->patched

Deprecated for removal in 2 months
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-08-12 10:49:50 UTC
crees       2011-08-12 09:49:41 UTC

  FreeBSD ports repository

  Modified files:
    databases/postgresql83-server Makefile pkg-install-server 
  Log:
  - Use USERS and GROUPS
  
  PR:             ports/157588
  Submitted by:   me
  Approved by:    maintainer timeout (girgen, 9 weeks)
  
  Revision  Changes    Path
  1.211     +2 -6      ports/databases/postgresql83-server/Makefile
  1.8       +1 -38     ports/databases/postgresql83-server/pkg-install-server
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Chris Rees freebsd_committer freebsd_triage 2011-09-03 15:56:52 UTC
State Changed
From-To: patched->closed

Port removed.