Bug 157618 - [PATCH] fix broken configure script of x11-wm/fvwm2
Summary: [PATCH] fix broken configure script of x11-wm/fvwm2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 23:20 UTC by Niclas Zeising
Modified: 2011-06-05 06:40 UTC (History)
0 users

See Also:

Attachments
fvwm.configure.ac.diff (519 bytes, patch)
2011-06-04 23:20 UTC, Niclas Zeising 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas Zeising 2011-06-04 23:20:08 UTC 
	The configure script supplied with the vendor sources for x11-wm/fvwm is broken and won't detect libXcursor if that is not located in ld's default path, which is (normally) the case in FreeBSD (where ports libs are in /usr/local/lib by default). This will not render in any error, and the port will install just fine, but it will not use libXcursor, even if it's present.

Fix: The attached patch is a patch sent to and approved by the vendor.  It is possible to use this patch to patch configure.ac and then use autoconf to generate a new configure script. Another option is to patch the configure script directly, or use some sort of REINPLACE in the makefile. I don't know what is the best course of action.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-04 23:20:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-06-05 06:30:25 UTC 
cy          2011-06-05 05:30:11 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/fvwm2-devel   Makefile 
  Added files:
    x11-wm/fvwm2-devel/files patch-configure.ac 
  Log:
  Configuration improvements:
  
  - Add knobs for SVG and IMLIB.
  - Remove redundant MULTIBYTE option.
  - Add includes to args passed to configure script.
  - Fix libXcursor detection.
  
  PR:             157617 and 157618
  Submitted by:   Niclas Zeising <niclas.zeising@gmail.com>
  
  Revision  Changes    Path
  1.125     +29 -16    ports/x11-wm/fvwm2-devel/Makefile
  1.1       +11 -0     ports/x11-wm/fvwm2-devel/files/patch-configure.ac (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-06-05 06:31:29 UTC 
cy          2011-06-05 05:31:20 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/fvwm2         Makefile 
  Added files:
    x11-wm/fvwm2/files   patch-configure.ac 
  Log:
  Configuration improvements:
  
  - Add knobs for SVG and IMLIB.
  - Remove redundant MULTIBYTE option.
  - Add includes to args passed to configure script.
  - Fix libXcursor detection.
  
  PR:             157617 and 157618
  Submitted by:   Niclas Zeising <niclas.zeising@gmail.com>
  
  Revision  Changes    Path
  1.84      +29 -16    ports/x11-wm/fvwm2/Makefile
  1.1       +11 -0     ports/x11-wm/fvwm2/files/patch-configure.ac (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2011-06-05 06:38:18 UTC 
State Changed
From-To: open->closed

Committed. Thanks for the patch.