Bug 157804 - [patch] shells/scponly fix/cleanup dependencies
Summary: [patch] shells/scponly fix/cleanup dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Olli Hauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-12 23:20 UTC by Olli Hauer
Modified: 2011-06-18 18:45 UTC (History)
1 user (show)

See Also:


Attachments
scponly.diff (1.74 KB, patch)
2011-06-12 23:20 UTC, Olli Hauer
no flags Details | Diff
scponly.diff (9.86 KB, patch)
2011-06-15 08:19 UTC, Robert Farmer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2011-06-12 23:20:09 UTC
Im working at the moment on a new bsd.svn.mk and going over all ports which
have any kind of subversion specified as LIB|BUILD|RUN|FETCH ... dependency.

This port is on my radar since it defines "RUN_DEPENDS+=${BUILD_DEPENDS}" more
than once which should really not happend.

See the following output of "make -V (BUILD|RUN)_DEPENDS" if all SVN options
are selected and watch the part behind ":". You will note subversion will be
included two to four times. Additional the binaries "svn, svnlook, svnserve..."
are included per default in subversion so only check for one of then.

How-To-Repeat: 
Before the patch:
> make -V BUILD_DEPENDS | tr -s ' ' '\n'
svn:/usr/ports/devel/subversion
svnserve:/usr/ports/devel/subversion

> make -V RUN_DEPENDS | tr -s ' ' '\n'
svn:/usr/ports/devel/subversion
svnserve:/usr/ports/devel/subversion
svn:/usr/ports/devel/subversion
svnserve:/usr/ports/devel/subversion

After the patch:
> make -V BUILD_DEPENDS | tr -s ' ' '\n'
svn:/usr/ports/devel/subversion

> make -V RUN_DEPENDS | tr -s ' ' '\n'
svn:/usr/ports/devel/subversion
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-12 23:20:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ohauer

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-12 23:20:31 UTC
Maintainer of shells/scponly,

Please note that PR ports/157804 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157804

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-12 23:20:33 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Robert Farmer 2011-06-15 08:19:56 UTC
On Sun, Jun 12, 2011 at 3:20 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
> Maintainer of shells/scponly,
>
> Please note that PR ports/157804 has just been submitted.
>

I've actually been planning to update this to a recent snapshot (the
major changes are already patches in the files directory). I've
included your changes, can you commit this:

-Add both versions of each configure flag (--enable-x/--disable-x) for safety
-Update to May 26, 2011 snapshot:
   Add support for OpenSSH's sftp-server umask option.
   Remove inline references to satisify certain compilers
   Remove the now unnecessary sftp-logging compatibility mode.
   When getopt_long is not available, like on AIX, use bundled NetBSD
       getopt_long.
   Update the SECURITY document to include a reference to /etc/popt and\
       ~/.popt as they relate to rsync.
   Fix for rsync-3.0 which now uses a short -e option, with an optional
       argument as a server side option indicating protocol compatibility.
   Fix scponly crash on Solaris
   Fix detection and inclusion of getopt on certain platforms
   Document risks associated with popt reading /etc/popt and ~/.popt
   Document getopt requirement (when certain configure options are enabled)

-- 
Rob Farmer
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-06-18 18:24:20 UTC
ohauer      2011-06-18 17:24:07 UTC

  FreeBSD ports repository

  Modified files:
    shells/scponly       Makefile distinfo 
  Removed files:
    shells/scponly/files patch-SECURITY patch-helper.c 
                         patch-scponly.c 
  Log:
   -Add both versions of each configure flag (--enable-x/--disable-x) for safety
   -Update to May 26, 2011 snapshot:
      Add support for OpenSSH's sftp-server umask option.
      Remove inline references to satisify certain compilers
      Remove the now unnecessary sftp-logging compatibility mode.
      When getopt_long is not available, like on AIX, use bundled NetBSD
          getopt_long.
      Update the SECURITY document to include a reference to /etc/popt and \
          ~/.popt as they relate to rsync.
      Fix for rsync-3.0 which now uses a short -e option, with an optional
          argument as a server side option indicating protocol compatibility.
      Fix scponly crash on Solaris
      Fix detection and inclusion of getopt on certain platforms
      Document risks associated with popt reading /etc/popt and ~/.popt
      Document getopt requirement (when certain configure options are enabled)
   - cleanup redundant BUILD_DEPENDS+=  [1]
  
  PR:             ports/157804
  Submitted by:   Rob Farmer <rfarmer _at_ predatorlabs.net> (maintainer), ohauer  [1]
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.37      +30 -16    ports/shells/scponly/Makefile
  1.17      +2 -2      ports/shells/scponly/distinfo
  1.2       +0 -32     ports/shells/scponly/files/patch-SECURITY (dead)
  1.5       +0 -91     ports/shells/scponly/files/patch-helper.c (dead)
  1.2       +0 -38     ports/shells/scponly/files/patch-scponly.c (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2011-06-18 18:44:36 UTC
State Changed
From-To: feedback->closed

Committed, 
Thanks!