- Update to 1.1.11 - Fix DISTFILES: do not hardcode version - Add perl5 CATEGORIES - Use bsd.port.mk + bsd.port.options.mk - Cosmetic change Port maintainer (jdunn@aquezada.com) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->sunpoet Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of net-im/ttytter, Please note that PR ports/157888 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157888 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi Sunpoet, This looks good except for one thing. The reason I hardcode the version is because the vendor's numbering of = the distfile sometimes does not match the FreeBSD syntax for = $PORTVERSION. Example: version 1.1.2 was shipped as 1.1.02.txt. I = haven't been able to convince him to change this. - Julian
Hi Julian, FYI, using PORTVERSION for DISTNAME/DISTFILES helps portscout to check (or guess) if these exists a new version. In the case of version 1.1.2, we may adjust DISTFILES as ${PORTVERSION:R}.0${PORTVERSION:E}. This trick is widely used in ports framework. Thanks. Regards, sunpoet
On 2011-06-14, at 10:22 PM, Sunpoet Po-Chuan Hsieh wrote: > FYI, using PORTVERSION for DISTNAME/DISTFILES helps portscout to check > (or guess) if these exists a new version. In the case of version 1.1.2, > we may adjust DISTFILES as ${PORTVERSION:R}.0${PORTVERSION:E}. This > trick is widely used in ports framework. > Thanks. Sure, that makes sense too. - Julian
Hi Julian, As 1.1.12 is out, I've made a new patch. Please review if it's OK to commit. Thanks. Regards, sunpoet --- ttytter-1.1.12 begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/net-im/ttytter/Makefile,v retrieving revision 1.17 diff -u -r1.17 Makefile --- Makefile 14 Mar 2011 16:01:55 -0000 1.17 +++ Makefile 17 Jun 2011 19:40:14 -0000 @@ -1,48 +1,48 @@ # New ports collection makefile for: ttytter -# Date created: 21 March 2009 -# Whom: Julian C. Dunn <jdunn@aquezada.com> +# Date created: 21 March 2009 +# Whom: Julian C. Dunn <jdunn@aquezada.com> # # $FreeBSD: ports/net-im/ttytter/Makefile,v 1.17 2011/03/14 16:01:55 miwi Exp $ PORTNAME= ttytter -PORTVERSION= 1.1.10 -CATEGORIES= net-im +PORTVERSION= 1.1.12 +CATEGORIES= net-im perl5 MASTER_SITES= http://www.floodgap.com/software/ttytter/dist1/ -DISTFILES= 1.1.10.txt -EXTRACT_ONLY= +DISTNAME= ${PORTVERSION} +EXTRACT_SUFX= .txt MAINTAINER= jdunn@aquezada.com COMMENT= Command-line Twitter client in Perl -RUN_DEPENDS= ${SITE_PERL}/Date/Parse.pm:${PORTSDIR}/devel/p5-TimeDate \ - curl:${PORTSDIR}/ftp/curl +RUN_DEPENDS= curl:${PORTSDIR}/ftp/curl \ + p5-TimeDate>=0:${PORTSDIR}/devel/p5-TimeDate NO_BUILD= yes USE_PERL5_RUN= yes -OPTIONS= READLINE "Include rich readline support" on \ - RLTTYTTER "Use T::R::TTYtter readline driver (beta!)" off \ +OPTIONS= READLINE "Include rich readline support" on \ + RLTTYTTER "Use T::R::TTYtter readline driver (beta!)" off \ PLIST_FILES= bin/${PORTNAME} -.include <bsd.port.pre.mk> +.include <bsd.port.options.mk> -.if defined(WITH_READLINE) -RUN_DEPENDS+= ${SITE_PERL}/Term/ReadLine/Perl.pm:${PORTSDIR}/devel/p5-ReadLine-Perl +.if !defined(WITHOUT_READLINE) +RUN_DEPENDS+= p5-ReadLine-Perl>=0:${PORTSDIR}/devel/p5-ReadLine-Perl .endif .if defined(WITH_RLTTYTTER) -RUN_DEPENDS+= ${SITE_PERL}/Term/ReadLine/TTYtter.pm:${PORTSDIR}/devel/p5-ReadLine-TTYtter +RUN_DEPENDS+= p5-ReadLine-TTYtter>=0:${PORTSDIR}/devel/p5-ReadLine-TTYtter .endif do-extract: @${MKDIR} ${WRKSRC} - @${CP} ${DISTDIR}/${DISTFILES} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.txt + @${CP} ${DISTDIR}/${DISTFILES} ${WRKSRC}/${DISTFILES} post-patch: - @${REINPLACE_CMD} -e 's|^\#!/usr/bin/perl|\#!${PERL}|' ${WRKSRC}/${PORTNAME}-${PORTVERSION}.txt + @${REINPLACE_CMD} -e 's|^\#!/usr/bin/perl|\#!${PERL}|' ${WRKSRC}/${DISTFILES} do-install: - ${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.txt ${PREFIX}/bin/${PORTNAME} + ${INSTALL_SCRIPT} ${WRKSRC}/${DISTFILES} ${PREFIX}/bin/${PORTNAME} -.include <bsd.port.post.mk> +.include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /home/pcvs/ports/net-im/ttytter/distinfo,v retrieving revision 1.17 diff -u -r1.17 distinfo --- distinfo 14 Mar 2011 16:01:55 -0000 1.17 +++ distinfo 17 Jun 2011 19:40:14 -0000 @@ -1,2 +1,2 @@ -SHA256 (1.1.10.txt) = 5d78c562ebc57a4f8c1467e5c169281ebf8096c8f966c11843fde6bb429c111e -SIZE (1.1.10.txt) = 150600 +SHA256 (1.1.12.txt) = 9df043ceae85bab57da34fb02542b9eb70c90f0c8f65db90192f80e8f9cf0f13 +SIZE (1.1.12.txt) = 157104 --- ttytter-1.1.12 ends here ---
Yes, this looks okay to commit. Thanks Julian On Fri, Jun 17, 2011 at 3:40 PM, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > Hi Julian, > > As 1.1.12 is out, I've made a new patch. Please review if it's OK to > commit. Thanks. > > Regards, > sunpoet > > --- ttytter-1.1.12 begins here --- > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/pcvs/ports/net-im/ttytter/Makefile,v > retrieving revision 1.17 > diff -u -r1.17 Makefile > --- Makefile =A0 =A014 Mar 2011 16:01:55 -0000 =A0 =A0 =A01.17 > +++ Makefile =A0 =A017 Jun 2011 19:40:14 -0000 > @@ -1,48 +1,48 @@ > =A0# New ports collection makefile for: =A0 ttytter > -# Date created: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A021 March 2009 > -# Whom: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0Julian C. Dunn <jdunn@aquezada.com> > +# Date created: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A021 March 2009 > +# Whom: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Julian C. Dunn <j= dunn@aquezada.com> > =A0# > =A0# $FreeBSD: ports/net-im/ttytter/Makefile,v 1.17 2011/03/14 16:01:55 m= iwi Exp $ > > =A0PORTNAME=3D =A0 =A0 =A0ttytter > -PORTVERSION=3D =A0 1.1.10 > -CATEGORIES=3D =A0 =A0net-im > +PORTVERSION=3D =A0 1.1.12 > +CATEGORIES=3D =A0 =A0net-im perl5 > =A0MASTER_SITES=3D =A0http://www.floodgap.com/software/ttytter/dist1/ > -DISTFILES=3D =A0 =A0 1.1.10.txt > -EXTRACT_ONLY=3D > +DISTNAME=3D =A0 =A0 =A0${PORTVERSION} > +EXTRACT_SUFX=3D =A0.txt > > =A0MAINTAINER=3D =A0 =A0jdunn@aquezada.com > =A0COMMENT=3D =A0 =A0 =A0 Command-line Twitter client in Perl > > -RUN_DEPENDS=3D =A0 ${SITE_PERL}/Date/Parse.pm:${PORTSDIR}/devel/p5-TimeD= ate \ > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 curl:${PORTSDIR}/ftp/curl > +RUN_DEPENDS=3D =A0 curl:${PORTSDIR}/ftp/curl \ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 p5-TimeDate>=3D0:${PORTSDIR}/devel/p5-TimeD= ate > > =A0NO_BUILD=3D =A0 =A0 =A0yes > =A0USE_PERL5_RUN=3D yes > > -OPTIONS=3D =A0 =A0 =A0 READLINE =A0 =A0 =A0 =A0"Include rich readline su= pport" on \ > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 RLTTYTTER =A0 =A0 =A0 "Use T::R::TTYtter re= adline driver (beta!)" off \ > +OPTIONS=3D =A0 =A0 =A0 READLINE =A0 =A0 =A0 =A0"Include rich readline su= pport" on \ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 RLTTYTTER =A0 =A0 =A0 "Use T::R::TTYtter re= adline driver (beta!)" off \ > > =A0PLIST_FILES=3D =A0 bin/${PORTNAME} > > -.include <bsd.port.pre.mk> > +.include <bsd.port.options.mk> > > -.if defined(WITH_READLINE) > -RUN_DEPENDS+=3D =A0${SITE_PERL}/Term/ReadLine/Perl.pm:${PORTSDIR}/devel/= p5-ReadLine-Perl > +.if !defined(WITHOUT_READLINE) > +RUN_DEPENDS+=3D =A0p5-ReadLine-Perl>=3D0:${PORTSDIR}/devel/p5-ReadLine-P= erl > =A0.endif > > =A0.if defined(WITH_RLTTYTTER) > -RUN_DEPENDS+=3D =A0${SITE_PERL}/Term/ReadLine/TTYtter.pm:${PORTSDIR}/dev= el/p5-ReadLine-TTYtter > +RUN_DEPENDS+=3D =A0p5-ReadLine-TTYtter>=3D0:${PORTSDIR}/devel/p5-ReadLin= e-TTYtter > =A0.endif > > =A0do-extract: > =A0 =A0 =A0 =A0@${MKDIR} ${WRKSRC} > - =A0 =A0 =A0 @${CP} ${DISTDIR}/${DISTFILES} =A0${WRKSRC}/${PORTNAME}-${P= ORTVERSION}.txt > + =A0 =A0 =A0 @${CP} ${DISTDIR}/${DISTFILES} ${WRKSRC}/${DISTFILES} > > =A0post-patch: > - =A0 =A0 =A0 @${REINPLACE_CMD} -e 's|^\#!/usr/bin/perl|\#!${PERL}|' ${WR= KSRC}/${PORTNAME}-${PORTVERSION}.txt > + =A0 =A0 =A0 @${REINPLACE_CMD} -e 's|^\#!/usr/bin/perl|\#!${PERL}|' ${WR= KSRC}/${DISTFILES} > > =A0do-install: > - =A0 =A0 =A0 ${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME}-${PORTVERSION}.txt = ${PREFIX}/bin/${PORTNAME} > + =A0 =A0 =A0 ${INSTALL_SCRIPT} ${WRKSRC}/${DISTFILES} ${PREFIX}/bin/${PO= RTNAME} > > -.include <bsd.port.post.mk> > +.include <bsd.port.mk> > Index: distinfo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/pcvs/ports/net-im/ttytter/distinfo,v > retrieving revision 1.17 > diff -u -r1.17 distinfo > --- distinfo =A0 =A014 Mar 2011 16:01:55 -0000 =A0 =A0 =A01.17 > +++ distinfo =A0 =A017 Jun 2011 19:40:14 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (1.1.10.txt) =3D 5d78c562ebc57a4f8c1467e5c169281ebf8096c8f966c118= 43fde6bb429c111e > -SIZE (1.1.10.txt) =3D 150600 > +SHA256 (1.1.12.txt) =3D 9df043ceae85bab57da34fb02542b9eb70c90f0c8f65db90= 192f80e8f9cf0f13 > +SIZE (1.1.12.txt) =3D 157104 > --- ttytter-1.1.12 ends here --- >
State Changed From-To: feedback->closed Committed. Thanks!
sunpoet 2011-06-18 18:08:53 UTC FreeBSD ports repository Modified files: net-im/ttytter Makefile distinfo Log: - Update to 1.1.12 - Fix DISTFILES: do not hardcode version - Add perl5 CATEGORIES - Use bsd.port.options.mk - Make portlint happier - Cosmetic change Changes: http://www.floodgap.com/software/ttytter/dl.html 1.1.12: - Patches for Perl 5.14 (thanks @rkfb for the report). - Keyfiles can now be regenerated if they are corrupted or need to be updated with -retoke. - /doesfollow should give true or false with -runcommand (thanks @kaleidoscopique for the report). Similarly, /short should also work, emitting the URL (thanks @microlifter for that report). - Properly understands a new Twitter ad-hoc error format, which repairs some operations that would unexpectedly appear to succeed but didn't actually (thanks @augmentedfourth for the report). - -readline autocomplete command list now up-to-date. 1.1.11: - Fixed a bug where TTYtter crashes ungracefully if OAuth credentials fail. - Fixed regex in command processor that interpreted all commands starting with /p as /print. - -notimeline is now properly recognized by /set as a boolean. - One last issue related to URL shortening. PR: ports/157888 Submitted by: sunpoet (myself) Approved by: Julian Dunn <jdunn@aquezada.com> (maintainer) Revision Changes Path 1.18 +18 -18 ports/net-im/ttytter/Makefile 1.18 +2 -2 ports/net-im/ttytter/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"