Bug 158070 - [PATCH] fix net-im/pidgin-sipe to compile with libpurple.8
Summary: [PATCH] fix net-im/pidgin-sipe to compile with libpurple.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 16:00 UTC by atkin901
Modified: 2011-06-21 22:00 UTC (History)
0 users

See Also:


Attachments
file.diff (2.11 KB, patch)
2011-06-20 16:00 UTC, atkin901
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description atkin901 2011-06-20 16:00:33 UTC
With the current update to libpurple.8 net-im/pidgin-sipe will die during compilation with the following error:


libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../.. -Werror -Wall -Wextra -Werror=declaration-after-statement -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libpurple -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I./../api -DLOCALEDIR=\"/usr/local/share/locale\" -O2 -pipe -march=pentiumpro -I//usr/local/include -fno-strict-aliasing -MT libsipe_backend_la-purple-dnsquery.lo -MD -MP -MF .deps/libsipe_backend_la-purple-dnsquery.Tpo -c purple-dnsquery.c  -fPIC -DPIC -o .libs/libsipe_backend_la-purple-dnsquery.o
In file included from purple-dnsquery.c:25:
/usr/local/include/libpurple/dnssrv.h:115: error: expected ')' before '*' token
/usr/local/include/libpurple/dnssrv.h:150: error: expected ')' before '*' token
cc1: warnings being treated as errors
purple-dnsquery.c: In function 'sipe_backend_dns_query':
purple-dnsquery.c:64: warning: assignment from incompatible pointer type
gmake[3]: *** [libsipe_backend_la-purple-dnsquery.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/net-im/pidgin-sipe/work/pidgin-sipe-1.11.2/src/purple'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/net-im/pidgin-sipe/work/pidgin-sipe-1.11.2/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/net-im/pidgin-sipe/work/pidgin-sipe-1.11.2'
gmake: *** [all] Error 2
*** Error code 1

Stop in /usr/ports/net-im/pidgin-sipe.

Fix: Apply the attached patch to net-im/pidgin-sipe and rebuild.

sources:

http://permalink.gmane.org/gmane.linux.debian.devel.bugs.general/838995
http://aur.archlinux.org/packages.php?ID=16170


Patch attached with submission follows:
How-To-Repeat: make in /usr/ports/net-im/pidgin-sipe after the libpurple.8 update (ports pr 157934)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-20 16:00:42 UTC
Maintainer of net-im/pidgin-sipe,

Please note that PR ports/158070 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158070

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-20 16:00:44 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2011-06-21 10:21:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

I will take care of it.
Comment 4 Emanuel Haupt 2011-06-21 10:34:38 UTC
I can confirm that the submitted patch works. John, may I commit it?
Comment 5 john.c.prather 2011-06-21 21:27:17 UTC
Emanuel and I have an email thread open in which I agreed that this
patch be committed.

Thanks for everyone's contributions!

-john
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-06-21 21:55:24 UTC
ehaupt      2011-06-21 20:55:07 UTC

  FreeBSD ports repository

  Added files:
    net-im/pidgin-sipe/files patch-src__purple__purple-dnsquery.c 
                             patch-src__purple__purple-plugin.c 
                             patch-src__purple__purple-private.h 
  Log:
  Fix build with with libpurple.8
  
  PR:             158070
  Submitted by:   Mark Atkinson <atkin901@gmail.com>
  Approved by:    John Prather <john.c.prather@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.1       +13 -0     ports/net-im/pidgin-sipe/files/patch-src__purple__purple-dnsquery.c (new)
  1.1       +13 -0     ports/net-im/pidgin-sipe/files/patch-src__purple__purple-plugin.c (new)
  1.1       +31 -0     ports/net-im/pidgin-sipe/files/patch-src__purple__purple-private.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2011-06-21 21:55:26 UTC
State Changed
From-To: feedback->closed

Committed, thanks!