Bug 158105 - [maintainer-update] games/traindirector: Respect CXX (fix with clang)
Summary: [maintainer-update] games/traindirector: Respect CXX (fix with clang)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dennis Herrmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 12:40 UTC by Guido Falsi
Modified: 2012-01-02 17:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.82 KB, patch)
2011-06-21 12:40 UTC, Guido Falsi
no flags Details | Diff
tdir.diff (1.44 KB, patch)
2011-07-04 12:05 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2011-06-21 12:40:13 UTC
Fix an hardcoded CXX= in the makefile. This was uncovered by the clang exp run.

While there remove MD5, add LICENSE and make portlint happier.
Comment 1 Dennis Herrmann freebsd_committer freebsd_triage 2011-06-21 13:56:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dhn

I'll take it.
Comment 2 Dennis Herrmann freebsd_committer freebsd_triage 2011-06-22 17:40:20 UTC
State Changed
From-To: open->feedback

pls check this 
http://tb.4bit.ws/index.php?action=display_markup_log&build=FreeBSD-9_64bit&id=1087 

-dhn
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2011-06-22 21:19:14 UTC
I was hoping that was the only problem since I don't have any clang 
enabled machines handy.

I'm now setting up a Virtual Machine with 9-clang to perform tests 
myself on ports.

I'll followup with a revised (and tested) patch in the next few days.

-- 
Guido Falsi <mad@madpilot.net>
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2011-07-04 12:05:20 UTC
I have tried the port in a 9-CURRENT machine with clang only and it
compiles and installs correctly.

I'm not able to see the reported error message anymore. Could this be
checked again?

I'm attaching a revised patch anyway since the port was modified and the
original patch does not apply anymore.

-- 
Guido Falsi <mad@madpilot.net>
Comment 5 Dennis Herrmann freebsd_committer freebsd_triage 2011-07-05 18:10:49 UTC
State Changed
From-To: feedback->open

I test it again without clang/clang++ but the port failed , look at this 
log: http://tb.4bit.ws/index.php?action=describe_port&id=379
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2011-07-14 13:37:12 UTC
I've tried to reproduce the reported issue, but I really was not able,
both with clang and gcc.

I'm terribly sorry but i really don't know from where those errors could
be coming in your case.

I tested on an 8.2-STABLE machine with gcc and on a 9-CURRENT VM with
clang.(both amd64)

I also tested it in a tinderbox configured to build on 8.2-stable-amd64
and 8.2-stable-i386.

None of these builds shows this error. I have the build logs if needed.

I need some more information about this error to understand it. Do you
have any special options or configuration in that tinderbox?

Thank you and sorry for the inconvenience.

-- 
Guido Falsi <mad@madpilot.net>
Comment 7 Dennis Herrmann freebsd_committer freebsd_triage 2011-07-22 12:11:56 UTC
State Changed
From-To: open->feedback

The TB has this configuration: 

root@ID7 /usr/local/tinderbox/scripts % ./tc configGet 
CCACHE_DIR=/ccache CCACHE_ENABLED=1 CCACHE_JAIL=0 CCACHE_LOGFILE= 
CCACHE_MAX_SIZE=150G CCACHE_NOLINK=1 DISTFILE_CACHE= DISTFILE_URI= 
HOST_WORKDIR= LOG_COMPRESSLOGS=0 LOG_DIRECTORY= LOG_DOCOPY=0 
OPTIONS_DIR= OPTIONS_ENABLED=0 TINDERD_LOGFILE=/dev/null 
TINDERD_SLEEPTIME=30 __DSVERSION__=3.0 

with new HEAD jails and new porttre 

-dhn
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2012-01-02 15:57:36 UTC
Hi,

I've tried to reproduce the problem but really been unable too.

I now tried to test this port with this patch on the new redports
infrastructure and it is going well there too.

Here are the links to the logs:

8.2-RELEASE/amd64
https://redports.org/~madpilot/20111230194237-38491-1565/traindirector-3.6_3.log

9-CURRENT/amd64
https://redports.org/~madpilot/20111230194237-38491-1561/traindirector-3.6_3.log

CLANG
https://redports.org/~madpilot/20111230194237-38491-1563/traindirector-3.6_3.log

Quatty(stated to be a QAT style tinderbox):
https://redports.org/~madpilot/20111230202552-22831-1591/traindirector-3.6_3.log

Could you please revise these logs and the patch and check if there
really is something wrong or not?

Thanks in advance.

-- 
Guido Falsi <mad@madpilot.net>
Comment 9 dfilter service freebsd_committer freebsd_triage 2012-01-02 16:50:08 UTC
dhn         2012-01-02 16:49:59 UTC

  FreeBSD ports repository

  Modified files:
    games/traindirector  Makefile 
    games/traindirector/files patch-Makefile.fc9 
  Log:
  - Fix build with clang
  
  PR:             ports/158105
  Submitted by:   Guido Falsi <mad@madpilot.net> (maintainer)
  
  Revision  Changes    Path
  1.23      +3 -1      ports/games/traindirector/Makefile
  1.4       +6 -3      ports/games/traindirector/files/patch-Makefile.fc9
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Dennis Herrmann freebsd_committer freebsd_triage 2012-01-02 16:50:17 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!