The mplayer port automatically links to faad if it's installed (autoconf feature). Thus if you have faad installed because of an other port dependency and you'll remove this port faad will be marked as leave but mplayer still need it. This patch prevents this case and user must specify itself the action or not. I choose the ON option by default.
Maintainer of multimedia/mplayer, Please note that PR ports/158501 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158501 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->crees I'll take it.
Hi David, I might suggest defaulting to off, or it'll drag in a new dependency to the package. Unless you complain I'll change it before I commit :) Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
State Changed From-To: feedback->open Maintainer has fixed.
State Changed From-To: open->closed Committed, with minor changes. Thanks!
crees 2011-08-21 08:11:55 UTC FreeBSD ports repository Modified files: multimedia/mplayer Makefile Makefile.options Makefile.shared Log: - As discussed with maintainer, disable linking to external faad. - While here, add $FreeBSD$ to other Makefiles PR: ports/158501 Submitted by: David Demelier <demelier.david@gmail.com> Reviewed by: Thomas Zander <riggs@rrr.de> (maintainer), naddy Approved by: Thomas Zander <riggs@rrr.de> (maintainer) Revision Changes Path 1.209 +1 -0 ports/multimedia/mplayer/Makefile 1.21 +2 -0 ports/multimedia/mplayer/Makefile.options 1.13 +2 -0 ports/multimedia/mplayer/Makefile.shared _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"