Bug 158723 - [PATCH] lang/sbcl: don't require graphviz if not needed for build
Summary: [PATCH] lang/sbcl: don't require graphviz if not needed for build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stanislav Sedov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 09:50 UTC by Quentin Stievenart
Modified: 2011-07-13 20:20 UTC (History)
0 users

See Also:

Attachments
file.diff (857 bytes, patch)
2011-07-08 09:50 UTC, Quentin Stievenart 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Stievenart 2011-07-08 09:50:01 UTC 
graphviz (which adds a lot of dependencies, especially on x11-less servers) should not be required if the user doesn't want to build sbcl's doc (ie. NOPORTDOCS is set, and the PDF and PS options aren't selected). This patch fixes that.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-08 09:50:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->stas

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Stanislav Sedov freebsd_committer freebsd_triage 2011-07-08 19:33:35 UTC 
Hi!

The `dot` utility is actually used to build texinfo documentation
as well which is conditionless (see Makefile in sbcl-internal).
So we cannot disable it if PDF/PS documentation is disabled.

The right solution might be to make the build of sbcl-internal
documentation optional and make sbcl build depend on dot only
in that case.

-- 
Stanislav Sedov
ST4096-RIPE

()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments
Comment 3 Stanislav Sedov freebsd_committer freebsd_triage 2011-07-08 19:35:36 UTC 
State Changed
From-To: open->feedback

Ask for sumbitter feedback.
Comment 4 quentin.stievenart 2011-07-13 14:18:48 UTC 
Yes, dot is needed to build texinfo documentation, but texinfo
documentation isn't build if NOPORTDOCS is specified. And dot is
necessary if we build the PDF or PS documentation, and it's because of
that that I added the three conditions in the patch. So the build of
sbcl-internal is already optional (and depends on the value of
NOPORTDOCS), or I missed something.
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-07-13 20:13:43 UTC 
stas        2011-07-13 19:13:29 UTC

  FreeBSD ports repository

  Modified files:
    lang/sbcl            Makefile 
  Log:
  - Graphviz is not required for the build if all the documentation is disabled.
  
  PR:             ports/158723
  Submitted by:   Quentin Stievenart <acieroid@awesom.eu>
  
  Revision  Changes    Path
  1.88      +4 -2      ports/lang/sbcl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Stanislav Sedov freebsd_committer freebsd_triage 2011-07-13 20:14:25 UTC 
State Changed
From-To: feedback->closed

You're right, my bad.  Just committed your patch.  Thanks!