- Update to 1.1.2 Port maintainer (shuvaev@physik.uni-wuerzburg.de) is cc'd. Generated with FreeBSD Port Tools 0.99
Maintainer of devel/libisofs, Please note that PR ports/158912 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158912 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->sunpoet I'll take it.
On Thu, Jul 21, 2011 at 10:46:21AM +0000, sunpoet@FreeBSD.org wrote: > Synopsis: [PATCH] devel/libisofs: update to 1.1.2 > > Responsible-Changed-From-To: freebsd-ports-bugs->sunpoet > Responsible-Changed-By: sunpoet > Responsible-Changed-When: Thu Jul 21 10:46:20 UTC 2011 > Responsible-Changed-Why: > I'll take it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=158912 > Update looks good to me, but I have not managed to find even little time to test it. Please, test that the ports devel/libburn sysutils/xorriso and sysutils/xfburn at least compile and package normally. I think, you can treat this as a "maintainer approval". Thanks for taking it. Alexey.
On Thu, Jul 21, 2011 at 01:17:52PM +0200, Alexey Shuvaev wrote: > Update looks good to me, but I have not managed to find even little time > to test it. > > Please, test that the ports devel/libburn sysutils/xorriso > and sysutils/xfburn at least compile and package normally. > I think, you can treat this as a "maintainer approval". > Apart from the note, that I posted to devel/libburn follow-up regarding the usage of -lpthread to link with libpthread (instead of -pthread), is the CONFIGURE_ARGS= assignment really needed? E.g. libisofs (and xorriso) compiled and then worked fine with this line commented out: #CONFIGURE_ARGS= CFLAGS="-I${PREFIX}/include" LDFLAGS="-L${PREFIX}/lib -liconv" I don't have tinderbox at hand now, can you please test it? At least -liconv seems to me to be governed by USE_ICONV. Thanks, Alexey.
On Mon, Jul 25, 2011 at 05:54:22PM +0200, Alexey Shuvaev wrote: > On Thu, Jul 21, 2011 at 01:17:52PM +0200, Alexey Shuvaev wrote: > > Update looks good to me, but I have not managed to find even little time > > to test it. > > > > Please, test that the ports devel/libburn sysutils/xorriso > > and sysutils/xfburn at least compile and package normally. > > I think, you can treat this as a "maintainer approval". > > > Apart from the note, that I posted to devel/libburn follow-up regarding > the usage of -lpthread to link with libpthread (instead of -pthread), > is the CONFIGURE_ARGS= assignment really needed? E.g. libisofs (and xorriso) > compiled and then worked fine with this line commented out: > > #CONFIGURE_ARGS= CFLAGS="-I${PREFIX}/include" LDFLAGS="-L${PREFIX}/lib -liconv" > > I don't have tinderbox at hand now, can you please test it? > At least -liconv seems to me to be governed by USE_ICONV. > > Thanks, > Alexey. Hi Alexey, USE_ICONV only brings in libiconv as a library dependency. It does not handle linking options. In this case, libisofs itself correctly add -liconv during build. Tinerbox result shows it's OK to remove this line. Thanks. Regards, -- Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org> 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
sunpoet 2011-07-28 06:42:01 UTC FreeBSD ports repository Modified files: devel/libisofs Makefile distinfo Log: - Update to 1.1.2 Changes: 1.1.2: - New API call iso_image_get_bootcat() 1.1.0: - Bug fix: Padding as of iso_write_opts_set_tail_blocks() was added only after cylinder alignment as of iso_write_opts_set_system_area() and thus spoiled this alignment. PR: ports/158912 Submitted by: Jin-Sih Lin <linpct@gmail.com> Approved by: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de> (maintainer) Revision Changes Path 1.6 +4 -3 ports/devel/libisofs/Makefile 1.5 +2 -2 ports/devel/libisofs/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!