make ===> Building for php-adodb-ext-5.04_1 /bin/sh /usr/ports/databases/php-adodb-ext/work/adodb-504/libtool --mode=compile cc -I. -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -DPHP_ATOM_INC -I/usr/ports/databases/php-adodb-ext/work/adodb-504/include -I/usr/ports/databases/php-adodb-ext/work/adodb-504/main -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DHAVE_CONFIG_H -O2 -fno-strict-aliasing -pipe -march=nocona -c /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c -o adodb.lo cc -I. -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -DPHP_ATOM_INC -I/usr/ports/databases/php-adodb-ext/work/adodb-504/include -I/usr/ports/databases/php-adodb-ext/work/adodb-504/main -I/usr/ports/databases/php-adodb-ext/work/adodb-504 -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DHAVE_CONFIG_H -O2 -fno-strict-aliasing -pipe -march=nocona -c /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c -fPIC -DPIC -o .libs/adodb.o /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c: In function 'adodb_call_fetch': /usr/ports/databases/php-adodb-ext/work/adodb-504/adodb.c:280: error: 'zend_fcall_info' has no member named 'object_ptr' *** Error code 1 Stop in /usr/ports/databases/php-adodb-ext/work/adodb-504. *** Error code 1 Stop in /usr/ports/databases/php-adodb-ext. confirmed: file /usr/local/include/php/Zend/zend_API.h does NOT have a member 'object_ptr' in zend_fcall_info (it does have an object_pp: typedef struct _zend_fcall_info { size_t size; HashTable *function_table; zval *function_name; HashTable *symbol_table; zval **retval_ptr_ptr; zend_uint param_count; zval ***params; zval **object_pp; zend_bool no_separation; } zend_fcall_info; from <https://github.com/sebastianbergmann/php-test-helpers/issues/7> not sure if this means that this will only work on php-5.3 or not. maybe mark this port broken on php < 5.3 Fix: mark port broken if php < 5.3? hack a cast to the wrapper?
Responsible Changed From-To: freebsd-ports-bugs->gabor gabor@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of databases/php-adodb-ext, Please note that PR ports/159125 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159125 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Dear ports committer, Please change fiile name from /usr/ports/databases/php-adodb-ext/files/patch-adodb.c to /usr/ports/databases/php-adodb-ext/files/extra-patch-adodb.c , and commit following patch file : diff -ruN --exclude=CVS /usr/ports/databases/php-adodb-ext/Makefile /home/admin/joehorn/php-adodb-ext/Makefile --- /usr/ports/databases/php-adodb-ext/Makefile 2010-04-12 21:56:14.000000000 +0800 +++ /home/admin/joehorn/php-adodb-ext/Makefile 2011-07-23 20:40:23.000000000 +0800 @@ -7,7 +7,7 @@ PORTNAME= adodb-ext PORTVERSION= 5.04 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= databases MASTER_SITES= http://phplens.com/lens/dl/ PKGNAMEPREFIX= php- @@ -29,7 +29,13 @@ PLIST_SUB= PHP_EXT_DIR=${PHP_EXT_DIR} USE_DOS2UNIX= yes +.include <bsd.port.pre.mk> + +.if ${PHP_VER} != "52" +EXTRA_PATCHES= ${PATCHDIR}/extra-patch-adodb.c +.endif + post-install: @${CAT} ${PKGMESSAGE} -.include <bsd.port.mk> +.include <bsd.port.post.mk>
for completeness attached is a patch.txt file. I tested this, and it fixes the issue! Thanks Joe! (silly me for staying on 5.2 :-) ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.secnap.com/products/spammertrap/ ______________________________________________________________________
gabor 2011-08-08 11:04:45 UTC FreeBSD ports repository Modified files: databases/php-adodb-ext Makefile Added files: databases/php-adodb-ext/files extra-patch-adodb.c Removed files: databases/php-adodb-ext/files patch-adodb.c Log: - Fix build for newer PHP versions by making PHP 5.2-specific patch optional PR: ports/159125 Submitted by: Michael Scheidell <scheidell@secnap.net> Approved by: Joe Horn <joehorn@gmail.com> (maintainer) Revision Changes Path 1.3 +7 -1 ports/databases/php-adodb-ext/Makefile 1.1 +28 -0 ports/databases/php-adodb-ext/files/extra-patch-adodb.c (new) 1.2 +0 -28 ports/databases/php-adodb-ext/files/patch-adodb.c (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!