Bug 159183 - [patch] sysutils/scanbuttond: protect user config files
Summary: [patch] sysutils/scanbuttond: protect user config files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 17:30 UTC by Warren Block
Modified: 2011-07-28 23:22 UTC (History)
0 users

See Also:


Attachments
file.diff (2.44 KB, patch)
2011-07-25 17:30 UTC, Warren Block
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Warren Block 2011-07-25 17:30:24 UTC
Reinstalling or upgrading sysutils/scanbuttond will overwrite user-modified config .sh files in /usr/local/etc/scanbuttond/.

This patch changes the port to work like other ports.  If there are user .sh files present, they are left alone.  If not present, sample files are installed.
The patch is based on sysutils/apcupsd, which seemed to be the right way to do it.

Fix: Apply patch.

Patch attached with submission follows:
How-To-Repeat: Modify /usr/local/etc/scanbuttond/buttonpressed.sh initscanner.sh.
Reinstall the port.  Notice the modified files have been replaced with sample files from the port.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-25 17:30:42 UTC
Maintainer of sysutils/scanbuttond,

Please note that PR ports/159183 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159183

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-25 17:30:46 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Daniel Thiele 2011-07-25 22:17:58 UTC
On 07/25/11 18:30, Edwin Groothuis wrote:
> Maintainer of sysutils/scanbuttond,
> 
> Please note that PR ports/159183 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159183
> 

The patch looks good. I approve it. Thanks!
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-07-25 23:40:36 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2011-07-26 23:33:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->zi

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-07-28 22:56:30 UTC
zi          2011-07-28 21:56:21 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/scanbuttond Makefile pkg-plist 
  Log:
  Do not overwrite user-edited config files in ETCDIR [1]
  Bump PORTREVISION
  Add LICENSE
  
  PR:             ports/159183
  Submitted by:   Warren Block <wblock@wonkity.com> [1]
  Approvd by:     tabthorpe (mentor), maintainer
  
  Revision  Changes    Path
  1.11      +21 -2     ports/sysutils/scanbuttond/Makefile
  1.2       +9 -3      ports/sysutils/scanbuttond/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Ryan Steinmetz freebsd_committer freebsd_triage 2011-07-28 23:22:49 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!