Bug 159739 - comms/minicom does not build with WITHOUT_NLS
Summary: comms/minicom does not build with WITHOUT_NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-13 14:30 UTC by Gordon Shumway
Modified: 2011-08-17 22:10 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Shumway 2011-08-13 14:30:10 UTC 
Building comms/minicom with WITHOUT_NLS=true in /etc/make.conf results in a failure:

Making all in src
cc -DHAVE_CONFIG_H -I. -I..  -I../lib -DCONFDIR=\"/usr/local/etc/minicom\"  -DLOCALEDIR=\"/usr/local/share/locale\"    -O2 -pipe -fno-omit-frame-pointer -fno-strict-aliasing -W -Wall -Wextra -std=gnu99 -MT minicom.o -MD -MP -MF .deps/minicom.Tpo -c -o minicom.o minicom.c
minicom.c:33:19: error: iconv.h: No such file or directory
minicom.c:869: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'iconv_rem2local'
minicom.c: In function 'init_iconv':
minicom.c:905: error: 'iconv_rem2local' undeclared (first use in this function)
minicom.c:905: error: (Each undeclared identifier is reported only once
minicom.c:905: error: for each function it appears in.)
minicom.c:905: warning: implicit declaration of function 'iconv_open'
minicom.c:906: error: 'iconv_t' undeclared (first use in this function)
minicom.c: In function 'do_iconv':
minicom.c:917: warning: implicit declaration of function 'iconv'
minicom.c:917: error: 'iconv_rem2local' undeclared (first use in this function)
minicom.c:919: warning: comparison between signed and unsigned
minicom.c: In function 'close_iconv':
minicom.c:934: warning: implicit declaration of function 'iconv_close'
minicom.c:934: error: 'iconv_rem2local' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/comms/minicom/work/minicom-2.5/src.
*** Error code 1

Stop in /usr/ports/comms/minicom/work/minicom-2.5.
*** Error code 1

Stop in /usr/ports/comms/minicom/work/minicom-2.5.
*** Error code 1

Stop in /usr/ports/comms/minicom.

How-To-Repeat: 1. echo WITHOUT_NLS=true >> /etc/make.conf
2. cd /usr/ports/comms/minicom && sudo make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-13 14:30:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->johans

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-08-17 22:05:08 UTC 
johans      2011-08-17 21:04:58 UTC

  FreeBSD ports repository

  Modified files:
    comms/minicom        Makefile 
  Log:
  Fix minicom build for WITHOUT_NLS (force libiconv dependency and linking)
  
  Reported by:    Gordon Shumway
  PR:             ports/159739
  
  Revision  Changes    Path
  1.56      +6 -3      ports/comms/minicom/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Johan van Selst freebsd_committer freebsd_triage 2011-08-17 22:05:12 UTC 
State Changed
From-To: open->closed

Fixed. Thanks for the report.