Bug 159910 - [patch] devel/php5-thrift build fix
Summary: [patch] devel/php5-thrift build fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-19 12:50 UTC by komarov
Modified: 2011-08-29 11:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.12 KB, patch)
2011-08-19 12:50 UTC, komarov
no flags Details | Diff
php5-thrift_upgrade.diff (1.35 KB, patch)
2011-08-19 13:42 UTC, Bakulin Ilya
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description komarov 2011-08-19 12:50:08 UTC
port don't build

Fix: use attached patch

Patch attached with submission follows:
How-To-Repeat: #cd /usr/ports/devel/php5-thrift && make install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-19 12:50:18 UTC
Maintainer of devel/php5-thrift,

Please note that PR ports/159910 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159910

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-19 12:50:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Bakulin Ilya 2011-08-19 13:42:58 UTC
Hi,
thanks for the patch, I'm glad that now an extra file is not needed.

I'd rather prefer to set PORTVERSION to 0.6.1, because it's the version of
upstream package (devel/thrift).

Please delete "files" directory when committing the port.
-- 
Regards,
Ilya Bakulin
http://kibab.com
xmpp://kibab612@jabber.ru
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-08-20 05:07:13 UTC
State Changed
From-To: feedback->open

maintainer has responded with updated patch.
Comment 5 Chris Rees freebsd_committer freebsd_triage 2011-08-20 10:43:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-08-29 11:22:06 UTC
crees       2011-08-29 10:21:58 UTC

  FreeBSD ports repository

  Modified files:
    devel/php5-thrift    Makefile 
  Removed files:
    devel/php5-thrift/files patch-php_thrift_protocol.cpp 
  Log:
  - Update to 0.6.1
  - While here, use tabs in variable assignments
  
  PR:             ports/159910
  Submitted by:   Valery Komarov <komarov@valerka.net>, Ilya Bakulin <webmaster@kibab.com> (maintainer)
  Approved by:    Ilya Bakulin <webmaster@kibab.com> (maintainer)
  
  Revision  Changes    Path
  1.2       +11 -9     ports/devel/php5-thrift/Makefile
  1.2       +0 -20     ports/devel/php5-thrift/files/patch-php_thrift_protocol.cpp (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2011-08-29 11:22:10 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!