Bug 160055 - [PATCH] games/anki: eliminate py-pysqlite2x dependency
Summary: [PATCH] games/anki: eliminate py-pysqlite2x dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 13:20 UTC by R.Mahmatkhanov
Modified: 2011-08-31 19:00 UTC (History)
0 users

See Also:


Attachments
file.diff (750 bytes, patch)
2011-08-24 13:20 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-24 13:20:09 UTC
- bump USE_PYTHON to 2.5+ (the point is to not depend on python24)
- since it now requires 2.5+ use databases/py-sqlite3 
  instead of databases/py-pysqlite2x
- while here use GOOGLE_CODE instead of ${MASTER_SITE_GOOGLE_CODE}
- bump port revision because of dependencies change

I checked the code. They use this pattern when using sqlite binding:

 18 try:
 19     from pysqlite2 import dbapi2 as sqlite
 20 except ImportError:
 21     try:
 22         from sqlite3 import dbapi2 as sqlite
 23     except:
 24         raise Exception("Please install pysqlite2 or python2.5")

So nothing will be broken with sqlite3.

Fix: Patch attached with submission follows:
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2011-08-30 00:36:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-08-31 18:52:45 UTC
eadler      2011-08-31 17:52:32 UTC

  FreeBSD ports repository

  Modified files:
    games/anki           Makefile.inc 
    multimedia/pyjama    Makefile 
  Log:
  - eliminate py-pysqlite2x dependency from games/anki [0]
  - eliminate py-pysqlite2x dependency from multimedia/pyjama [1]
  - add gstreamer-plugins-gnomevfs as a dep to multimedias/pyjama [2]
  
  PR:             ports/160055 [0], ports/160065 [1,2]
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru> [0,1], Kjell Tore Ullavik <ktullavik@gmail.com> (maintainer) [2]
  Approved by:    bapt (mentor), Kjell Tore Ullavik <ktullavik@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.12      +3 -3      ports/games/anki/Makefile.inc
  1.7       +3 -3      ports/multimedia/pyjama/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2011-08-31 18:57:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!