Bug 160072 - [UPDATE] security/umit: update to 1.0
Summary: [UPDATE] security/umit: update to 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 19:40 UTC by R.Mahmatkhanov
Modified: 2011-09-23 20:02 UTC (History)
0 users

See Also:


Attachments
file.diff (42.66 KB, patch)
2011-08-24 19:40 UTC, R.Mahmatkhanov
no flags Details | Diff
umit-1.0.diff.txt (42.55 KB, text/plain)
2011-09-22 16:24 UTC, R.Mahmatkhanov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-24 19:40:03 UTC
- update to 1.0
- remove stale mastersite in fix sourceforge download path
- bump USE_PYTHON to 2.5+ (the point is to not depend on python24)
- since it now requires 2.5+ use databases/py-sqlite3 instead of 
  databases/py-pysqlite2x
- set WITHOUT_PSYCO if python 2.6+ since py-psyco didn't work with it
- remove handmade do-build and do-install targets, use USE_PYDISTUTILS instead
- add INSTALLS_ICONS, remove INSTALLS_EGGINFO (pydistutils will handle it)
- update WWW

I checked the source. They use this pattern to deal with sqlite:
"""

 34 try:
 35     from pysqlite2 import dbapi2 as sqlite
 36     from pysqlite2.dbapi2 import OperationalError
 37 except ImportError:
 38     try:
 39         # In case this script is being running under python2.5 with sqlite3
 40         import sqlite3 as sqlite
 41     except ImportError:
 42         raise ImportError(_("""No module named pysqlite2 or sqlite3.
 43             Please install pysqlite2 or sqlite3."""))
 44     from sqlite3 import OperationalError
"""
So nothing will be broken with sqlite3.

tindrbuild logs: 
7.4: http://happy-nation.by.ru/ports/tb/7.4/py27-umit-1.0.log
8.2: http://happy-nation.by.ru/ports/tb/8.2/py27-umit-1.0.log

Runtime succefully tested too - very nice app indeed. 
I'd also remove PKGNAMEPREFIX, since it is not library, but standalone application. But it's for maintainer/committer to decide.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-24 19:40:14 UTC
Maintainer of security/umit,

Please note that PR ports/160072 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160072

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-24 19:40:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2011-09-01 14:34:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2011-09-22 03:49:13 UTC
State Changed
From-To: feedback->analyzed

patch fails to apply cleanly
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2011-09-22 03:49:23 UTC
State Changed
From-To: analyzed->feedback

patch fails to apply cleanly
Comment 6 R.Mahmatkhanov 2011-09-22 16:24:04 UTC
Here is updated patch, that counts yesterday's commit, that mark it broken.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-09-23 19:51:48 UTC
eadler      2011-09-23 18:51:40 UTC

  FreeBSD ports repository

  Modified files:
    security/umit        Makefile distinfo pkg-descr pkg-plist 
  Log:
  - update to version 1.0
  - remove stale mastersite
  - bump USE_PYTHON to 2.5+
  - use databases/py-sqlite3 instead of databases/py-pysqlite2x
  - set WITHOUT_PSYCO if python 2.6+ since py-psyco doesn't work with it
  - switch from custom do-build and do-install targets to USE_PYDISTUTILS
  - add INSTALLS_ICONS, remove INSTALLS_EGGINFO (pydistutils will handle it)
  - update WWW
  - update pkg-plist
  - patch out documentation build
  
  PR:             ports/160072
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    maintainer timeout (30 days)
  Approved by:    bapt (mentor)
  
  Revision  Changes    Path
  1.13      +9 -16     ports/security/umit/Makefile
  1.3       +2 -2      ports/security/umit/distinfo
  1.2       +1 -1      ports/security/umit/pkg-descr
  1.3       +674 -125  ports/security/umit/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Eitan Adler freebsd_committer freebsd_triage 2011-09-23 20:02:25 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!