- update to 0.15.9 - grab maintainership - bump USE_PYTHON to 2.5+, use py-sqlite3 instead of py-pysqlite2x - add license - add manpage tinderbuild logs: 7.4: http://happy-nation.by.ru/ports/tb/7.4/gourmet-0.15.9.log 8.2: http://happy-nation.by.ru/ports/tb/8.2/gourmet-0.15.9.log Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->beech I'll take it
This port depends on postgresql84-client which does not link on 9.1beta. Please find a solution or mark broken on 9.x, otherwise it will fail on the tinderbox. Beech -- --------------------------------------------------------------------------------------- Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org /"\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.2R/announce.html ---------------------------------------------------------------------------------------
Beech Rintoul wrote on 25.08.2011 12:26: > This port depends on postgresql84-client which does not link on 9.1beta. > Please find a solution or mark broken on 9.x, otherwise it will fail on the > tinderbox. > > Beech Sorry i didn't understand you. gourmet doesn't depend on postgresql, but sqlobject do (not by default). 84 - is a default postgresql version in the tree. So i didnt see the problem. Whould you mind to clarify what software configuration do you use, maybe failing buildlogs etc. Thanks. -- Regards, Ruslan Tinderboxing kills... the drives.
Ruslan Mahmatkhanov wrote on 25.08.2011 12:45: > Beech Rintoul wrote on 25.08.2011 12:26: >> This port depends on postgresql84-client which does not link on 9.1beta. >> Please find a solution or mark broken on 9.x, otherwise it will fail >> on the >> tinderbox. >> >> Beech > > Sorry i didn't understand you. > gourmet doesn't depend on postgresql, but sqlobject do (not by default). ^^^^^^^^^ Oops, i mean py-sqlaclhemy there and it's indeed depends on postgresql-client by default. But isn't it right that if py-sqlalchemy fails to compile with 9.1beta, then this is the problem of py-sqlalchemy port, not gourmet, so there is nothing to fix? > 84 - is a default postgresql version in the tree. So i didnt see the > problem. > > Whould you mind to clarify what software configuration do you use, maybe > failing buildlogs etc. Thanks. > -- Regards, Ruslan Tinderboxing kills... the drives.
Ruslan Mahmatkhanov wrote on 25.08.2011 12:53: > Ruslan Mahmatkhanov wrote on 25.08.2011 12:45: >> Beech Rintoul wrote on 25.08.2011 12:26: >>> This port depends on postgresql84-client which does not link on 9.1beta. >>> Please find a solution or mark broken on 9.x, otherwise it will fail >>> on the >>> tinderbox. >>> >>> Beech Going further databases/py-sqlaclhemy doesn't depend on postgresql84-client directly, but it depend databases/py-psycopg2. psycopg2 depends on postgresql-client but not in versioned manner - just USE_PGSQL=yes, so it picks default postgresql version and build with it. If one use non-default postgresql version, he should define this in his /etc/make.conf so all the ports will pick this version and all will be link jusr fine. As far i understand you have 9.1beta installed but WITH_PGSQL_VER=91 is not defined in your /etc/make.conf. -- Regards, Ruslan Tinderboxing kills... the drives.
On Thursday 25 August 2011 01:02:25 Ruslan Mahmatkhanov wrote: > Ruslan Mahmatkhanov wrote on 25.08.2011 12:53: > > Ruslan Mahmatkhanov wrote on 25.08.2011 12:45: > >> Beech Rintoul wrote on 25.08.2011 12:26: > >>> This port depends on postgresql84-client which does not link on > >>> 9.1beta. Please find a solution or mark broken on 9.x, otherwise it > >>> will fail on the > >>> tinderbox. > >>> > >>> Beech > > Going further databases/py-sqlaclhemy doesn't depend on > postgresql84-client directly, but it depend databases/py-psycopg2. > psycopg2 depends on postgresql-client but not in versioned manner - just > USE_PGSQL=yes, > so it picks default postgresql version and build with it. > > If one use non-default postgresql version, he should define this in his > /etc/make.conf so all the ports will pick this version and all will be > link jusr fine. > > As far i understand you have 9.1beta installed but WITH_PGSQL_VER=91 is > not defined in your /etc/make.conf. Until this is fixed we should probably add: if ${OSVERSION} >= 900000 BROKEN= message of your choice. .endif It failed on my tinderbox because of that dependency. I can't commit this knowing it will fail on pointyhat. So, the basic choices are 1. mark this broken until postgresql is fixed or 2. Hold off on this commit until it's fixed. There are no tinderbox logs because postgre itself is marked broken so the tindy didn't build anything, just failed gourmet and a couple of other dependencies as you stated. Let me know how you want to proceed. Beech -- --------------------------------------------------------------------------------------- Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org /"\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.2R/announce.html ---------------------------------------------------------------------------------------
Beech Rintoul wrote on 25.08.2011 13:16: > On Thursday 25 August 2011 01:02:25 Ruslan Mahmatkhanov wrote: >> Ruslan Mahmatkhanov wrote on 25.08.2011 12:53: >>> Ruslan Mahmatkhanov wrote on 25.08.2011 12:45: >>>> Beech Rintoul wrote on 25.08.2011 12:26: >>>>> This port depends on postgresql84-client which does not link on >>>>> 9.1beta. Please find a solution or mark broken on 9.x, otherwise it >>>>> will fail on the >>>>> tinderbox. >>>>> >>>>> Beech >> >> Going further databases/py-sqlaclhemy doesn't depend on >> postgresql84-client directly, but it depend databases/py-psycopg2. >> psycopg2 depends on postgresql-client but not in versioned manner - just >> USE_PGSQL=yes, >> so it picks default postgresql version and build with it. >> >> If one use non-default postgresql version, he should define this in his >> /etc/make.conf so all the ports will pick this version and all will be >> link jusr fine. >> >> As far i understand you have 9.1beta installed but WITH_PGSQL_VER=91 is >> not defined in your /etc/make.conf. > > Until this is fixed we should probably add: > Sorry, Beech, but i'm really don't understand what should be fixed. postgresql 9.1beta1 is not default in the tree, so i don't understand how it may break tinderbox build, without user interference. It builds fine on 7.x, 8.x, 9.0-beta1 with default settings. > if ${OSVERSION}>= 900000 > BROKEN= message of your choice. > .endif I'm using 9.0-beta1 and gourmet is builds and works fine for me, so this message is not true. Maybe you can tell me how to reproduce this so we can think more proper condition for BROKEN? > It failed on my tinderbox because of that dependency. I can't commit this > knowing it will fail on pointyhat. So, the basic choices are 1. mark this > broken until postgresql is fixed or 2. Hold off on this commit until it's > fixed. By the way, there is two my pr's that unbreak postgresql90-client and postgresql91-client, also as postgresql-plpython on all postgresql and FreeBSD version, with both threaded and threadless python. Maybe you can handle them first so we will not be forced to put false sentencences into gourmet Makefile? http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159844 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159843 > > There are no tinderbox logs because postgre itself is marked broken so the > tindy didn't build anything, just failed gourmet and a couple of other > dependencies as you stated. Why to not mark broken databases/py-sqlalchemy and databases/py-psycopg2 for the same reason? I just can't understand what is so special about gourmet. > > Let me know how you want to proceed. > > Beech Please feel free to do what you you believe is correct for this case. But it just think that marking it broken on FreeBSD 9.x is wrong, since it work for me here and will work with default PGSQL_VER as in bsd.database.mk. -- Regards, Ruslan Tinderboxing kills... the drives.
Beech Rintoul wrote on 25.08.2011 12:26: > This port depends on postgresql84-client which does not link on 9.1beta. OMG, am i right that you actually mean FreeBSD 9.0-BETA1 here and not PostgreSQL 9.1beta1? :) > Please find a solution or mark broken on 9.x, otherwise it will fail on the > tinderbox. > > Beech -- Regards, Ruslan Tinderboxing kills... the drives.
Beech Rintoul wrote on 25.08.2011 13:16: > On Thursday 25 August 2011 01:02:25 Ruslan Mahmatkhanov wrote: >> Ruslan Mahmatkhanov wrote on 25.08.2011 12:53: >>> Ruslan Mahmatkhanov wrote on 25.08.2011 12:45: >>>> Beech Rintoul wrote on 25.08.2011 12:26: >>>>> This port depends on postgresql84-client which does not link on >>>>> 9.1beta. Please find a solution or mark broken on 9.x, otherwise it >>>>> will fail on the >>>>> tinderbox. >>>>> >>>>> Beech >> >> Going further databases/py-sqlaclhemy doesn't depend on >> postgresql84-client directly, but it depend databases/py-psycopg2. >> psycopg2 depends on postgresql-client but not in versioned manner - just >> USE_PGSQL=yes, >> so it picks default postgresql version and build with it. >> >> If one use non-default postgresql version, he should define this in his >> /etc/make.conf so all the ports will pick this version and all will be >> link jusr fine. >> >> As far i understand you have 9.1beta installed but WITH_PGSQL_VER=91 is >> not defined in your /etc/make.conf. > > Until this is fixed we should probably add: > > if ${OSVERSION}>= 900000 > BROKEN= message of your choice. > .endif > > It failed on my tinderbox because of that dependency. I can't commit this > knowing it will fail on pointyhat. So, the basic choices are 1. mark this > broken until postgresql is fixed or 2. Hold off on this commit until it's > fixed. > > There are no tinderbox logs because postgre itself is marked broken so the > tindy didn't build anything, just failed gourmet and a couple of other > dependencies as you stated. I now understand what you mean. You are talking about this: http://www.freebsd.org/cgi/cvsweb.cgi/ports/databases/postgresql84-server/Makefile.diff?r1=1.223;r2=1.224 postgresql84-server is indeed broken with "does not link on FreeBSD 9.x" in case of WITH_GSSAPI=on. But it's OFF by default, so it just can't fail in tinderbox with default ports tree settings. It will fails only if user has WITH_GSSAPI=on definded. May be Pav (cc'ed) can clarify this, since he is author of this commit. -- Regards, Ruslan Tinderboxing kills... the drives.
beech 2011-09-02 20:29:34 UTC FreeBSD ports repository Modified files: deskutils/gourmet Makefile distinfo pkg-plist Log: - update to 0.15.9 - grab maintainership - bump USE_PYTHON to 2.5+, use py-sqlite3 instead of py-pysqlite2x - add license - add manpage PR: ports/160165 Submitted by: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Revision Changes Path 1.35 +30 -17 ports/deskutils/gourmet/Makefile 1.16 +2 -2 ports/deskutils/gourmet/distinfo 1.17 +527 -193 ports/deskutils/gourmet/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks!