Bug 160290 - [patch] net-mgmt/zenoss: add bsd.zenoss.mk for zenpacks
Summary: [patch] net-mgmt/zenoss: add bsd.zenoss.mk for zenpacks
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 19:20 UTC by Jason Helfman
Modified: 2011-09-13 01:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.92 KB, patch)
2011-08-29 19:20 UTC, Jason Helfman
no flags Details | Diff
bsd.zenoss.mk.diff (294 bytes, patch)
2011-09-13 00:51 UTC, Anthony Garcia
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman 2011-08-29 19:20:07 UTC
There are lots of zenpack PR's:
http://www.freebsd.org/cgi/query-pr-summary.cgi?category=&severity=&priority=&class=&state=&sort=none&text=zenpack&responsible=&multitext=&originator=&release=

Adding this mk into zenoss, will make it much easier to submit, maintain and update a zenpack.
If this file is committed, then we can work on updating all of the submitted zenpacks to use it.
One zenpack has been tested, at this point, and works as intended.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-29 19:20:15 UTC
Maintainer of net-mgmt/zenoss,

Please note that PR ports/160290 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160290

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-29 19:20:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Phil Phillips 2011-08-29 19:36:30 UTC
Looks good to me.

-Phil
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-08-29 21:33:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 5 Chris Rees 2011-08-31 12:18:48 UTC
Hey guys,

In reference to [1], I'd like to add bsd.zenoss.mk to ports/Mk.

In addition, if you approve of this, I'll also create a USE_ZENOSS
hook instead of the hideous .include "${PORTSDIR}/Mk/bsd.zenoss.mk",
rather like for drupal [2].

The proposed bsd.zenoss.mk for Mk/ (with 4-column tabs to fit in) is
at [3], and diff to submitted bsd.zenoss.mk is at [4].

Is that OK?

[1] http://www.mail-archive.com/freebsd-ports@freebsd.org/msg34635.html

[2] http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/159288

[3] http://www.bayofrum.net/~crees/patches/bsd.zenoss.mk.diff

[4] http://www.bayofrum.net/~crees/patches/bsd.zenoss.mk-diff.diff

Chris

--=20
Chris Rees =A0 =A0 =A0 =A0 =A0| FreeBSD Developer
crees@FreeBSD.org =A0 | http://people.freebsd.org/~crees
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-09-01 17:08:10 UTC
crees       2011-09-01 16:08:01 UTC

  FreeBSD ports repository

  Added files:
    Mk                   bsd.zenoss.mk 
  Log:
  Add bsd.zenoss.mk for support of zenpacks.
  
  PR:             ports/160290
  Submitted by:   Jason Helfman <jhelfman@experts-exchange.com>
  
  Revision  Changes    Path
  1.1       +72 -0     ports/Mk/bsd.zenoss.mk (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2011-09-01 17:08:11 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!
Comment 8 Anthony Garcia 2011-09-13 00:51:21 UTC
Remove USE_ZIP for compatibility with ZenPacks  that don't use it.

-- 
~Anthony Garcia