Bug 160321 - [MAINTAINER] graphics/gimp-gmic-plugin: update to 1.5.0.1
Summary: [MAINTAINER] graphics/gimp-gmic-plugin: update to 1.5.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 21:40 UTC by R.Mahmatkhanov
Modified: 2011-09-04 17:00 UTC (History)
0 users

See Also:

Attachments
file.diff (7.17 KB, patch)
2011-08-30 21:40 UTC, R.Mahmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-08-30 21:40:09 UTC 
- update to 1.5.0.1
- disable OpenCV for now to unbreak the port.
  сonsequences of that should be minor, since OpenCV used _only_ in gmic command
  line utility (the actual plugin is not affected) and it used _only_ for
  accessing webcams.

Fix: Patch attached with submission follows:
Comment 1 Chris Rees freebsd_committer freebsd_triage 2011-09-03 09:40:29 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->crees

Yet ANOTHER fix from Ruslan....
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-09-03 09:55:44 UTC 
Hm, for future reference you can't patch a Makefile generated from a 
Makefile.in by a configure script-- you must patch the Makefile.in -- 
Makefile doesn't actually exist on extract;

[crees@zeus]~/workspace/ports/pcvs/gimp-gmic-plugin% ls 
work/gmic-1.5.0.1/Makefile*
work/gmic-1.5.0.1/Makefile.in

I'll fix this.

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-09-03 09:56:57 UTC 
D'oh, please ignore the previous email, you weren't patching 
${WRKSRC}/Makefile at all, it's ${WRKSRC}/src/Makefile...

Sending to Tinderbox now!

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 4 R.Mahmatkhanov 2011-09-03 09:59:30 UTC 
Chris Rees wrote on 03.09.2011 12:55:
> Hm, for future reference you can't patch a Makefile generated from a
> Makefile.in by a configure script-- you must patch the Makefile.in --
> Makefile doesn't actually exist on extract;

Ok, i already know this. But this is not true for this port. Makefile in 
gmic doesn't generated by configure run, as you can check yourself.
For that reason we already have patch in files/ that patches Makefile, 
not Makefile.in.

>
> [crees@zeus]~/workspace/ports/pcvs/gimp-gmic-plugin% ls
> work/gmic-1.5.0.1/Makefile*
> work/gmic-1.5.0.1/Makefile.in
>
> I'll fix this.
>
> Chris
>


-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 5 R.Mahmatkhanov 2011-09-03 10:01:40 UTC 
Chris Rees wrote on 03.09.2011 12:55:
> Hm, for future reference you can't patch a Makefile generated from a
> Makefile.in by a configure script-- you must patch the Makefile.in --
> Makefile doesn't actually exist on extract;

Hmm, sorry i'm dumb, you are right. But to fix the build we don't care 
about Makefile in ${WRKSRC}, the only one we care is in ${WRKSRC}/src

>
> [crees@zeus]~/workspace/ports/pcvs/gimp-gmic-plugin% ls
> work/gmic-1.5.0.1/Makefile*
> work/gmic-1.5.0.1/Makefile.in
>
> I'll fix this.
>
> Chris
>


-- 
Regards,
Ruslan

Tinderboxing kills... the drives.
Comment 6 Chris Rees freebsd_committer freebsd_triage 2011-09-04 16:59:52 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-09-04 16:59:52 UTC 
crees       2011-09-04 15:59:39 UTC

  FreeBSD ports repository

  Modified files:
    graphics/gimp-gmic-plugin Makefile distinfo 
    graphics/gimp-gmic-plugin/files patch-src_Makefile 
  Added files:
    graphics/gimp-gmic-plugin/files patch-configure 
  Log:
  - Update to 1.5.0.1
  - Disable OpenCV for now to unbreak the port
  
  PR:             ports/160321
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru> (maintainer)
  
  Revision  Changes    Path
  1.10      +9 -11     ports/graphics/gimp-gmic-plugin/Makefile
  1.7       +2 -2      ports/graphics/gimp-gmic-plugin/distinfo
  1.3       +113 -0    ports/graphics/gimp-gmic-plugin/files/patch-configure (new)
  1.3       +23 -7     ports/graphics/gimp-gmic-plugin/files/patch-src_Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"