Bug 160355 - Update sysutils/cfengine3 port to version 3.2.0
Summary: Update sysutils/cfengine3 port to version 3.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 13:20 UTC by wojciech.kochanowski
Modified: 2011-09-20 06:10 UTC (History)
0 users

See Also:


Attachments
cf3.port.shar.txt (14.85 KB, text/plain; charset=US-ASCII)
2011-09-02 09:12 UTC, Wojtek Kochanowski
no flags Details
cf3.port.shar.txt (14.85 KB, text/plain; charset=US-ASCII)
2011-09-02 09:15 UTC, wojciech.kochanowski
no flags Details
cfengine-3.2.0.patch (17.94 KB, patch)
2011-09-11 11:04 UTC, Marin Atanasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description wojciech.kochanowski 2011-09-01 13:20:07 UTC
	I've just a little rewrote a cfengine3 port to build version 3.2.0 (latest stable).
	Also, rc variables can't have a dash in their names and I believe you know that. 
	I renamed them from cf-execd and cf-serverd to cf_execd and cf_serverd, because they won't start as: service cf-execd start.

Fix: 

I've attached diff and a shar archive so you can build and test.
	You should manually download a cfengine3 sources from http://cfengine.com/source_code and put them into your $DISTFILES. 
	I set $MASTER_SITE to cfengine's homepage, but it works partly, because fetch download archive as php file, but doesn't rename it to cfengine-3-2.0.tar.gz.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2011-09-02 08:43:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cy

Fix synopsis and assign.
Comment 2 Cy Schubert 2011-09-20 05:41:42 UTC
Can you send me a diff file instead?


-- 
Cheers,
Cy Schubert <Cy.Schubert@komquats.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org


In message <CAJ-UWtS+tBUXRWe0syFR_GbmAmc2kWkPfH5-wjWG75HBqNFwOw@mail.gmail.c
om>
, Marin Atanasov Nikolov writes:
> --20cf307ca1e807ecb504acaf6c0a
> Content-Type: text/plain; charset=ISO-8859-1
> 
> Hello again,
> 
> Crap, I just saw that there is USE_RC_SUBR being used.
> 
> Which should not be the case, please fix this one as well - ports/155495
> fixes the issue in the rc scripts, but the Makefile itself.
> 
> regards,
> Marin
> On Sun, Sep 11, 2011 at 1:04 PM, Marin Atanasov Nikolov <dnaeon@gmail.com>wro
> te:
> 
> > Hello,
> >
> > I've just noticed that there is a PR pending for Cfengine3 to be updated to
> > version 3.2.0.
> >
> > I'm sending you a patch that I've tested and works fine. It also fixes the
> > new way distfiles are fetched from the Cfengine3 homepage.
> >
> > Please note that dashes in the rc scripts were fixed in a PR some time ago,
> > so there is no need to re-apply this - ports/155495
> >
> > I've tested the patch on a tinderbox of my own and it builds fine.
> >
> > The new Cfengine 3.2.0 also comes with a new feature for FreeBSD - it
> > excludes jail's interfaces on a FreeBSD host thus not messing up the classe
> s
> > on a FreeBSD jail host system. [1]
> >
> > The feature currently excludes jail's interfaces for jails with only 1
> > assigned IP addresses and does not work when your jails have multiple IP
> > addresses. There is a PR logged for this one as well, so anyone wishing to
> > help out with that is also welcome. [2]
> >
> > Regards,
> > Marin
> >
> > [1] https://cfengine.com/bugtracker/view.php?id=639
> > [2] https://cfengine.com/bugtracker/view.php?id=741
> >
> > --
> > Marin Atanasov Nikolov
> >
> > dnaeon AT gmail DOT com
> > daemon AT unix-heaven DOT org
> > http://www.unix-heaven.org/
> >
> 
> 
> 
> -- 
> Marin Atanasov Nikolov
> 
> dnaeon AT gmail DOT com
> daemon AT unix-heaven DOT org
> http://www.unix-heaven.org/
> 
> --20cf307ca1e807ecb504acaf6c0a
> Content-Type: text/html; charset=ISO-8859-1
> Content-Transfer-Encoding: quoted-printable
> 
> <br>Hello again,<div><br></div><div>Crap, I just saw that there is=A0<span =
> class=3D"Apple-style-span" style=3D"font-family: &#39;Courier New&#39;, Cou=
> rier, monospace; font-size: 11px; white-space: pre; -webkit-border-horizont=
> al-spacing: 1px; -webkit-border-vertical-spacing: 1px; ">USE_RC_SUBR being =
> used.</span></div>
> <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie=
> r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh=
> ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert=
> ical-spacing: 1px;"><br>
> </span></font></div><div><font class=3D"Apple-style-span" face=3D"&#39;Cour=
> ier New&#39;, Courier, monospace"><span class=3D"Apple-style-span" style=3D=
> "font-size: 11px; white-space: pre; -webkit-border-horizontal-spacing: 1px;=
>  -webkit-border-vertical-spacing: 1px;">Which should not be the case, pleas=
> e fix this one as well - ports/155495 fixes the issue in the rc scripts, bu=
> t the Makefile itself.</span></font></div>
> <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie=
> r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh=
> ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert=
> ical-spacing: 1px;"><br>
> </span></font></div><div><font class=3D"Apple-style-span" face=3D"&#39;Cour=
> ier New&#39;, Courier, monospace"><span class=3D"Apple-style-span" style=3D=
> "font-size: 11px; white-space: pre; -webkit-border-horizontal-spacing: 1px;=
>  -webkit-border-vertical-spacing: 1px;">regards,</span></font></div>
> <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie=
> r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh=
> ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert=
> ical-spacing: 1px;">Marin</span></font></div>
> <div><meta http-equiv=3D"content-type" content=3D"text/html; charset=3Dutf-=
> 8"><div class=3D"gmail_quote">On Sun, Sep 11, 2011 at 1:04 PM, Marin Atanas=
> ov Nikolov <span dir=3D"ltr">&lt;<a href=3D"mailto:dnaeon@gmail.com">dnaeon=
> @gmail.com</a>&gt;</span> wrote:<br>
> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
> x #ccc solid;padding-left:1ex;"><div>Hello,</div><div><br></div><div>I&#39;=
> ve just noticed that there is a PR pending for Cfengine3 to be updated to v=
> ersion 3.2.0.</div>
> <div><br></div><div>I&#39;m sending you a patch that I&#39;ve tested and wo=
> rks fine. It also fixes the new way distfiles are fetched from the Cfengine=
> 3 homepage.</div>
> <div><br></div><div>Please note that dashes in the rc scripts were fixed in=
>  a PR some time ago, so there is no need to re-apply this -=A0ports/155495<=
> /div><div><br></div><div>I&#39;ve tested the patch on a tinderbox of my own=
>  and it builds fine.</div>
> 
> <div><br></div><div>The new Cfengine 3.2.0 also comes with a new feature fo=
> r FreeBSD - it excludes jail&#39;s interfaces on a FreeBSD host thus not me=
> ssing up the classes on a FreeBSD jail host system. [1]</div><div><br>
> </div>
> <div>The feature currently excludes jail&#39;s interfaces for jails with on=
> ly 1 assigned IP addresses and does not work when your jails have multiple =
> IP addresses. There is a PR logged for this one as well, so anyone wishing =
> to help out with that is also welcome. [2]</div>
> 
> <div><br></div><div>Regards,</div><div>Marin</div><div><br></div><div>[1]=
> =A0<a href=3D"https://cfengine.com/bugtracker/view.php?id=3D639" target=3D"=
> _blank">https://cfengine.com/bugtracker/view.php?id=3D639</a></div><div>[2]=
> =A0<a href=3D"https://cfengine.com/bugtracker/view.php?id=3D741" target=3D"=
> _blank">https://cfengine.com/bugtracker/view.php?id=3D741</a></div>
> 
> <div><br></div><font color=3D"#888888">-- <br>Marin Atanasov Nikolov<br><br=
> >dnaeon AT gmail DOT com<br>daemon AT unix-heaven DOT org<br>
> <a href=3D"http://www.unix-heaven.org/" target=3D"_blank">http://www.unix-h=
> eaven.org/</a><br>
> </font></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>Marin=
>  Atanasov Nikolov<br><br>dnaeon AT gmail DOT com<br>daemon AT unix-heaven D=
> OT org<br><a href=3D"http://www.unix-heaven.org/" target=3D"_blank">http://=
> www.unix-heaven.org/</a><br>
> 
> </div>
> 
> --20cf307ca1e807ecb504acaf6c0a--
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2011-09-20 05:42:07 UTC
State Changed
From-To: open->analyzed

Please send a Berkeley unified diff. Thanks.
Comment 4 Cy Schubert 2011-09-20 05:55:18 UTC
Found it. Uudeview failed to extract them properly. Will update to 3.2.1 
instead.


-- 
Cheers,
Cy Schubert <Cy.Schubert@komquats.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org


In message <201109200441.p8K4fg92065482@cwsys.cwsent.com>, Cy Schubert 
writes:
> Can you send me a diff file instead?
> 
> 
> -- 
> Cheers,
> Cy Schubert <Cy.Schubert@komquats.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
> 
> 
> In message <CAJ-UWtS+tBUXRWe0syFR_GbmAmc2kWkPfH5-wjWG75HBqNFwOw@mail.gmail.c
> om>
> , Marin Atanasov Nikolov writes:
> > --20cf307ca1e807ecb504acaf6c0a
> > Content-Type: text/plain; charset=ISO-8859-1
> > 
> > Hello again,
> > 
> > Crap, I just saw that there is USE_RC_SUBR being used.
> > 
> > Which should not be the case, please fix this one as well - ports/155495
> > fixes the issue in the rc scripts, but the Makefile itself.
> > 
> > regards,
> > Marin
> > On Sun, Sep 11, 2011 at 1:04 PM, Marin Atanasov Nikolov <dnaeon@gmail.com>w
> ro
> > te:
> > 
> > > Hello,
> > >
> > > I've just noticed that there is a PR pending for Cfengine3 to be updated 
> to
> > > version 3.2.0.
> > >
> > > I'm sending you a patch that I've tested and works fine. It also fixes th
> e
> > > new way distfiles are fetched from the Cfengine3 homepage.
> > >
> > > Please note that dashes in the rc scripts were fixed in a PR some time ag
> o,
> > > so there is no need to re-apply this - ports/155495
> > >
> > > I've tested the patch on a tinderbox of my own and it builds fine.
> > >
> > > The new Cfengine 3.2.0 also comes with a new feature for FreeBSD - it
> > > excludes jail's interfaces on a FreeBSD host thus not messing up the clas
> se
> > s
> > > on a FreeBSD jail host system. [1]
> > >
> > > The feature currently excludes jail's interfaces for jails with only 1
> > > assigned IP addresses and does not work when your jails have multiple IP
> > > addresses. There is a PR logged for this one as well, so anyone wishing t
> o
> > > help out with that is also welcome. [2]
> > >
> > > Regards,
> > > Marin
> > >
> > > [1] https://cfengine.com/bugtracker/view.php?id=639
> > > [2] https://cfengine.com/bugtracker/view.php?id=741
> > >
> > > --
> > > Marin Atanasov Nikolov
> > >
> > > dnaeon AT gmail DOT com
> > > daemon AT unix-heaven DOT org
> > > http://www.unix-heaven.org/
> > >
> > 
> > 
> > 
> > -- 
> > Marin Atanasov Nikolov
> > 
> > dnaeon AT gmail DOT com
> > daemon AT unix-heaven DOT org
> > http://www.unix-heaven.org/
> > 
> > --20cf307ca1e807ecb504acaf6c0a
> > Content-Type: text/html; charset=ISO-8859-1
> > Content-Transfer-Encoding: quoted-printable
> > 
> > <br>Hello again,<div><br></div><div>Crap, I just saw that there is=A0<span 
> =
> > class=3D"Apple-style-span" style=3D"font-family: &#39;Courier New&#39;, Cou
> =
> > rier, monospace; font-size: 11px; white-space: pre; -webkit-border-horizont
> =
> > al-spacing: 1px; -webkit-border-vertical-spacing: 1px; ">USE_RC_SUBR being 
> =
> > used.</span></div>
> > <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie
> =
> > r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh
> =
> > ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert
> =
> > ical-spacing: 1px;"><br>
> > </span></font></div><div><font class=3D"Apple-style-span" face=3D"&#39;Cour
> =
> > ier New&#39;, Courier, monospace"><span class=3D"Apple-style-span" style=3D
> =
> > "font-size: 11px; white-space: pre; -webkit-border-horizontal-spacing: 1px;
> =
> >  -webkit-border-vertical-spacing: 1px;">Which should not be the case, pleas
> =
> > e fix this one as well - ports/155495 fixes the issue in the rc scripts, bu
> =
> > t the Makefile itself.</span></font></div>
> > <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie
> =
> > r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh
> =
> > ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert
> =
> > ical-spacing: 1px;"><br>
> > </span></font></div><div><font class=3D"Apple-style-span" face=3D"&#39;Cour
> =
> > ier New&#39;, Courier, monospace"><span class=3D"Apple-style-span" style=3D
> =
> > "font-size: 11px; white-space: pre; -webkit-border-horizontal-spacing: 1px;
> =
> >  -webkit-border-vertical-spacing: 1px;">regards,</span></font></div>
> > <div><font class=3D"Apple-style-span" face=3D"&#39;Courier New&#39;, Courie
> =
> > r, monospace"><span class=3D"Apple-style-span" style=3D"font-size: 11px; wh
> =
> > ite-space: pre; -webkit-border-horizontal-spacing: 1px; -webkit-border-vert
> =
> > ical-spacing: 1px;">Marin</span></font></div>
> > <div><meta http-equiv=3D"content-type" content=3D"text/html; charset=3Dutf-
> =
> > 8"><div class=3D"gmail_quote">On Sun, Sep 11, 2011 at 1:04 PM, Marin Atanas
> =
> > ov Nikolov <span dir=3D"ltr">&lt;<a href=3D"mailto:dnaeon@gmail.com">dnaeon
> =
> > @gmail.com</a>&gt;</span> wrote:<br>
> > <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p
> =
> > x #ccc solid;padding-left:1ex;"><div>Hello,</div><div><br></div><div>I&#39;
> =
> > ve just noticed that there is a PR pending for Cfengine3 to be updated to v
> =
> > ersion 3.2.0.</div>
> > <div><br></div><div>I&#39;m sending you a patch that I&#39;ve tested and wo
> =
> > rks fine. It also fixes the new way distfiles are fetched from the Cfengine
> =
> > 3 homepage.</div>
> > <div><br></div><div>Please note that dashes in the rc scripts were fixed in
> =
> >  a PR some time ago, so there is no need to re-apply this -=A0ports/155495<
> =
> > /div><div><br></div><div>I&#39;ve tested the patch on a tinderbox of my own
> =
> >  and it builds fine.</div>
> > 
> > <div><br></div><div>The new Cfengine 3.2.0 also comes with a new feature fo
> =
> > r FreeBSD - it excludes jail&#39;s interfaces on a FreeBSD host thus not me
> =
> > ssing up the classes on a FreeBSD jail host system. [1]</div><div><br>
> > </div>
> > <div>The feature currently excludes jail&#39;s interfaces for jails with on
> =
> > ly 1 assigned IP addresses and does not work when your jails have multiple 
> =
> > IP addresses. There is a PR logged for this one as well, so anyone wishing 
> =
> > to help out with that is also welcome. [2]</div>
> > 
> > <div><br></div><div>Regards,</div><div>Marin</div><div><br></div><div>[1]=
> > =A0<a href=3D"https://cfengine.com/bugtracker/view.php?id=3D639" target=3D"
> =
> > _blank">https://cfengine.com/bugtracker/view.php?id=3D639</a></div><div>[2]
> =
> > =A0<a href=3D"https://cfengine.com/bugtracker/view.php?id=3D741" target=3D"
> =
> > _blank">https://cfengine.com/bugtracker/view.php?id=3D741</a></div>
> > 
> > <div><br></div><font color=3D"#888888">-- <br>Marin Atanasov Nikolov<br><br
> =
> > >dnaeon AT gmail DOT com<br>daemon AT unix-heaven DOT org<br>
> > <a href=3D"http://www.unix-heaven.org/" target=3D"_blank">http://www.unix-h
> =
> > eaven.org/</a><br>
> > </font></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>Marin
> =
> >  Atanasov Nikolov<br><br>dnaeon AT gmail DOT com<br>daemon AT unix-heaven D
> =
> > OT org<br><a href=3D"http://www.unix-heaven.org/" target=3D"_blank">http://
> =
> > www.unix-heaven.org/</a><br>
> > 
> > </div>
> > 
> > --20cf307ca1e807ecb504acaf6c0a--
>
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-09-20 06:09:04 UTC
cy          2011-09-20 05:08:49 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/cfengine3   Makefile distinfo pkg-plist 
  Log:
  Update 3.1.5 --> 3.2.1.
  
  PR:             160355 (3.2.0)
  Submitted by:   Wojtek Kochanowski <wojciech.kochanowski@nnv.pl>
  
  Revision  Changes    Path
  1.58      +3 -3      ports/sysutils/cfengine3/Makefile
  1.25      +2 -2      ports/sysutils/cfengine3/distinfo
  1.20      +232 -227  ports/sysutils/cfengine3/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Cy Schubert freebsd_committer freebsd_triage 2011-09-20 06:09:14 UTC
State Changed
From-To: analyzed->closed

Committed your patch (3.2.1 instead).