Bug 160394 - [UPDATE] www/py-surl: depend on simplejson conditionally
Summary: [UPDATE] www/py-surl: depend on simplejson conditionally
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Carlo Strub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 15:10 UTC by R.Mahmatkhanov
Modified: 2011-09-21 08:02 UTC (History)
0 users

See Also:


Attachments
file.diff (888 bytes, patch)
2011-09-02 15:10 UTC, R.Mahmatkhanov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R.Mahmatkhanov 2011-09-02 15:10:09 UTC
Right now this port uncoditionally depends on devel/py-simplejson, but it actually should not. They use native json module if running on python 2.6+ and use external simplejson if python < 2.6. 

"""
try:
    import json
except ImportError:
    try:
        import simplejson as json
    except ImportError:
        sys.stderr.write("Warning: json module could not load\n")
"""

This patch make it depend on devel/py-simplejson only if python version < 2.6.
And this is actually run dependency, so remove it from BUILD_DEPENDS too.

tag: simplejson26

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-02 15:10:17 UTC
Maintainer of www/py-surl,

Please note that PR ports/160394 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160394

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-02 15:10:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Greg Larkin freebsd_committer freebsd_triage 2011-09-13 15:54:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cs

Reassign to maintainer who is a new committer.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-09-21 07:59:22 UTC
cs          2011-09-21 06:59:13 UTC

  FreeBSD ports repository

  Modified files:
    www/py-surl          Makefile 
  Log:
  Depend on simplejson conditionally
  
  PR:             ports/160394
  Submitted by:   Ruslan Mahmatkhanov <cvs-src@yandex.ru>
  Approved by:    wen@ (co-mentor)
  
  Revision  Changes    Path
  1.4       +8 -4      ports/www/py-surl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Carlo Strub freebsd_committer freebsd_triage 2011-09-21 08:00:48 UTC
State Changed
From-To: feedback->closed

Committed. Thank you very much for submitting your patch.