In pkg-install, it checks the wrong argument. $ARGV[1] in Perl is not $1 but $2 in sh(1). (Result: The script does nothing.) In pkg-deinstall, it doesn't check the argument. (Result: The script runs twice.) And this script deletes fonts.alias.orig last. I think this behavior is not good. In the both script, "pattern) list ;;" combination in a "case" command is wrong. (Result: The all previous entries of fonts.alias are lost.) The maintainer says he has not had a testing environment, and he has approved my patch. Fix: After applied my patch: capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 19623 Sep 3 11:27 /usr/local/lib/X11/fonts/local/fonts.alias capricorn# make install ===> Vulnerability check disabled, database not found (snip) ===> Registering installation for ja-alias-fonts-1.0_5 capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 34048 Sep 3 11:28 /usr/local/lib/X11/fonts/local/fonts.alias -rw-r--r-- 1 root wheel 19623 Sep 3 11:27 /usr/local/lib/X11/fonts/local/fonts.alias.orig capricorn# make deinstall ===> Deinstalling for japanese/alias-fonts ===> Deinstalling ja-alias-fonts-1.0_5 capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 19623 Sep 3 11:28 /usr/local/lib/X11/fonts/local/fonts.alias -rw-r--r-- 1 root wheel 34048 Sep 3 11:28 /usr/local/lib/X11/fonts/local/fonts.alias.orig capricorn# The patch is here: How-To-Repeat: capricorn# cd /usr/ports/japanese/alias-fonts capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 19623 Sep 3 11:10 /usr/local/lib/X11/fonts/local/fonts.alias capricorn# make install ===> Vulnerability check disabled, database not found ===> License check disabled, port has not defined LICENSE ===> Extracting for ja-alias-fonts-1.0_5 ===> Vulnerability check disabled, database not found ===> License check disabled, port has not defined LICENSE ===> Patching for ja-alias-fonts-1.0_5 ===> ja-alias-fonts-1.0_5 depends on executable: bdftopcf - found ===> ja-alias-fonts-1.0_5 depends on executable: mkfontdir - found ===> ja-alias-fonts-1.0_5 depends on executable: mkfontscale - found ===> Configuring for ja-alias-fonts-1.0_5 ===> Installing for ja-alias-fonts-1.0_5 ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/jpnhn4-iso.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/5x10B.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/share/font-shinonome/shnmk12.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/kanji18.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/k20b.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/kanji26.pcf.gz - found ===> ja-alias-fonts-1.0_5 depends on file: /usr/local/lib/X11/fonts/local/K12-1.pcf.gz - found ===> Generating temporary packing list ===> Checking if japanese/alias-fonts already installed ===> Registering installation for ja-alias-fonts-1.0_5 capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 19623 Sep 3 11:10 /usr/local/lib/X11/fonts/local/fonts.alias ### Not updated. capricorn# make deinstall ===> Deinstalling for japanese/alias-fonts ===> Deinstalling ja-alias-fonts-1.0_5 capricorn# ls -l /usr/local/lib/X11/fonts/local/fonts.alias* -rw-r--r-- 1 root wheel 0 Sep 3 11:15 /usr/local/lib/X11/fonts/local/fonts.alias ### All entries are lost. capricorn#
Maintainer of japanese/alias-fonts, Please note that PR ports/160414 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160414 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
State Changed From-To: feedback->open Text claims that maintainer has approved the patch.
tota 2011-09-19 14:45:01 UTC FreeBSD ports repository Modified files: japanese/alias-fonts Makefile pkg-deinstall Log: - Fix pkg-deinstall script [1] - Bump PORTREVISION, accordingly PR: ports/160414 [1] Submitted by: WATANABE Kazuhiro <CQG00620_AT_nifty_DOT_ne_DOT_jp> [1] Approved by: maintainer Revision Changes Path 1.23 +1 -1 ports/japanese/alias-fonts/Makefile 1.6 +5 -3 ports/japanese/alias-fonts/pkg-deinstall _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!