Bug 160571 - [PATCH] www/tomcat55: allow for separate java start arguments in rc script
Summary: [PATCH] www/tomcat55: allow for separate java start arguments in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-08 21:50 UTC by Phil Phillips
Modified: 2011-09-11 13:10 UTC (History)
0 users

See Also:

Attachments
file.diff (2.33 KB, patch)
2011-09-08 21:50 UTC, Phil Phillips 		no flags Details | Diff
tomcat55.patch.txt (2.37 KB, text/plain)
2011-09-08 22:17 UTC, Phil Phillips 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Phillips 2011-09-08 21:50:04 UTC 
The stop and start routines in the tomcat55 rc script pass the same java arguments no matter what.

There are a few cases where someone might want to start tomcat with different java arguments (i.e. enable Java debugging/JDWP).

Here's a patch that will allow users to specify additional java arguments for tomcat startup only.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-08 21:50:12 UTC 
Maintainer of www/tomcat55,

Please note that PR ports/160571 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/160571

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-09-08 21:50:14 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Phil Phillips 2011-09-08 22:17:36 UTC 
Updating patch to include %%TOMCAT_VERSION%% where needed.
Comment 4 Jason 2011-09-09 00:17:15 UTC 
Looks good to me.

-jgh

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 5 Chris Rees freebsd_committer freebsd_triage 2011-09-10 09:58:54 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-09-11 13:04:33 UTC 
crees       2011-09-11 12:04:20 UTC

  FreeBSD ports repository

  Modified files:
    www/tomcat55         Makefile 
    www/tomcat55/files   tomcat55.sh.in 
  Added files:
    www/tomcat55/files   patch-conf-server.xml 
  Removed files:
    www/tomcat55/files   patch-conf::server.xml 
  Log:
  - Allow user to add flags for startup case only
  - (while here, stop using '::' in patchfile names)
  
  PR:             ports/160571
  Submitted by:   Phil Phillips <pphillips@experts-exchange.com>
  Approved by:    Jason Helfman <jhelfman@e-e.com> (maintainer)
  
  Revision  Changes    Path
  1.63      +1 -1      ports/www/tomcat55/Makefile
  1.1       +39 -0     ports/www/tomcat55/files/patch-conf-server.xml (new)
  1.6       +0 -37     ports/www/tomcat55/files/patch-conf::server.xml (dead)
  1.12      +17 -6     ports/www/tomcat55/files/tomcat55.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Chris Rees freebsd_committer freebsd_triage 2011-09-11 13:05:50 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!